public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ravb: ravb_close() always returns 0

Browse source 
ravb_close() always returns 0, hence the check in ravb_wol_restore() is
pointless (however, we cannot change the prototype of ravb_close() as it
implements the driver's ndo_stop() method).

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Sergey Shtylyov 2022-01-29 14:55:16 +03:00 • committed by David S. Miller
parent cc4598cf17
commit be94a51f3e
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/net/ethernet/renesas/ravb_main.c
View file

@ -2848,7 +2848,6 @@ static int ravb_wol_restore(struct net_device *ndev)
{ {
struct ravb_private *priv = netdev_priv(ndev); struct ravb_private *priv = netdev_priv(ndev);
const struct ravb_hw_info *info = priv->info; const struct ravb_hw_info *info = priv->info;
int ret;
if (info->nc_queues) if (info->nc_queues)
napi_enable(&priv->napi[RAVB_NC]); napi_enable(&priv->napi[RAVB_NC]);
@ -2857,9 +2856,7 @@ static int ravb_wol_restore(struct net_device *ndev)
/* Disable MagicPacket */ /* Disable MagicPacket */
ravb_modify(ndev, ECMR, ECMR_MPDE, 0); ravb_modify(ndev, ECMR, ECMR_MPDE, 0);
ret = ravb_close(ndev); ravb_close(ndev);
if (ret < 0)
return ret;
return disable_irq_wake(priv->emac_irq); return disable_irq_wake(priv->emac_irq);
} }