public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

net/fsl: xgmac_mdio: fix return value check in xgmac_mdio_probe()

Browse source 
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Fixes: 1d14eb15dc ("net/fsl: xgmac_mdio: Use managed device resources")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Tobias Waldekranz <tobias@waldekranz.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Wei Yongjun 2022-01-29 01:27:02 +00:00 • committed by David S. Miller
parent 47ed9442b2
commit cc4598cf17
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/ethernet/freescale/xgmac_mdio.c
View file

@ -335,8 +335,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
priv = bus->priv;
priv->mdio_base = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
if (IS_ERR(priv->mdio_base))
return PTR_ERR(priv->mdio_base);
if (!priv->mdio_base)
return -ENOMEM;
/* For both ACPI and DT cases, endianness of MDIO controller
* needs to be specified using "little-endian" property.