Commit graph

91 commits

Author SHA1 Message Date
David Sinclair
61a968e368 Merge branch 'dejal' into catalyst 2023-01-05 18:20:55 -06:00
David Sinclair
c95bf08a5f #1771 (cannot delete or move top level feed)
- Fixed.
- Investigating wacky situation where the table could attempt to access an out-of-range cell.
2023-01-04 21:29:06 -06:00
David Sinclair
a1777280d9 #1720 (Grid view)
- Work in progress on refactoring the feed detail cell to view-based Swift, to make it easier to maintain, and to use autolayout to rearrange the content.
2022-12-12 22:04:04 -06:00
David Sinclair
3b1c824ab3 Merge branch 'dejal' into catalyst 2022-11-24 20:30:06 -06:00
David Sinclair
4e6493afb0 #1751 (don't allow double-tap to open original story while on story titles)
- This reverts commit 7da4a868495013f3f1f09a5484f076d244603bba., so iPad is back to previous default.
- Also changed it to completely remove the option on iPhone.
2022-11-23 19:37:18 -06:00
David Sinclair
7d5018ce2c Merge branch 'dejal' into catalyst 2022-11-09 19:57:56 -07:00
David Sinclair
7da4a86849 #1751 (don't allow double-tap to open original story while on story titles) 2022-11-09 19:45:14 -07:00
David Sinclair
fa71dde865 #1720 (Grid view)
- Updating the story view, including sizing to fit.
- Hiding the loading notifier.
- Implemented the grid cell heights.
2022-10-27 20:53:47 -06:00
David Sinclair
27d86b46bb #1720 (Grid view)
- Settings menu in grid view.
- Properly changing layouts.
2022-10-27 15:19:31 -06:00
David Sinclair
2976818a2f #1720 (Grid view)
- Grid view selection.
2022-10-26 21:57:42 -06:00
David Sinclair
38cca00984 #1720 (Grid view)
- Selection improvements.
2022-10-26 20:50:07 -06:00
David Sinclair
572400cd11 #1720 (Grid view)
- More work in progress.
2022-10-08 14:54:49 -06:00
David Sinclair
3705f73bc7 Merge branch 'dejal' into catalyst
# Conflicts:
#	clients/ios/Classes/FeedDetailObjCViewController.m
2022-09-25 19:35:25 -06:00
David Sinclair
6c012330b7 #1732 (new preference to load next feed on mark read)
- Added keyboard shortcuts to go to the Next and Previous Folder and Site in the feeds list.
- Added preference to go to the next feed on mark read. On by default.
- If that pref is on, it uses the keyboard methods to do that.
2022-09-24 21:36:40 -06:00
David Sinclair
f9d27694e0 #1729 (single line titles take too much vertical space)
- Improved the spacing.
- The spacing is kinda a hack of guessing good heights; it will likely become much smarter with the grid view changes.
2022-09-21 21:47:23 -06:00
David Sinclair
eca9fd3f6f #1720 (Grid view)
- Work in progress.
2022-09-03 21:24:36 -06:00
David Sinclair
45044060af #1720 (Grid view)
- Work in progress.
2022-09-03 19:55:21 -06:00
David Sinclair
a54b423aa1 #1720 (Grid view)
- Work in progress.
2022-09-02 20:39:00 -06:00
David Sinclair
f0f06ac21b #1720 (Grid view)
- More work in progress.
2022-08-30 19:00:35 -07:00
David Sinclair
926181327a #1720 (Grid view)
- Added a Grid layout option to the feed detail menu.
- In Grid layout, the title length and image position options are replaced by grid columns and grid height options.
- When chosen, the right panes are replaced by a Grid view.
- This is a work in progress.
2022-08-19 19:21:00 -07:00
David Sinclair
7e572477a5 #1723 (some thumbnails not showing on app but do show on the web)
- Changed the preview image caching to try each of the story images in turn until a valid one (not missing or too small) is found.
- Only loads one image for each story initially, loading more if needed.
- Now caches based on the story hash instead of image URL.
2022-08-18 20:44:08 -07:00
David Sinclair
bb721b7b09 #1693 (2022 Redesign)
- More tweaks to the feed detail layout.
2022-08-18 17:00:32 -07:00
David Sinclair
bc35c84bf7 #1693 (2022 Redesign)
- Replaced the feeds list notificaitons icon.
- The feed detail folder title icon now matches the color.
- Changed all of the settings icons to the new style.
- Changed the feed detail mark read icon.
- Changed the focus and hidden unread indicators.
- Unread indicators sized to match the web.
- Tweaked feed detail spacing.
- Increased feed detail titles to up to three lines.
- Titlecased Interactions / Your Activities.
- Removed borders and tweaked section titles in trainer.
2022-08-17 21:48:20 -07:00
David Sinclair
1258e88dd0 #1693 (2022 Redesign)
Feeds list:

- Updated Focus and Saved icons. (Note, can’t use color on just one component of a segmented control, so uses the same color for all.)

Feed detail list:

- Now updates the title when updating the theme.
- Increased the horizontal spacing.
- Increased the title font size by 1 point.

Story detail:

- Fixed the cutoff icon.
2022-08-04 17:29:51 -07:00
David Sinclair
c8e617eb5f #1693 (2022 Redesign)
Feeds list:

- Fixed dark areas next to nested folders.
- The feeds list background colors now match the web.
- Adjusted the color of the icons.
- Changing the font size or comfort layout no longer dismisses the menu or reloads.

Feed detail:

- A story with a short title in two-line mode now has a shorter cell.
- Fixed multiple rows being selected.
- Comfortable layout now has larger top and bottom margins.
- Fixed notification icon in menu.
- Fixed saved_searches appearing in move submenu.
- Adjusted the height for feeds.
- Changing the title, image, font size, or comfort layout no longer dismisses the menu or reloads.

Story:

- Lighter header color.
- Updated icons and removed borders for share/save/train buttons.
- Updated the trainer popover to use the new style.
2022-08-03 21:42:28 -07:00
David Sinclair
d944eaaebb #1697 (clean scroll stutter on iPhone)
- Heaviest activity was scaling story thumbnails on the main thread; moved to a background thread.
- No more heavy activity when scrolling shown in Instruments.
2022-07-22 21:33:37 -07:00
David Sinclair
375e3757e2 #1693 (2022 Redesign)
- Laboriously updated the icons (finding the names in the web inspector, updating the code, inspecting the colors, setting those separately, dealing with scaling issues, etc etc).
- Let me know if you spot any icons that I missed, or unscaled icons (they have to be explicitly sized, otherwise appear huge).
- More space between story title and story content.
- More space when reading a folder.
- Added Compact/Comfortable to feed detail menu.
- Changing Compact/Comfortable also adjusts the feed detail list.
- Adjusted the color of the story content etc in the feed detail list.
- Removed top and bottom borders from feed title gradient in story detail.
- More space in story detail header.
- The feed detail is offset when selected.
- Updated the feeds social, search, and saved background colors.
- Unread counts no longer have a shadow, and have more space.
- Folders and feeds remain selected in the feeds list when returning from a story or refreshing.
- Folders in the feeds list no longer have a different background color.
- The folders and feeds highlight is now rounded and unbordered like on web.
2022-07-20 21:35:16 -07:00
David Sinclair
609111e503 #1693 (2022 Redesign)
- Story titles author now next to date, and same color as content.
- Story titles now always bold.
- Story titles are now positioned to have equal top spacing (i.e. normalized).
- Unread indicator now top-aligned.
- Added border radius and margin to highlighted feeds.
- Feed favicons are now rounded.
- Blurblogs moved below folders.
- Fixed an issue with the feed detail settings for some folder types.
- Renamed All Stories to All Site Stories, to match web.
- Removed border from story content header.
2022-07-08 21:29:43 -07:00
David Sinclair
0d19caa7d4 #1704 (item from Infrequent site stories opens wrong story)
This one took a long time to reproduce and track down; it turned out that because the infrequent stories use a magical loading parameter, they are not suitable for offline caching; the offlien stories didn’t match the fetched one, thus messing up the cached next story page.
2022-07-07 21:04:30 -07:00
David Sinclair
597ead5582 #1686 (scroll performance on story titles) 2022-05-20 21:22:02 -06:00
David Sinclair
3162ab8523 #1565 (story titles image preview doesn’t show until scroll gesture is finished) 2022-05-04 21:37:42 -06:00
David Sinclair
f4b1eca8a9 Fixed crash when selecting a newly added feed on iPad 2022-05-03 14:31:10 -06:00
David Sinclair
a76429431f #1604 (preference for automatically opening folder)
- Added a new “When opening app” preference for what folder to show on launch.
- Implemented for both iPhone and iPad.
- Fixed loading default prefs.
- Removed the obsolete restore position preference.
- Enhanced the preferences views to support letting the app add custom values, to enable choosing any folder.
2022-04-22 19:23:40 -07:00
David Sinclair
d05a506b33 #1500 (load first story when opening feed)
- Fixed default behavior of “when opening a site” preference on iPad, so if the preference hasn’t been changed, shows the first story by default, matching the preference.
- Added support for this preference on iPhone, where it defaults to show the stories.
2022-04-21 20:33:11 -07:00
David Sinclair
a99c20fdf3 #1643 (canceling slide out in story list resets position) 2022-04-20 21:50:42 -07:00
David Sinclair
ec50da4ff9 #1659 (full screen button doesn't work when story titles on bottom)
- Fixed feeds list disappearing when selecting a feed.
- Fixed non-functional full-screen buttons in top and bottom layout.
- In top/bottom full-screen mode, a Sites button appears to show the sidebar (or can use edge swipe).
2022-04-01 17:54:01 -07:00
David Sinclair
f08cb23bb3 Fixed #1656 (odd 1px white border at bottom of story list) 2022-03-31 21:24:44 -07:00
David Sinclair
09ac81ecce #1607 (widget is slow to reload)
- Added a new smart folder for Widget Site Stories, above Read Stories towards the bottom.
- It lists stories from the feeds the widget displays.
- Loading a story from the widget uses this feed, so it’s much faster (doesn’t have to keep loading to find the story).
2022-03-09 19:16:43 -07:00
David Sinclair
3722d53121 #1334 (modern widget)
- Fixed issue with iPhone not loading a story.
- Added logic to better handle not finding a story for other reasons.
2022-01-27 20:06:50 -08:00
David Sinclair
12e9b172a5 #1500 (show first story options)
- On iPad, added a feed detail preference to open the first story (default) or list the stories
- Didn't do this on iPhone, as it makes less sense there; going back from the story to the list would just bounce back into the story. I could add extra logic to avoid that if you really want this option on iPhone too.
- Both are back to the old marking as read behavior.
2022-01-25 15:14:30 -08:00
David Sinclair
696bb658e0 Fixed some crashers from TestFlight 2022-01-24 20:17:03 -08:00
David Sinclair
4c0e4d4b64 Fixed #1587 (Share text lost if switching back and forth into app) 2022-01-24 19:28:46 -08:00
David Sinclair
738bdda220 #1579 (focus changes) 2021-12-20 21:20:52 -07:00
David Sinclair
b4c2bf3031 #1571 (feeds list layout issues in iOS 15)
- Fixed extra spacing in Feeds list.
- Fixed header background color changing when scrolled to the top.
2021-12-08 20:50:10 -07:00
David Sinclair
b5a4c377b6 #1566 (finding story weird animation) 2021-12-07 19:55:03 -07:00
David Sinclair
c592b05fb4 #1522 (story titles sometimes run long) 2021-08-20 21:45:09 -07:00
David Sinclair
37552d1f5c #1530 (search bar unreachable)
- Fixed the search field not remaining visible on iPhone.
- Added a 1 second delay while typing before performing the search.
- Fixed field scrolling away when searching.
2021-08-20 19:47:06 -07:00
David Sinclair
d882618136 #1533 (selected story on swipe back) 2021-08-19 20:43:16 -07:00
David Sinclair
89e12f1d13 #1536 (unread counts not updating)
- That was a tricky one, but I traced it to a race condition between unecessarily refreshing the feeds list and marking as read. Fixed.
2021-08-19 19:45:01 -07:00
David Sinclair
6421b63ab0 #1510 (show story when tapping selected row) 2021-07-05 16:56:24 -07:00