public-mirrors/NewsBlur
1
0
Fork 0
mirror of https://github.com/samuelclay/NewsBlur.git synced 2025-09-18 21:50:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

#1771 (cannot delete or move top level feed)

Browse source 
- Fixed.
- Investigating wacky situation where the table could attempt to access an out-of-range cell.
This commit is contained in:
David Sinclair 2023-01-04 21:29:06 -06:00
parent c1c96d1a1e
commit c95bf08a5f
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
clients/ios/Classes/FeedDetailObjCViewController.m
View file

@ -2300,7 +2300,7 @@ didEndSwipingSwipingWithState:(MCSwipeTableViewCellState)state
}
}
if (!everything && !infrequent && !saved && !read && !social && !widget) {
if ((!everything || !appDelegate.storiesCollection.isRiverView) && !infrequent && !saved && !read && !social && !widget) {
NSString *manageText = [NSString stringWithFormat:@"Manage this %@", appDelegate.storiesCollection.isRiverView ? @"folder" : @"site"];
[viewController addTitle:manageText iconName:@"menu_icn_move.png" selectionShouldDismiss:NO handler:^{
@ -2489,7 +2489,7 @@ didEndSwipingSwipingWithState:(MCSwipeTableViewCellState)state
__weak MenuViewController *weakViewController = viewController;
viewController.title = manageText;
if (!everything) {
if (!everything || !appDelegate.storiesCollection.isRiverView) {
NSString *deleteText = [NSString stringWithFormat:@"Delete %@",
appDelegate.storiesCollection.isRiverView ?
@"this entire folder" :

10
clients/ios/Classes/FeedsObjCViewController.m
View file

@ -1476,13 +1476,21 @@ static NSArray<NSString *> *NewsBlurTopSectionNames;
count = limit;
}
// NSLog(@"Folder %@ contains %@ feeds", folderName, @(count)); // log
return count;
}
- (UITableViewCell *)tableView:(UITableView *)tableView
cellForRowAtIndexPath:(NSIndexPath *)indexPath {
NSString *folderName = [appDelegate.dictFoldersArray objectAtIndex:indexPath.section];
id feedId = [[appDelegate.dictFolders objectForKey:folderName] objectAtIndex:indexPath.row];
NSArray *folder = [appDelegate.dictFolders objectForKey:folderName];
if (indexPath.row >= folder.count) {
NSLog(@"Detected attempt to access row %@ of %@ when there are only %@; this will crash!", @(indexPath.row), folderName, @(folder.count)); // log
}
id feedId = [folder objectAtIndex:indexPath.row];
NSString *feedIdStr = [NSString stringWithFormat:@"%@",feedId];
BOOL isSavedSearch = [appDelegate isSavedSearch:feedIdStr];
NSString *searchQuery = [appDelegate searchQueryForFeedId:feedIdStr];