Commit graph

104 commits

Author SHA1 Message Date
David Sinclair
aa6380c15a Crash fixes 2023-10-23 19:43:59 -05:00
David Sinclair
f64007b734 #1720 (Grid view)
- Fixed theme jumping from light to dark (seemed to be caused by a recent iOS change).
- Fixed fading out of list cells.
- Hopefully fixed infinite loading indicator.
- Fixed background crashes.
2023-08-24 21:47:19 -06:00
David Sinclair
75e4fb7e85 #1720 (Grid view)
- Fixed list view stories incorrectly marked as read.
- Fixed grid view wrong dates in story header.
- Fixed grid view heading not matching story.
- Fixed grid view showing the wrong story.
- Fixed grid view duplicate stories.
- Tapping grid view story heading now scrolls to show that story’s card.
- Now always shows the Sites button in non-left layout, since the collapse fullscreen button doesn’t seem to work.
- Fixed crash with malformed story.
- Fixed loading feeds in different layouts.
- And some other tweaks.
2023-08-11 11:40:13 -06:00
David Sinclair
c39341fea7 #1720 (Grid view)
- Fixes for iPad.
2023-07-21 21:15:24 -06:00
David Sinclair
295667a308 #1720 (Grid view)
- Tweaked the grid view background color for several themes.
- The list/grid layout is now a per-folder and per-feed setting.
- Fixed some issues revealed by that change.
- Fixed crash with reloading individual rows (witnessed when scrolling and loading images, I think).
- Fixed deselection of stories in the list layout.
2023-07-20 21:07:56 -06:00
David Sinclair
a2341690b4 #1720 (Grid view)
- Fixed the grid view not changing with the theme.
- Fixed a gap at the top of the story view.
- Fixed a crash in some situations due to not loading the view.
- Fixed grid layout glitch returning to the grid view from the stories view.
- Swipe left on grid card to mark read; swipe right to mark unread.
- Added support for disabling mark read on scroll.
2023-06-15 21:53:00 -07:00
David Sinclair
fec83d79b6 #1720 (Grid view)
- Restored the legacy table view for the list layout.
- Still uses the modern SwiftUI view for the grid layout.
- Added an option in Preferences (below the “Story titles layout” for “List style”, to choose between “Standard” (aka the table) and “Experimental” (aka the grid-based list) so we can continue to improve the nicer modern list.
- Removed the swipe gesture from the grid view.
- Fixed a crash putting the app in the background.
- Fixed some other issues.
2023-05-25 21:47:34 -07:00
David Sinclair
66d148d3a1 #1720 (Grid view)
- In Grid layout, when the number of columns is set to Auto, it uses 4 columns for landscape and 2 columns for portrait.
- In Grid layout, if the number columns is 4, it only displays 3 in portrait, since 4 won’t fit.
- Removed the old collection view; code referencing it is left commented out for now, just in case any is needed later.
- Now respects the safe area at the bottom of the screen.
- Added support for pull-to-refresh.
- Added a progress indicator when loading (nicer than the old flashing row, I think).
- Deselecting a story in Grid view now avoids scrolling.
2023-04-21 21:44:28 -07:00
David Sinclair
0475969c32 #1720 (Grid view)
- Fixed not showing story content when switching from List to Grid layout.
- Fixed sometimes showing the wrong story when switching from Grid to List layout.
- Fixed scrolling to the story when switching from List to Grid layout.
- Some cleanup.
2023-04-19 21:35:34 -07:00
David Sinclair
9f7a0ffa81 #1720 (Grid view)
- Moving logic from collection view code to story cache.
- Commenting out collection view code; keeping for now in case any of it is needed.
- More investigating List to Grid switch issue.
2023-03-31 22:02:58 -07:00
David Sinclair
f703d58b94 #1720 (Grid view)
- Added support for the Grid layout on iPhone, with one or two columns. Works fairly well.
- Bumped up the feed title & date/author font size again.
- Now markes as read on scroll when the card is scrolled halfway off the top.
2023-03-30 10:36:31 -07:00
David Sinclair
8e522075fa #1720 (Grid view)
- Implemented marking as read on scroll.
- Increased the font size of the feed title and date/author.
- The read state of stories is now indicated correctly, including dimming read stories.
- Selecting a story scrolls to it, with animation.
2023-03-21 21:54:21 -07:00
David Sinclair
ab9e305e38 #1720 (Grid view)
- The story view on Grid layout now resizes to fit the content.
- The story view scrolls as part of the Grid.
- Selecting a story scrolls to it in Grid layout, most of the time.
2023-03-03 21:38:55 -07:00
David Sinclair
61a968e368 Merge branch 'dejal' into catalyst 2023-01-05 18:20:55 -06:00
David Sinclair
c95bf08a5f #1771 (cannot delete or move top level feed)
- Fixed.
- Investigating wacky situation where the table could attempt to access an out-of-range cell.
2023-01-04 21:29:06 -06:00
David Sinclair
a1777280d9 #1720 (Grid view)
- Work in progress on refactoring the feed detail cell to view-based Swift, to make it easier to maintain, and to use autolayout to rearrange the content.
2022-12-12 22:04:04 -06:00
David Sinclair
3b1c824ab3 Merge branch 'dejal' into catalyst 2022-11-24 20:30:06 -06:00
David Sinclair
4e6493afb0 #1751 (don't allow double-tap to open original story while on story titles)
- This reverts commit 7da4a868495013f3f1f09a5484f076d244603bba., so iPad is back to previous default.
- Also changed it to completely remove the option on iPhone.
2022-11-23 19:37:18 -06:00
David Sinclair
7d5018ce2c Merge branch 'dejal' into catalyst 2022-11-09 19:57:56 -07:00
David Sinclair
7da4a86849 #1751 (don't allow double-tap to open original story while on story titles) 2022-11-09 19:45:14 -07:00
David Sinclair
fa71dde865 #1720 (Grid view)
- Updating the story view, including sizing to fit.
- Hiding the loading notifier.
- Implemented the grid cell heights.
2022-10-27 20:53:47 -06:00
David Sinclair
27d86b46bb #1720 (Grid view)
- Settings menu in grid view.
- Properly changing layouts.
2022-10-27 15:19:31 -06:00
David Sinclair
2976818a2f #1720 (Grid view)
- Grid view selection.
2022-10-26 21:57:42 -06:00
David Sinclair
38cca00984 #1720 (Grid view)
- Selection improvements.
2022-10-26 20:50:07 -06:00
David Sinclair
572400cd11 #1720 (Grid view)
- More work in progress.
2022-10-08 14:54:49 -06:00
David Sinclair
3705f73bc7 Merge branch 'dejal' into catalyst
# Conflicts:
#	clients/ios/Classes/FeedDetailObjCViewController.m
2022-09-25 19:35:25 -06:00
David Sinclair
6c012330b7 #1732 (new preference to load next feed on mark read)
- Added keyboard shortcuts to go to the Next and Previous Folder and Site in the feeds list.
- Added preference to go to the next feed on mark read. On by default.
- If that pref is on, it uses the keyboard methods to do that.
2022-09-24 21:36:40 -06:00
David Sinclair
f9d27694e0 #1729 (single line titles take too much vertical space)
- Improved the spacing.
- The spacing is kinda a hack of guessing good heights; it will likely become much smarter with the grid view changes.
2022-09-21 21:47:23 -06:00
David Sinclair
eca9fd3f6f #1720 (Grid view)
- Work in progress.
2022-09-03 21:24:36 -06:00
David Sinclair
45044060af #1720 (Grid view)
- Work in progress.
2022-09-03 19:55:21 -06:00
David Sinclair
a54b423aa1 #1720 (Grid view)
- Work in progress.
2022-09-02 20:39:00 -06:00
David Sinclair
f0f06ac21b #1720 (Grid view)
- More work in progress.
2022-08-30 19:00:35 -07:00
David Sinclair
926181327a #1720 (Grid view)
- Added a Grid layout option to the feed detail menu.
- In Grid layout, the title length and image position options are replaced by grid columns and grid height options.
- When chosen, the right panes are replaced by a Grid view.
- This is a work in progress.
2022-08-19 19:21:00 -07:00
David Sinclair
7e572477a5 #1723 (some thumbnails not showing on app but do show on the web)
- Changed the preview image caching to try each of the story images in turn until a valid one (not missing or too small) is found.
- Only loads one image for each story initially, loading more if needed.
- Now caches based on the story hash instead of image URL.
2022-08-18 20:44:08 -07:00
David Sinclair
bb721b7b09 #1693 (2022 Redesign)
- More tweaks to the feed detail layout.
2022-08-18 17:00:32 -07:00
David Sinclair
bc35c84bf7 #1693 (2022 Redesign)
- Replaced the feeds list notificaitons icon.
- The feed detail folder title icon now matches the color.
- Changed all of the settings icons to the new style.
- Changed the feed detail mark read icon.
- Changed the focus and hidden unread indicators.
- Unread indicators sized to match the web.
- Tweaked feed detail spacing.
- Increased feed detail titles to up to three lines.
- Titlecased Interactions / Your Activities.
- Removed borders and tweaked section titles in trainer.
2022-08-17 21:48:20 -07:00
David Sinclair
1258e88dd0 #1693 (2022 Redesign)
Feeds list:

- Updated Focus and Saved icons. (Note, can’t use color on just one component of a segmented control, so uses the same color for all.)

Feed detail list:

- Now updates the title when updating the theme.
- Increased the horizontal spacing.
- Increased the title font size by 1 point.

Story detail:

- Fixed the cutoff icon.
2022-08-04 17:29:51 -07:00
David Sinclair
c8e617eb5f #1693 (2022 Redesign)
Feeds list:

- Fixed dark areas next to nested folders.
- The feeds list background colors now match the web.
- Adjusted the color of the icons.
- Changing the font size or comfort layout no longer dismisses the menu or reloads.

Feed detail:

- A story with a short title in two-line mode now has a shorter cell.
- Fixed multiple rows being selected.
- Comfortable layout now has larger top and bottom margins.
- Fixed notification icon in menu.
- Fixed saved_searches appearing in move submenu.
- Adjusted the height for feeds.
- Changing the title, image, font size, or comfort layout no longer dismisses the menu or reloads.

Story:

- Lighter header color.
- Updated icons and removed borders for share/save/train buttons.
- Updated the trainer popover to use the new style.
2022-08-03 21:42:28 -07:00
David Sinclair
d944eaaebb #1697 (clean scroll stutter on iPhone)
- Heaviest activity was scaling story thumbnails on the main thread; moved to a background thread.
- No more heavy activity when scrolling shown in Instruments.
2022-07-22 21:33:37 -07:00
David Sinclair
375e3757e2 #1693 (2022 Redesign)
- Laboriously updated the icons (finding the names in the web inspector, updating the code, inspecting the colors, setting those separately, dealing with scaling issues, etc etc).
- Let me know if you spot any icons that I missed, or unscaled icons (they have to be explicitly sized, otherwise appear huge).
- More space between story title and story content.
- More space when reading a folder.
- Added Compact/Comfortable to feed detail menu.
- Changing Compact/Comfortable also adjusts the feed detail list.
- Adjusted the color of the story content etc in the feed detail list.
- Removed top and bottom borders from feed title gradient in story detail.
- More space in story detail header.
- The feed detail is offset when selected.
- Updated the feeds social, search, and saved background colors.
- Unread counts no longer have a shadow, and have more space.
- Folders and feeds remain selected in the feeds list when returning from a story or refreshing.
- Folders in the feeds list no longer have a different background color.
- The folders and feeds highlight is now rounded and unbordered like on web.
2022-07-20 21:35:16 -07:00
David Sinclair
609111e503 #1693 (2022 Redesign)
- Story titles author now next to date, and same color as content.
- Story titles now always bold.
- Story titles are now positioned to have equal top spacing (i.e. normalized).
- Unread indicator now top-aligned.
- Added border radius and margin to highlighted feeds.
- Feed favicons are now rounded.
- Blurblogs moved below folders.
- Fixed an issue with the feed detail settings for some folder types.
- Renamed All Stories to All Site Stories, to match web.
- Removed border from story content header.
2022-07-08 21:29:43 -07:00
David Sinclair
0d19caa7d4 #1704 (item from Infrequent site stories opens wrong story)
This one took a long time to reproduce and track down; it turned out that because the infrequent stories use a magical loading parameter, they are not suitable for offline caching; the offlien stories didn’t match the fetched one, thus messing up the cached next story page.
2022-07-07 21:04:30 -07:00
David Sinclair
597ead5582 #1686 (scroll performance on story titles) 2022-05-20 21:22:02 -06:00
David Sinclair
3162ab8523 #1565 (story titles image preview doesn’t show until scroll gesture is finished) 2022-05-04 21:37:42 -06:00
David Sinclair
f4b1eca8a9 Fixed crash when selecting a newly added feed on iPad 2022-05-03 14:31:10 -06:00
David Sinclair
a76429431f #1604 (preference for automatically opening folder)
- Added a new “When opening app” preference for what folder to show on launch.
- Implemented for both iPhone and iPad.
- Fixed loading default prefs.
- Removed the obsolete restore position preference.
- Enhanced the preferences views to support letting the app add custom values, to enable choosing any folder.
2022-04-22 19:23:40 -07:00
David Sinclair
d05a506b33 #1500 (load first story when opening feed)
- Fixed default behavior of “when opening a site” preference on iPad, so if the preference hasn’t been changed, shows the first story by default, matching the preference.
- Added support for this preference on iPhone, where it defaults to show the stories.
2022-04-21 20:33:11 -07:00
David Sinclair
a99c20fdf3 #1643 (canceling slide out in story list resets position) 2022-04-20 21:50:42 -07:00
David Sinclair
ec50da4ff9 #1659 (full screen button doesn't work when story titles on bottom)
- Fixed feeds list disappearing when selecting a feed.
- Fixed non-functional full-screen buttons in top and bottom layout.
- In top/bottom full-screen mode, a Sites button appears to show the sidebar (or can use edge swipe).
2022-04-01 17:54:01 -07:00
David Sinclair
f08cb23bb3 Fixed #1656 (odd 1px white border at bottom of story list) 2022-03-31 21:24:44 -07:00