public-mirrors/NewsBlur
1
0
Fork 0
mirror of https://github.com/samuelclay/NewsBlur.git synced 2025-09-18 21:50:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Adding long press menu to images. See the alt text (perfect for reading xkcd), copy image, save image to camera roll, or zoom image.

Browse source
This commit is contained in:
Samuel Clay 2014-09-18 15:15:41 -07:00
parent 2ac65348cf
commit 2ef7f4f724
5 changed files with 82 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
clients/ios/Classes/StoryDetailViewController.h
View file

@ -14,7 +14,8 @@
@class ASIHTTPRequest;
@interface StoryDetailViewController : BaseViewController
<UIScrollViewDelegate, UIGestureRecognizerDelegate> {
<UIScrollViewDelegate, UIGestureRecognizerDelegate,
UIActionSheetDelegate> {
NewsBlurAppDelegate *appDelegate;
NSString *activeStoryId;
@ -25,6 +26,10 @@
BOOL pullingScrollview;
BOOL inTextView;
BOOL inDoubleTap;
NSURL *activeLongPressUrl;
NSInteger actionSheetViewImageIndex;
NSInteger actionSheetCopyImageIndex;
NSInteger actionSheetSaveImageIndex;
}
@property (nonatomic) IBOutlet NewsBlurAppDelegate *appDelegate;

81
clients/ios/Classes/StoryDetailViewController.m
View file

@ -17,6 +17,7 @@
#import "StoryPageControl.h"
#import "ASIHTTPRequest.h"
#import "ASIFormDataRequest.h"
#import "AFImageRequestOperation.h"
#import "Base64.h"
#import "Utilities.h"
#import "NSString+HTML.h"
@ -1471,18 +1472,40 @@ shouldStartLoadWithRequest:(NSURLRequest *)request
NSString *tagName = [webView stringByEvaluatingJavaScriptFromString:
[NSString stringWithFormat:@"linkAt(%li, %li, 'tagName');",
(long)pt.x,(long)pt.y]];
NSString *href = [webView stringByEvaluatingJavaScriptFromString:
[NSString stringWithFormat:@"linkAt(%li, %li, 'href');",
(long)pt.x,(long)pt.y]];
NSString *title = [webView stringByEvaluatingJavaScriptFromString:
[NSString stringWithFormat:@"linkAt(%li, %li, 'innerText');",
(long)pt.x,(long)pt.y]];
NSURL *url = [NSURL URLWithString:href];
if ([tagName isEqualToString:@"IMG"]) {
return;
NSString *title = [webView stringByEvaluatingJavaScriptFromString:
[NSString stringWithFormat:@"linkAt(%li, %li, 'title');",
(long)pt.x,(long)pt.y]];
NSString *alt = [webView stringByEvaluatingJavaScriptFromString:
[NSString stringWithFormat:@"linkAt(%li, %li, 'alt');",
(long)pt.x,(long)pt.y]];
NSString *src = [webView stringByEvaluatingJavaScriptFromString:
[NSString stringWithFormat:@"linkAt(%li, %li, 'src');",
(long)pt.x,(long)pt.y]];
title = title.length ? title : alt;
activeLongPressUrl = [NSURL URLWithString:src];
UIActionSheet *actions = [[UIActionSheet alloc] initWithTitle:title.length ? title : nil
delegate:self
cancelButtonTitle:@"Done"
destructiveButtonTitle:nil
otherButtonTitles:nil];
actionSheetViewImageIndex = [actions addButtonWithTitle:@"View and zoom"];
actionSheetCopyImageIndex = [actions addButtonWithTitle:@"Copy image"];
actionSheetSaveImageIndex = [actions addButtonWithTitle:@"Save to camera roll"];
[actions showInView:appDelegate.storyPageControl.view];
}
if ([tagName isEqualToString:@"A"]) {
NSString *href = [webView stringByEvaluatingJavaScriptFromString:
[NSString stringWithFormat:@"linkAt(%li, %li, 'href');",
(long)pt.x,(long)pt.y]];
NSString *title = [webView stringByEvaluatingJavaScriptFromString:
[NSString stringWithFormat:@"linkAt(%li, %li, 'innerText');",
(long)pt.x,(long)pt.y]];
NSURL *url = [NSURL URLWithString:href];
if (!href || ![href length]) return;
[appDelegate showSendTo:appDelegate.storyPageControl
@ -1496,6 +1519,38 @@ shouldStartLoadWithRequest:(NSURLRequest *)request
}
}
- (void)actionSheet:(UIActionSheet *)actionSheet clickedButtonAtIndex:(NSInteger)buttonIndex {
if (buttonIndex == actionSheetViewImageIndex) {
[appDelegate showOriginalStory:activeLongPressUrl];
} else if (buttonIndex == actionSheetCopyImageIndex ||
buttonIndex == actionSheetSaveImageIndex) {
[self fetchImage:activeLongPressUrl buttonIndex:buttonIndex];
}
}
- (void)fetchImage:(NSURL *)url buttonIndex:(NSInteger)buttonIndex {
[MBProgressHUD hideHUDForView:self.webView animated:YES];
[appDelegate.storyPageControl showShareHUD:buttonIndex == actionSheetCopyImageIndex ?
@"Copying..." : @"Saving..."];
NSURLRequest *urlRequest = [NSURLRequest requestWithURL:url];
AFImageRequestOperation *requestOperation = [[AFImageRequestOperation alloc] initWithRequest:urlRequest];
[requestOperation setCompletionBlockWithSuccess:^(AFHTTPRequestOperation *operation, id responseObject) {
UIImage *image = responseObject;
if (buttonIndex == actionSheetCopyImageIndex) {
[UIPasteboard generalPasteboard].image = image;
[self flashCheckmarkHud:@"copied"];
} else if (buttonIndex == actionSheetSaveImageIndex) {
UIImageWriteToSavedPhotosAlbum(image, nil, nil, nil);
[self flashCheckmarkHud:@"saved"];
}
} failure:^(AFHTTPRequestOperation *operation, NSError *error) {
[MBProgressHUD hideHUDForView:self.webView animated:YES];
[self informError:@"Could not fetch image"];
}];
[requestOperation start];
}
# pragma mark
# pragma mark Subscribing to blurblog
@ -1519,7 +1574,7 @@ shouldStartLoadWithRequest:(NSURLRequest *)request
- (void)finishSubscribeToBlurblog:(ASIHTTPRequest *)request {
[MBProgressHUD hideHUDForView:appDelegate.storyPageControl.view animated:NO];
self.storyHUD = [MBProgressHUD showHUDAddedTo:self.view animated:YES];
self.storyHUD = [MBProgressHUD showHUDAddedTo:self.webView animated:YES];
self.storyHUD.customView = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"37x-Checkmark.png"]];
self.storyHUD.mode = MBProgressHUDModeCustomView;
self.storyHUD.removeFromSuperViewOnHide = YES;
@ -1570,8 +1625,8 @@ shouldStartLoadWithRequest:(NSURLRequest *)request
}
- (void)flashCheckmarkHud:(NSString *)messageType {
[MBProgressHUD hideHUDForView:appDelegate.storyPageControl.view animated:NO];
self.storyHUD = [MBProgressHUD showHUDAddedTo:self.view animated:YES];
[MBProgressHUD hideHUDForView:self.webView animated:NO];
self.storyHUD = [MBProgressHUD showHUDAddedTo:self.webView animated:YES];
self.storyHUD.customView = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"37x-Checkmark.png"]];
self.storyHUD.mode = MBProgressHUDModeCustomView;
self.storyHUD.removeFromSuperViewOnHide = YES;
@ -1596,6 +1651,10 @@ shouldStartLoadWithRequest:(NSURLRequest *)request
self.storyHUD.labelText = @"Unread";
} else if ([messageType isEqualToString:@"added"]) {
self.storyHUD.labelText = @"Added";
} else if ([messageType isEqualToString:@"copied"]) {
self.storyHUD.labelText = @"Copied";
} else if ([messageType isEqualToString:@"saved"]) {
self.storyHUD.labelText = @"Saved";
}
[self.storyHUD hide:YES afterDelay:1];
}

6
clients/ios/Classes/StoryPageControl.m
View file

@ -916,8 +916,8 @@
}
- (IBAction)tapProgressBar:(id)sender {
[MBProgressHUD hideHUDForView:self.view animated:NO];
MBProgressHUD *hud = [MBProgressHUD showHUDAddedTo:self.view animated:YES];
[MBProgressHUD hideHUDForView:currentPage.webView animated:NO];
MBProgressHUD *hud = [MBProgressHUD showHUDAddedTo:currentPage.webView animated:YES];
hud.mode = MBProgressHUDModeText;
hud.removeFromSuperViewOnHide = YES;
NSInteger unreadCount = appDelegate.unreadCount;
@ -992,7 +992,7 @@
- (void)showShareHUD:(NSString *)msg {
// [MBProgressHUD hideHUDForView:self.view animated:NO];
self.storyHUD = [MBProgressHUD showHUDAddedTo:self.view animated:YES];
self.storyHUD = [MBProgressHUD showHUDAddedTo:currentPage.webView animated:YES];
self.storyHUD.labelText = msg;
self.storyHUD.margin = 20.0f;
self.currentPage.noStoryMessage.hidden = YES;

2
clients/ios/NewsBlur_Prefix.pch
View file

@ -5,7 +5,7 @@
#import <SystemConfiguration/SystemConfiguration.h>
#import <MobileCoreServices/MobileCoreServices.h>
//#define DEBUG 1
#define DEBUG 1
//#define PROD_DEBUG 1
#ifdef DEBUG

2
clients/ios/static/storyDetailView.css
View file

@ -453,6 +453,8 @@ div + p {
width: auto;
max-width: 100% !important;
display: none;
-webkit-touch-callout: none;
-webkit-user-select: none; /* Disable selection/copy in UIWebView */
}
.NB-story img.NB-large-image,