Cleaning up static analyzer warnings.

clients/ios/ASI/ASIAuthenticationDialog.m

@@ -219,8 +219,8 @@ static const NSUInteger kDomainSection = 1;
 	[[sharedDialog parentViewController] dismissViewControllerAnimated:YES completion:nil];
 }
 
-- (void)viewDidDisappear:(BOOL)animated
-{
+- (void)viewDidDisappear:(BOOL)animated {
+    [super viewDidDisappear:animated];
 	[self retain];
 	[sharedDialog release];
 	sharedDialog = nil;

clients/ios/Classes/AuthorizeServicesViewController.m

@@ -44,6 +44,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     if ([type isEqualToString:@"google"]) {
         self.navigationItem.title = @"Google Reader";
     } else if ([type isEqualToString:@"facebook"]) {

clients/ios/Classes/DashboardViewController.m

@@ -83,7 +83,7 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
-
+    [super viewWillAppear:animated];
 }
 
 - (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation {

clients/ios/Classes/FeedDetailMenuViewController.m

@@ -50,6 +50,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     [self.menuTableView reloadData];
     
     [orderSegmentedControl

clients/ios/Classes/FeedDetailViewController.m

@@ -212,6 +212,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     self.appDelegate = (NewsBlurAppDelegate *)[[UIApplication sharedApplication] delegate];
 
     UIInterfaceOrientation orientation = [UIApplication sharedApplication].statusBarOrientation;
@@ -320,6 +322,8 @@
 }
 
 - (void)viewDidDisappear:(BOOL)animated {
+    [super viewDidDisappear:animated];
+    
     [self.popoverController dismissPopoverAnimated:YES];
     self.popoverController = nil;
     UIInterfaceOrientation orientation = [UIApplication sharedApplication].statusBarOrientation;

clients/ios/Classes/FeedsMenuViewController.m

@@ -64,6 +64,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     [self.menuTableView reloadData];
 }
 

clients/ios/Classes/FirstTimeUserAddFriendsViewController.m

@@ -58,6 +58,7 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
 //    [self selectTwitterButton];
     [self.navigationItem.rightBarButtonItem setStyle:UIBarButtonItemStyleDone];
 }

clients/ios/Classes/FirstTimeUserAddNewsBlurViewController.m

@@ -46,10 +46,14 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     [self.navigationItem.rightBarButtonItem setStyle:UIBarButtonItemStyleDone];
 }
 
 - (void)viewDidAppear:(BOOL)animated {
+    [super viewDidAppear:animated];
+    
     [self addSite:@"http://blog.newsblur.com/rss"];
     [self addPopular];
 }

clients/ios/Classes/FirstTimeUserAddSitesViewController.m

@@ -81,6 +81,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     [self.navigationItem.rightBarButtonItem setStyle:UIBarButtonItemStyleDone];
     [self.categoriesTable reloadData];
     [self.scrollView setContentSize:CGSizeMake(self.view.frame.size.width, self.tableViewHeight + 100)];

clients/ios/Classes/FirstTimeUserViewController.m

@@ -79,6 +79,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     [self.navigationItem.rightBarButtonItem setStyle:UIBarButtonItemStyleDone];
     
     UIImage *logoImg = [UIImage imageNamed:@"logo_512"];
@@ -95,10 +97,12 @@
 }
 
 - (void)viewDidAppear:(BOOL)animated {
-    
+    [super viewDidAppear:animated];
 }
 
 - (void)viewDidDisappear:(BOOL)animated {
+    [super viewDidDisappear:animated];
+    
     self.logo = nil;
 }
 

clients/ios/Classes/FontSettingsViewController.m

@@ -42,6 +42,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     self.appDelegate = [NewsBlurAppDelegate sharedAppDelegate];
     
     NSUserDefaults *userPreferences = [NSUserDefaults standardUserDefaults];

clients/ios/Classes/FriendsListViewController.m

@@ -69,6 +69,7 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
     [self.friendSearchBar becomeFirstResponder];
 }
 

clients/ios/Classes/NBContainerViewController.m

@@ -175,6 +175,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     [self layoutDashboardScreen];
 }
 

clients/ios/Classes/NewsBlurAppDelegate.m

@@ -212,6 +212,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     self.title = @"All";
 }
 

clients/ios/Classes/NewsBlurViewController.m

@@ -317,12 +317,6 @@ static UIFont *userLabelFont;
     [self.feedTitlesTable reloadData];
 }
 
-- (void)viewDidUnload {
-    [self setToolbarLeftMargin:nil];
-    [self setNoFocusMessage:nil];
-    [self setInnerView:nil];
-}
-
 - (void)layoutForInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation {
     CGSize toolbarSize = [self.feedViewToolbar sizeThatFits:self.view.frame.size];
     if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad) {

clients/ios/Classes/OriginalStoryViewController.m

@@ -62,6 +62,7 @@
 
 - (void)viewDidLoad {    
 //    self.navigationItem.title = [[appDelegate activeStory] objectForKey:@"story_title"];
+    [super viewDidLoad];
     
     self.view.layer.masksToBounds = NO;
     self.view.layer.shadowRadius = 5;

clients/ios/Classes/ShareViewController.m

@@ -105,6 +105,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     [self adjustCommentField];
     [self adjustShareButtons];
     

clients/ios/Classes/StoryDetailViewController.m

@@ -166,6 +166,7 @@
 }
 
 - (void)viewDidDisappear:(BOOL)animated {
+    [super viewDidDisappear:animated];
 }
 
 - (void)willRotateToInterfaceOrientation:(UIInterfaceOrientation)toInterfaceOrientation duration:(NSTimeInterval)duration {

clients/ios/Classes/StoryPageControl.m

@@ -65,6 +65,8 @@
 }
 
 - (void)viewDidLoad {
+    [super viewDidLoad];
+    
 	currentPage = [[StoryDetailViewController alloc]
                    initWithNibName:@"StoryDetailViewController"
                    bundle:nil];
@@ -183,6 +185,8 @@
 }
 
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     [self setNextPreviousButtons];
     [appDelegate adjustStoryDetailWebView];
     [self setTextButton];
@@ -258,6 +262,8 @@
 }
 
 - (void)viewDidAppear:(BOOL)animated {
+    [super viewDidAppear:animated];
+    
     // set the subscribeButton flag
     if (appDelegate.isTryFeedView && UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad) {
         self.subscribeButton.title = [NSString stringWithFormat:@"Follow %@",
@@ -272,10 +278,14 @@
 }
 
 - (void)viewDidDisappear:(BOOL)animated {
+    [super viewDidDisappear:animated];
+    
     self.navigationItem.leftBarButtonItem = nil;
 }
 
 - (void)viewWillDisappear:(BOOL)animated {
+    [super viewWillDisappear:animated];
+    
     previousPage.view.hidden = YES;
     self.navigationController.interactivePopGestureRecognizer.enabled = YES;
 }

clients/ios/Classes/TrainerViewController.m

@@ -60,6 +60,8 @@
     }
 }
 - (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
     [[UIMenuController sharedMenuController]
      setMenuItems:[NSArray arrayWithObjects:
                    [[UIMenuItem alloc] initWithTitle:@"👎 Hide" action:@selector(hideTitle:)],
@@ -141,9 +143,6 @@
     [self.webView stringByEvaluatingJavaScriptFromString:@"attachFastClick({skipEvent: true});"];
 }
 
-- (void)viewDidAppear:(BOOL)animated {
-}
-
 - (void)viewDidDisappear:(BOOL)animated {
     [super viewDidDisappear:animated];
     

clients/ios/NewsBlur_Prefix.pch

@@ -5,7 +5,7 @@
     #import <SystemConfiguration/SystemConfiguration.h>
     #import <MobileCoreServices/MobileCoreServices.h>
 
-#define DEBUG 1
+//#define DEBUG 1
 //#define PROD_DEBUG 1
 
 #ifdef DEBUG

clients/ios/Other Sources/InAppSettingsKit/Controllers/IASKAppSettingsWebViewController.m

@@ -45,7 +45,9 @@
     self.view = self.webView;
 }
 
-- (void)viewWillAppear:(BOOL)animated {  
+- (void)viewWillAppear:(BOOL)animated {
+    [super viewWillAppear:animated];
+    
 	UIActivityIndicatorView *activityIndicatorView = [[UIActivityIndicatorView alloc] initWithFrame:CGRectMake(0, 0, 40, 20)];
 	activityIndicatorView.activityIndicatorViewStyle = UIActivityIndicatorViewStyleWhite;
 	[activityIndicatorView startAnimating];

clients/ios/Other Sources/InAppSettingsKit/Controllers/IASKSpecifierValuesViewController.m

@@ -105,6 +105,8 @@
 }
 
 - (void)viewDidUnload {
+    [super viewDidUnload];
+    
 	// Release any retained subviews of the main view.
 	// e.g. self.myOutlet = nil;
 	self.tableView = nil;

clients/ios/Other Sources/InAppSettingsKit/Models/IASKSettingsReader.m

@@ -191,6 +191,7 @@
     switch (interfaceIdiom) {
         case UIUserInterfaceIdiomPad: return @"~ipad";
         case UIUserInterfaceIdiomPhone: return @"~iphone";
+        default: return @"~iphone";
     }
 }
 

clients/ios/Other Sources/Overshare Kit/OSKTwitterUtility.m

@@ -167,14 +167,9 @@ NSString * const OSKTwitterImageSizeLimitKey = @"photo_size_limit";
             }
             else
             {
-                NSString *responseString = nil;
-                if (responseData) {
-                    responseString = [[NSString alloc] initWithData:responseData encoding:NSUTF8StringEncoding];
-                }
-                
                 OSKLog(@"[OSKTwitterUtility] Error received when trying to create a new tweet. Server responded with status code %li and response: %@",
                        (long)statusCode,
-                       responseString);
+                       [[NSString alloc] initWithData:responseData encoding:NSUTF8StringEncoding]);
                 
                 NSError *error = [NSError errorWithDomain:@"com.secondgear.PhotosPlus.Errors" code:statusCode userInfo:nil];
                 dispatch_async(dispatch_get_main_queue(), ^{

clients/ios/Other Sources/Overshare Kit/OSKUITextViewSubstitute.m

@@ -232,6 +232,8 @@
 }
 
 - (BOOL)resignFirstResponder {
+    [super resignFirstResponder];
+    
     return [self.textView resignFirstResponder];
 }