Neutral slider has been broken for a week due to JavaScript thinking 0 was false.

This commit is contained in:
Samuel Clay 2010-07-21 00:47:55 -04:00
parent ebdc80f526
commit 7afdd3344b

View file

@ -1965,7 +1965,10 @@
self.switch_feed_view_unread_view(ui.value); self.switch_feed_view_unread_view(ui.value);
}, },
stop: function(e, ui) { stop: function(e, ui) {
self.model.preference('unread_view', ui.value); self.switch_feed_view_unread_view(ui.value);
if (self.model.preference('unread_view') != ui.value) {
self.model.preference('unread_view', ui.value);
}
self.flags['feed_view_positions_calculated'] = false; self.flags['feed_view_positions_calculated'] = false;
self.show_correct_story_titles_in_unread_view({'animate': true, 'follow': true}); self.show_correct_story_titles_in_unread_view({'animate': true, 'follow': true});
} }
@ -1976,11 +1979,7 @@
var $feed_list = this.$s.$feed_list; var $feed_list = this.$s.$feed_list;
var unread_view_name = this.get_unread_view_name(unread_view); var unread_view_name = this.get_unread_view_name(unread_view);
var $next_story_button = $('.task_story_next_unread'); var $next_story_button = $('.task_story_next_unread');
if (this.model.preference('unread_view') != unread_view) {
this.model.preference('unread_view', unread_view);
}
$feed_list.removeClass('unread_view_positive') $feed_list.removeClass('unread_view_positive')
.removeClass('unread_view_neutral') .removeClass('unread_view_neutral')
.removeClass('unread_view_negative') .removeClass('unread_view_negative')
@ -1993,7 +1992,9 @@
}, },
get_unread_view_name: function(unread_view) { get_unread_view_name: function(unread_view) {
unread_view = unread_view || this.model.preference('unread_view'); if (typeof unread_view == 'undefined') {
unread_view = this.model.preference('unread_view');
}
return (unread_view > 0 return (unread_view > 0
? 'positive' ? 'positive'