From 7afdd3344b6793e20c69a36662b2c901b3becee9 Mon Sep 17 00:00:00 2001 From: Samuel Clay Date: Wed, 21 Jul 2010 00:47:55 -0400 Subject: [PATCH] Neutral slider has been broken for a week due to JavaScript thinking 0 was false. --- media/js/newsblur/reader.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/media/js/newsblur/reader.js b/media/js/newsblur/reader.js index 70fee2b62..716b6803f 100644 --- a/media/js/newsblur/reader.js +++ b/media/js/newsblur/reader.js @@ -1965,7 +1965,10 @@ self.switch_feed_view_unread_view(ui.value); }, stop: function(e, ui) { - self.model.preference('unread_view', ui.value); + self.switch_feed_view_unread_view(ui.value); + if (self.model.preference('unread_view') != ui.value) { + self.model.preference('unread_view', ui.value); + } self.flags['feed_view_positions_calculated'] = false; self.show_correct_story_titles_in_unread_view({'animate': true, 'follow': true}); } @@ -1976,11 +1979,7 @@ var $feed_list = this.$s.$feed_list; var unread_view_name = this.get_unread_view_name(unread_view); var $next_story_button = $('.task_story_next_unread'); - - if (this.model.preference('unread_view') != unread_view) { - this.model.preference('unread_view', unread_view); - } - + $feed_list.removeClass('unread_view_positive') .removeClass('unread_view_neutral') .removeClass('unread_view_negative') @@ -1993,7 +1992,9 @@ }, get_unread_view_name: function(unread_view) { - unread_view = unread_view || this.model.preference('unread_view'); + if (typeof unread_view == 'undefined') { + unread_view = this.model.preference('unread_view'); + } return (unread_view > 0 ? 'positive'