From 2dad7db021e412456c89db94ad5ad77b5bcb7e4e Mon Sep 17 00:00:00 2001 From: Suddenly Date: Tue, 8 Jul 2014 09:44:18 +1000 Subject: [PATCH] Safer JSON Loading diff --git a/src/main/java/net/minecraft/server/players/JsonList.java b/src/main/java/net/minecraft/server/players/JsonList.java index 233303b4a..37679d7f2 100644 --- a/src/main/java/net/minecraft/server/players/JsonList.java +++ b/src/main/java/net/minecraft/server/players/JsonList.java @@ -174,6 +174,14 @@ public abstract class JsonList> { this.map.put(this.a(jsonlistentry.getKey()), (V) jsonlistentry); // CraftBukkit - fix decompile error } } + // Spigot Start + } catch ( com.google.gson.JsonParseException | NullPointerException ex ) + { + org.bukkit.Bukkit.getLogger().log( java.util.logging.Level.WARNING, "Unable to read file " + this.file + ", backing it up to {0}.backup and creating new copy.", ex ); + File backup = new File( this.file + ".backup" ); + this.file.renameTo( backup ); + this.file.delete(); + // Spigot End } catch (Throwable throwable) { if (bufferedreader != null) { try { diff --git a/src/main/java/net/minecraft/server/players/UserCache.java b/src/main/java/net/minecraft/server/players/UserCache.java index b5aa73eac..d9b00b376 100644 --- a/src/main/java/net/minecraft/server/players/UserCache.java +++ b/src/main/java/net/minecraft/server/players/UserCache.java @@ -261,6 +261,11 @@ public class UserCache { } } catch (FileNotFoundException filenotfoundexception) { ; + // Spigot Start + } catch (com.google.gson.JsonSyntaxException | NullPointerException ex) { + JsonList.LOGGER.warn( "Usercache.json is corrupted or has bad formatting. Deleting it to prevent further issues." ); + this.file.delete(); + // Spigot End } catch (JsonParseException | IOException ioexception) { UserCache.LOGGER.warn("Failed to load profile cache {}", this.file, ioexception); } -- 2.25.1