From b65e20b58cd8b0114a0f0243d93c028b9a4e9a83 Mon Sep 17 00:00:00 2001 From: md_5 Date: Fri, 8 Aug 2014 19:57:03 +1000 Subject: [PATCH] Plug WorldMap Memory Leak diff --git a/src/main/java/net/minecraft/server/PersistentCollection.java b/src/main/java/net/minecraft/server/PersistentCollection.java index fe59b758f..936d6c640 100644 --- a/src/main/java/net/minecraft/server/PersistentCollection.java +++ b/src/main/java/net/minecraft/server/PersistentCollection.java @@ -19,7 +19,7 @@ public class PersistentCollection { private final IDataManager b; protected Map a = Maps.newHashMap(); - private final List c = Lists.newArrayList(); + public final List c = Lists.newArrayList(); // Spigot private final Map d = Maps.newHashMap(); public PersistentCollection(IDataManager idatamanager) { diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java index 7013dfc29..0fc9fbd61 100644 --- a/src/main/java/net/minecraft/server/World.java +++ b/src/main/java/net/minecraft/server/World.java @@ -1114,6 +1114,23 @@ public abstract class World implements IBlockAccess { entity.die(); if (entity instanceof EntityHuman) { this.players.remove(entity); + // Spigot start + for ( Object o : worldMaps.c ) + { + if ( o instanceof WorldMap ) + { + WorldMap map = (WorldMap) o; + map.k.remove( entity ); + for ( Iterator iter = (Iterator) map.i.iterator(); iter.hasNext(); ) + { + if ( iter.next().trackee == entity ) + { + iter.remove(); + } + } + } + } + // Spigot end this.everyoneSleeping(); this.c(entity); } diff --git a/src/main/java/net/minecraft/server/WorldMap.java b/src/main/java/net/minecraft/server/WorldMap.java index 61517f738..140286acb 100644 --- a/src/main/java/net/minecraft/server/WorldMap.java +++ b/src/main/java/net/minecraft/server/WorldMap.java @@ -25,7 +25,7 @@ public class WorldMap extends PersistentBase { public byte scale; public byte[] colors = new byte[16384]; public List i = Lists.newArrayList(); - private final Map k = Maps.newHashMap(); + public final Map k = Maps.newHashMap(); // Spigot private -> public public Map decorations = Maps.newLinkedHashMap(); // CraftBukkit start -- 2.14.1