Commit graph

1427 commits

Author SHA1 Message Date
md_5
b652de8e7f Only close once, if needed 2014-08-10 11:03:19 +10:00
md_5
db78a70788 Force Close Inventory On Move 2014-08-10 11:01:11 +10:00
md_5
a8763d7e57 Plug WorldMap Memory Leak 2014-08-08 19:57:11 +10:00
md_5
da20125dab Upstream merge 2014-08-08 19:04:28 +10:00
Thinkofdeath
883534a72a Fix LEFT_CLICK_AIR detection when not in creative 2014-08-07 15:49:24 +01:00
Kyle Clemens
7efa75c63a Fixed: Check cast
Instead of doing an unsafe cast, actually check if the HumanEntity supplied is a CraftHumanEntity. Plugins adding custom HumanEntities to the viewers of an inventory will end up crashing the server when the Chunk containing the block which contains the inventory unloads, since the original cast is unchecked here.

I'm not sure if there was a reason for casting to CraftHumanEntity, so I kept it, but HumanEntity, as I'm sure you know, has a closeInventory() method you could call instead of getting the CraftBukkit handle. There's probably a reason behind it, though.

I tried to follow the formatting conventions, but I may have missed something.

Tested the easily reproducible issue using this patch compiled, and it works fine; no crashes in sight.
2014-08-06 17:44:33 +10:00
Thinkofdeath
f5a1e7a96f Fix the particle api using the wrong Material class 2014-08-05 18:17:38 +01:00
Thinkofdeath
7d79f6bf5e Fix timings 2014-08-05 17:29:09 +01:00
Thinkofdeath
7fa28b7fbe Upstream merge 2014-08-04 20:38:00 +01:00
mrapple
2e45f5d2fa Fix missed diff from Minecraft 1.3.1 update 2014-08-01 09:28:27 +01:00
Thinkofdeath
463a1eb595 Filter attribute modifiers which cause the attribute to go out of its range 2014-07-31 17:49:09 +01:00
Thinkofdeath
8d45fe7f77 Merge the max health attribute patch into the previous one 2014-07-31 16:56:43 +01:00
Maxim Van de Wynckel
25b673fd7e Skip online mode UUID lookups when in offline mode and not using Bungee. 2014-07-30 17:08:36 +10:00
Thinkofdeath
6a6eff3319 Handle cases where the api fails to return a profile 2014-07-29 14:58:29 +01:00
Thinkofdeath
3452c620df Add an option for a global cache for any request on Mojang's api to handle plugins that don't use UserCache (or any cache) 2014-07-29 10:13:19 +01:00
Thinkofdeath
d3b9fa0d1f Set the minimum max health attribute value to 0.1 2014-07-28 23:16:22 +01:00
md_5
2bf4481e15 Update attribute maxes again once loaded 2014-07-28 17:29:45 +10:00
md_5
1e98f1161f Fix unit tests 2014-07-28 17:03:52 +10:00
md_5
fb3a9d38dd Allow Attribute Capping.
Apply some sensible defaults and allow server owners to customize the maximum values of selected common attributes.
2014-07-28 16:56:04 +10:00
md_5
408944e9f5 Apply NBTReadLimiter to more things. 2014-07-27 21:16:47 +10:00
md_5
5abb82b1ca Don't be so spammy on Java 6 2014-07-27 11:47:18 +10:00
md_5
abb775108d Move hopper patch to top for #180 2014-07-27 09:53:16 +10:00
md_5
e207ea23cd Fix PlayerItemDamageEvent 2014-07-27 09:46:52 +10:00
Minecrell
348eae75f4 Log debug levels to the log file.
Allows plugin to log messages that aren't important when looking at the
console, but can be useful when reporting errors.
2014-07-27 09:43:58 +10:00
Thinkofdeath
273c64bbad Add missing particle to particle API 2014-07-26 21:51:17 +01:00
Thinkofdeath
b5dd202af1 Move getDouble into the Spigot Configuration patch 2014-07-26 18:03:45 +01:00
drXor
33d758773e Fetch complete profile for skull items, similarly to TileEntitySkull.
Caveat: When using skull meta, the user must refresh the inventory,
because that can't be done form the context in which the lookup is done.
2014-07-26 17:53:18 +01:00
drXor
5c32e1cb48 Undeprecate Player#updateInventory()V 2014-07-26 12:24:01 +01:00
Jonas Konrad
99a0a640e8 Make "moved too quickly" limit configurable 2014-07-26 12:22:49 +01:00
Thinkofdeath
7768676ae2 Modify the block placement limit to allow for the odd random packet or two
When the connection between a minecraft client and a server
(e.g. me and the spigot test server) is bad sometimes two placement
packets will arrive at the same time. When the extra one gets canceled
any blocks placed against it get rejected by the server causing the
whole chain to disappear. This fixes this by allowing more packets
to occur whilst making the window wider (since the client seems to be
capped at about one placement every 100ms on a normal connection)
2014-07-24 21:43:06 +01:00
Thinkofdeath
5c48793ecf Don't use Bukkit.getLogger as the CraftServer isn't loaded at this point 2014-07-24 15:27:08 +01:00
riking
67b502b6f8 No need to wait for the conversation to finish 2014-07-23 16:13:13 +10:00
md_5
27f8aa22bd Allow tab complete for /whitelist add, I guess it can *occasionally* make sense to add online players. 2014-07-22 21:14:52 +10:00
md_5
0e1fcfbe70 Only suggest ops to deop and remove whitelist add case entirely.
/whitelist add <onlinePlayer> makes no sense!
2014-07-22 21:12:29 +10:00
md_5
f3b7952c73 Fix slow tab complete for some commands.
Use online players instead of offline players, which is very slow.
2014-07-22 21:01:48 +10:00
Evan A. Haskell
b271cdbfa0 Fix Null Tile Entity Worlds 2014-07-22 18:56:56 +10:00
Jonas Konrad
f7ab380e16 Make "moved wrongly" limit configurable 2014-07-22 18:52:41 +10:00
md_5
f1ba1f6c07 Remove defensive copy in Entity Activation Range
This code was added in 1c84a5dd8c to alleviate some crashes. Since then we have improved our thread safety and detection of unsafe thread behaviour and as such there is no need to incur thhis performance hit anymore.
2014-07-22 18:49:36 +10:00
Thinkofdeath
f0e9304ca2 Move the "Fix player Skulls for 1.7.2 Clients" into the "Old / New Version Support." patch 2014-07-20 20:15:38 +01:00
Thinkofdeath
7dd02f30e4 Move fillProfileProperties to within the cache loader to prevent a possible race condition 2014-07-20 20:10:57 +01:00
Thinkofdeath
2ff238b9d4 Upstream merge 2014-07-20 00:27:03 +01:00
Thinkofdeath
482e9c9775 Fix IP banning 2014-07-19 22:14:07 +01:00
Thinkofdeath
17d4f25f4e Replace the temporary fix 2014-07-19 20:26:42 +01:00
Thinkofdeath
3a17625874 Prevent a crash involving attributes 2014-07-19 20:01:10 +01:00
Thinkofdeath
7a8460abb7 Filter item's nbt on send to prevent client crashes 2014-07-19 19:11:42 +01:00
Thinkofdeath
c9b6a59bbd Don't spawn bonus ocelots when plugins spawn ocelots 2014-07-19 12:51:34 +01:00
Aikar
cb25b2262d Use New Bukkit areNeighborsLoaded for checkIfActive 2014-07-19 15:46:27 +10:00
drXor
068075806e Fix enchanting tables wiping meta when stacked items are placed in them 2014-07-19 15:42:49 +10:00
Thinkofdeath
2ca12642bb Cache skull skin blobs instead of looking them up each time 2014-07-16 20:42:25 +01:00
Thinkofdeath
00122792ce Rework the block place limit to be based on the packet's arrival time instead of the server's current tick.
This should help with low tps servers/high latency connections
2014-07-16 10:30:28 +01:00