spigot/CraftBukkit-Patches/0038-Catch-stalling-on-corrupted-map-data-NBT-arrays.patch

34 lines
1.7 KiB
Diff
Raw Normal View History

2023-09-22 02:40:00 +10:00
From 1f8e29b139a9abee264376bc3ac349e50e9775ee Mon Sep 17 00:00:00 2001
2019-12-11 09:00:00 +11:00
From: md_5 <git@md-5.net>
Date: Mon, 20 Jan 2014 13:44:07 +1100
Subject: [PATCH] Catch stalling on corrupted map data / NBT arrays.
2021-03-16 09:00:00 +11:00
diff --git a/src/main/java/net/minecraft/nbt/NBTTagByteArray.java b/src/main/java/net/minecraft/nbt/NBTTagByteArray.java
2023-09-22 02:40:00 +10:00
index 64933f0576..16b3d48bc2 100644
2021-03-16 09:00:00 +11:00
--- a/src/main/java/net/minecraft/nbt/NBTTagByteArray.java
+++ b/src/main/java/net/minecraft/nbt/NBTTagByteArray.java
2023-09-22 02:40:00 +10:00
@@ -25,6 +25,7 @@ public class NBTTagByteArray extends NBTList<NBTTagByte> {
private static byte[] readAccounted(DataInput datainput, NBTReadLimiter nbtreadlimiter) throws IOException {
2022-12-08 03:00:00 +11:00
nbtreadlimiter.accountBytes(24L);
2023-09-22 02:40:00 +10:00
int i = datainput.readInt();
+ com.google.common.base.Preconditions.checkArgument( i < 1 << 24); // Spigot
2019-12-11 09:00:00 +11:00
2023-09-22 02:40:00 +10:00
nbtreadlimiter.accountBytes(1L, (long) i);
byte[] abyte = new byte[i];
2021-03-16 09:00:00 +11:00
diff --git a/src/main/java/net/minecraft/nbt/NBTTagIntArray.java b/src/main/java/net/minecraft/nbt/NBTTagIntArray.java
2023-09-22 02:40:00 +10:00
index 7e4c021ca7..96d4721c66 100644
2021-03-16 09:00:00 +11:00
--- a/src/main/java/net/minecraft/nbt/NBTTagIntArray.java
+++ b/src/main/java/net/minecraft/nbt/NBTTagIntArray.java
2023-09-22 02:40:00 +10:00
@@ -25,6 +25,7 @@ public class NBTTagIntArray extends NBTList<NBTTagInt> {
private static int[] readAccounted(DataInput datainput, NBTReadLimiter nbtreadlimiter) throws IOException {
2022-12-08 03:00:00 +11:00
nbtreadlimiter.accountBytes(24L);
2023-09-22 02:40:00 +10:00
int i = datainput.readInt();
+ com.google.common.base.Preconditions.checkArgument( i < 1 << 24); // Spigot
2019-12-11 09:00:00 +11:00
2023-09-22 02:40:00 +10:00
nbtreadlimiter.accountBytes(4L, (long) i);
int[] aint = new int[i];
2019-12-11 09:00:00 +11:00
--
2023-09-22 02:40:00 +10:00
2.42.0
2019-12-11 09:00:00 +11:00