spigot-mirror/bukkit
1
0
Fork 0
mirror of https://hub.spigotmc.org/stash/scm/spigot/bukkit.git synced 2025-08-31 22:22:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

#686: Fix contains for default section generating real sections

Browse source
This commit is contained in:
Wolf2323 2021-12-04 22:05:54 +01:00 • committed by md_5
parent 0912ace4df
commit e4358b8217
No known key found for this signature in database
GPG key ID: E8E901AC7C617C11
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/main/java/org/bukkit/configuration/MemorySection.java
View file

@ -251,10 +251,10 @@ public class MemorySection implements ConfigurationSection {
int i1 = -1, i2;
ConfigurationSection section = this;
while ((i1 = path.indexOf(separator, i2 = i1 + 1)) != -1) {
section = section.getConfigurationSection(path.substring(i2, i1));
if (section == null) {
if (section == null || !section.contains(path.substring(i2, i1), true)) {
return def;
}
section = section.getConfigurationSection(path.substring(i2, i1));
}
String key = path.substring(i2);

10
src/test/java/org/bukkit/configuration/ConfigurationSectionTest.java
View file

@ -110,6 +110,16 @@ public abstract class ConfigurationSectionTest {
assertTrue(section.contains("doenst-exist-two", false));
}
@Test
public void testContainsDoesNotCreateSection() {
ConfigurationSection section = getConfigurationSection();
section.addDefault("notExistingSection.Value", "Test String");
assertFalse(section.contains("notExistingSection", true));
assertFalse(section.contains("notExistingSection.Value", true));
assertFalse(section.contains("notExistingSection", true));
}
@Test
public void testIsSet() {
ConfigurationSection section = getConfigurationSection();