mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 08:43:31 +00:00
fffcad87d4
GPS rfkill support via pre-2009 WMI interface uses hp_wmi_get_sw_state() and hp_wmi_get_hw_state() to query its current hard and soft block state, respectively. In hp_wmi_get_sw_state() a mask is calculated which bit should be checked in an int value returned by firmware to get current block state: 0x200 << (r * 8) which with r being 3 for GPS results in overflow and mask of zero. The same goes for hp_wmi_get_hw_state(). This effectively means that GPS rfkill on this WMI interface is considered always both hard and soft blocked. Unfortunately, later when rfkill subsystem calls hp_wmi_set_block() to sync this block to hardware firmware at least on my old nc6400 gets confused and sets both hard and soft blocks on WiFi and BT. This happens for example on hp-wmi module load. Since due to overflow described above it is dubious that this ever worked correctly and HP laptops with modems having GPS support seem to all have been released well past year 2009 let's just remove GPS rfkill support via pre-2009 WMI interface. Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
||
|---|---|---|
| .. | ||
| acer-wmi.c | ||
| acerhdf.c | ||
| alienware-wmi.c | ||
| amilo-rfkill.c | ||
| apple-gmux.c | ||
| asus-laptop.c | ||
| asus-nb-wmi.c | ||
| asus-wireless.c | ||
| asus-wmi.c | ||
| asus-wmi.h | ||
| classmate-laptop.c | ||
| compal-laptop.c | ||
| dell-laptop.c | ||
| dell-rbtn.c | ||
| dell-rbtn.h | ||
| dell-smbios.c | ||
| dell-smbios.h | ||
| dell-smo8800.c | ||
| dell-wmi-aio.c | ||
| dell-wmi.c | ||
| eeepc-laptop.c | ||
| eeepc-wmi.c | ||
| fujitsu-laptop.c | ||
| fujitsu-tablet.c | ||
| hdaps.c | ||
| hp-wireless.c | ||
| hp-wmi.c | ||
| hp_accel.c | ||
| ibm_rtl.c | ||
| ideapad-laptop.c | ||
| intel-hid.c | ||
| intel-rst.c | ||
| intel-smartconnect.c | ||
| intel_ips.c | ||
| intel_ips.h | ||
| intel_menlow.c | ||
| intel_mid_powerbtn.c | ||
| intel_mid_thermal.c | ||
| intel_oaktrail.c | ||
| intel_pmc_ipc.c | ||
| intel_pmic_gpio.c | ||
| intel_punit_ipc.c | ||
| intel_scu_ipc.c | ||
| intel_scu_ipcutil.c | ||
| intel_telemetry_core.c | ||
| intel_telemetry_debugfs.c | ||
| intel_telemetry_pltdrv.c | ||
| Kconfig | ||
| Makefile | ||
| msi-laptop.c | ||
| msi-wmi.c | ||
| mxm-wmi.c | ||
| panasonic-laptop.c | ||
| pvpanic.c | ||
| samsung-laptop.c | ||
| samsung-q10.c | ||
| sony-laptop.c | ||
| surfacepro3_button.c | ||
| tc1100-wmi.c | ||
| thinkpad_acpi.c | ||
| topstar-laptop.c | ||
| toshiba-wmi.c | ||
| toshiba_acpi.c | ||
| toshiba_bluetooth.c | ||
| toshiba_haps.c | ||
| wmi.c | ||
| xo1-rfkill.c | ||
| xo15-ebook.c | ||