mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00

Constify the following API: struct device *device_find_child(struct device *dev, void *data, int (*match)(struct device *dev, void *data)); To : struct device *device_find_child(struct device *dev, const void *data, device_match_t match); typedef int (*device_match_t)(struct device *dev, const void *data); with the following reasons: - Protect caller's match data @*data which is for comparison and lookup and the API does not actually need to modify @*data. - Make the API's parameters (@match)() and @data have the same type as all of other device finding APIs (bus|class|driver)_find_device(). - All kinds of existing device match functions can be directly taken as the API's argument, they were exported by driver core. Constify the API and adapt for various existing usages. BTW, various subsystem changes are squashed into this commit to meet 'git bisect' requirement, and this commit has the minimal and simplest changes to complement squashing shortcoming, and that may bring extra code improvement. Reviewed-by: Alison Schofield <alison.schofield@intel.com> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Acked-by: Uwe Kleine-König <ukleinek@kernel.org> # for drivers/pwm Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Link: https://lore.kernel.org/r/20241224-const_dfc_done-v5-4-6623037414d4@quicinc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
181 lines
5.3 KiB
C
181 lines
5.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* dev-path-parser.c - EFI Device Path parser
|
|
* Copyright (C) 2016 Lukas Wunner <lukas@wunner.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License (version 2) as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/efi.h>
|
|
#include <linux/pci.h>
|
|
|
|
static long __init parse_acpi_path(const struct efi_dev_path *node,
|
|
struct device *parent, struct device **child)
|
|
{
|
|
struct acpi_device *adev;
|
|
struct device *phys_dev;
|
|
char hid[ACPI_ID_LEN];
|
|
|
|
if (node->header.length != 12)
|
|
return -EINVAL;
|
|
|
|
sprintf(hid, "%c%c%c%04X",
|
|
'A' + ((node->acpi.hid >> 10) & 0x1f) - 1,
|
|
'A' + ((node->acpi.hid >> 5) & 0x1f) - 1,
|
|
'A' + ((node->acpi.hid >> 0) & 0x1f) - 1,
|
|
node->acpi.hid >> 16);
|
|
|
|
for_each_acpi_dev_match(adev, hid, NULL, -1) {
|
|
if (acpi_dev_uid_match(adev, node->acpi.uid))
|
|
break;
|
|
if (!acpi_device_uid(adev) && node->acpi.uid == 0)
|
|
break;
|
|
}
|
|
if (!adev)
|
|
return -ENODEV;
|
|
|
|
phys_dev = acpi_get_first_physical_node(adev);
|
|
if (phys_dev) {
|
|
*child = get_device(phys_dev);
|
|
acpi_dev_put(adev);
|
|
} else
|
|
*child = &adev->dev;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int __init match_pci_dev(struct device *dev, const void *data)
|
|
{
|
|
unsigned int devfn = *(const unsigned int *)data;
|
|
|
|
return dev_is_pci(dev) && to_pci_dev(dev)->devfn == devfn;
|
|
}
|
|
|
|
static long __init parse_pci_path(const struct efi_dev_path *node,
|
|
struct device *parent, struct device **child)
|
|
{
|
|
unsigned int devfn;
|
|
|
|
if (node->header.length != 6)
|
|
return -EINVAL;
|
|
if (!parent)
|
|
return -EINVAL;
|
|
|
|
devfn = PCI_DEVFN(node->pci.dev, node->pci.fn);
|
|
|
|
*child = device_find_child(parent, &devfn, match_pci_dev);
|
|
if (!*child)
|
|
return -ENODEV;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Insert parsers for further node types here.
|
|
*
|
|
* Each parser takes a pointer to the @node and to the @parent (will be NULL
|
|
* for the first device path node). If a device corresponding to @node was
|
|
* found below @parent, its reference count should be incremented and the
|
|
* device returned in @child.
|
|
*
|
|
* The return value should be 0 on success or a negative int on failure.
|
|
* The special return values 0x01 (EFI_DEV_END_INSTANCE) and 0xFF
|
|
* (EFI_DEV_END_ENTIRE) signal the end of the device path, only
|
|
* parse_end_path() is supposed to return this.
|
|
*
|
|
* Be sure to validate the node length and contents before commencing the
|
|
* search for a device.
|
|
*/
|
|
|
|
static long __init parse_end_path(const struct efi_dev_path *node,
|
|
struct device *parent, struct device **child)
|
|
{
|
|
if (node->header.length != 4)
|
|
return -EINVAL;
|
|
if (node->header.sub_type != EFI_DEV_END_INSTANCE &&
|
|
node->header.sub_type != EFI_DEV_END_ENTIRE)
|
|
return -EINVAL;
|
|
if (!parent)
|
|
return -ENODEV;
|
|
|
|
*child = get_device(parent);
|
|
return node->header.sub_type;
|
|
}
|
|
|
|
/**
|
|
* efi_get_device_by_path - find device by EFI Device Path
|
|
* @node: EFI Device Path
|
|
* @len: maximum length of EFI Device Path in bytes
|
|
*
|
|
* Parse a series of EFI Device Path nodes at @node and find the corresponding
|
|
* device. If the device was found, its reference count is incremented and a
|
|
* pointer to it is returned. The caller needs to drop the reference with
|
|
* put_device() after use. The @node pointer is updated to point to the
|
|
* location immediately after the "End of Hardware Device Path" node.
|
|
*
|
|
* If another Device Path instance follows, @len is decremented by the number
|
|
* of bytes consumed. Otherwise @len is set to %0.
|
|
*
|
|
* If a Device Path node is malformed or its corresponding device is not found,
|
|
* @node is updated to point to this offending node and an ERR_PTR is returned.
|
|
*
|
|
* If @len is initially %0, the function returns %NULL. Thus, to iterate over
|
|
* all instances in a path, the following idiom may be used:
|
|
*
|
|
* while (!IS_ERR_OR_NULL(dev = efi_get_device_by_path(&node, &len))) {
|
|
* // do something with dev
|
|
* put_device(dev);
|
|
* }
|
|
* if (IS_ERR(dev))
|
|
* // report error
|
|
*
|
|
* Devices can only be found if they're already instantiated. Most buses
|
|
* instantiate devices in the "subsys" initcall level, hence the earliest
|
|
* initcall level in which this function should be called is "fs".
|
|
*
|
|
* Returns the device on success or
|
|
* %ERR_PTR(-ENODEV) if no device was found,
|
|
* %ERR_PTR(-EINVAL) if a node is malformed or exceeds @len,
|
|
* %ERR_PTR(-ENOTSUPP) if support for a node type is not yet implemented.
|
|
*/
|
|
struct device * __init efi_get_device_by_path(const struct efi_dev_path **node,
|
|
size_t *len)
|
|
{
|
|
struct device *parent = NULL, *child;
|
|
long ret = 0;
|
|
|
|
if (!*len)
|
|
return NULL;
|
|
|
|
while (!ret) {
|
|
if (*len < 4 || *len < (*node)->header.length)
|
|
ret = -EINVAL;
|
|
else if ((*node)->header.type == EFI_DEV_ACPI &&
|
|
(*node)->header.sub_type == EFI_DEV_BASIC_ACPI)
|
|
ret = parse_acpi_path(*node, parent, &child);
|
|
else if ((*node)->header.type == EFI_DEV_HW &&
|
|
(*node)->header.sub_type == EFI_DEV_PCI)
|
|
ret = parse_pci_path(*node, parent, &child);
|
|
else if (((*node)->header.type == EFI_DEV_END_PATH ||
|
|
(*node)->header.type == EFI_DEV_END_PATH2))
|
|
ret = parse_end_path(*node, parent, &child);
|
|
else
|
|
ret = -ENOTSUPP;
|
|
|
|
put_device(parent);
|
|
if (ret < 0)
|
|
return ERR_PTR(ret);
|
|
|
|
parent = child;
|
|
*node = (void *)*node + (*node)->header.length;
|
|
*len -= (*node)->header.length;
|
|
}
|
|
|
|
if (ret == EFI_DEV_END_ENTIRE)
|
|
*len = 0;
|
|
|
|
return child;
|
|
}
|