mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
e689a87696
The rules to link selftests are:
> $(OUTPUT)/%_ipv4: %.c
> $(LINK.c) $^ $(LDLIBS) -o $@
>
> $(OUTPUT)/%_ipv6: %.c
> $(LINK.c) -DIPV6_TEST $^ $(LDLIBS) -o $@
The intel test robot uses only selftest's Makefile, not the top linux
Makefile:
> make W=1 O=/tmp/kselftest -C tools/testing/selftests
So, $(LINK.c) is determined by environment, rather than by kernel
Makefiles. On my machine (as well as other people that ran tcp-ao
selftests) GNU/Make implicit definition does use $(LDFLAGS):
> [dima@Mindolluin ~]$ make -p -f/dev/null | grep '^LINK.c\>'
> make: *** No targets. Stop.
> LINK.c = $(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $(TARGET_ARCH)
But, according to build robot report, it's not the case for them.
While I could just avoid using pre-defined $(LINK.c), it's also used by
selftests/lib.mk by default.
Anyways, according to GNU/Make documentation [1], I should have used
$(LDLIBS) instead of $(LDFLAGS) in the first place, so let's just do it:
> LDFLAGS
> Extra flags to give to compilers when they are supposed to invoke
> the linker, ‘ld’, such as -L. Libraries (-lfoo) should be added
> to the LDLIBS variable instead.
> LDLIBS
> Library flags or names given to compilers when they are supposed
> to invoke the linker, ‘ld’. LOADLIBES is a deprecated (but still
> supported) alternative to LDLIBS. Non-library linker flags, such
> as -L, should go in the LDFLAGS variable.
[1]: https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html
Fixes: cfbab37b3d ("selftests/net: Add TCP-AO library")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401011151.veyYTJzq-lkp@intel.com/
Signed-off-by: Dmitry Safonov <dima@arista.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Link: https://lore.kernel.org/r/20240110-tcp_ao-selftests-makefile-v1-1-aa07d043f052@arista.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
56 lines
1.4 KiB
Makefile
56 lines
1.4 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
TEST_BOTH_AF := bench-lookups
|
|
TEST_BOTH_AF += connect
|
|
TEST_BOTH_AF += connect-deny
|
|
TEST_BOTH_AF += icmps-accept icmps-discard
|
|
TEST_BOTH_AF += key-management
|
|
TEST_BOTH_AF += restore
|
|
TEST_BOTH_AF += rst
|
|
TEST_BOTH_AF += self-connect
|
|
TEST_BOTH_AF += seq-ext
|
|
TEST_BOTH_AF += setsockopt-closed
|
|
TEST_BOTH_AF += unsigned-md5
|
|
|
|
TEST_IPV4_PROGS := $(TEST_BOTH_AF:%=%_ipv4)
|
|
TEST_IPV6_PROGS := $(TEST_BOTH_AF:%=%_ipv6)
|
|
|
|
TEST_GEN_PROGS := $(TEST_IPV4_PROGS) $(TEST_IPV6_PROGS)
|
|
|
|
top_srcdir := ../../../../..
|
|
include ../../lib.mk
|
|
|
|
HOSTAR ?= ar
|
|
|
|
LIBDIR := $(OUTPUT)/lib
|
|
LIB := $(LIBDIR)/libaotst.a
|
|
LDLIBS += $(LIB) -pthread
|
|
LIBDEPS := lib/aolib.h Makefile
|
|
|
|
CFLAGS := -Wall -O2 -g -D_GNU_SOURCE -fno-strict-aliasing
|
|
CFLAGS += $(KHDR_INCLUDES)
|
|
CFLAGS += -iquote ./lib/ -I ../../../../include/
|
|
|
|
# Library
|
|
LIBSRC := kconfig.c netlink.c proc.c repair.c setup.c sock.c utils.c
|
|
LIBOBJ := $(LIBSRC:%.c=$(LIBDIR)/%.o)
|
|
EXTRA_CLEAN += $(LIBOBJ) $(LIB)
|
|
|
|
$(LIB): $(LIBOBJ)
|
|
$(HOSTAR) rcs $@ $^
|
|
|
|
$(LIBDIR)/%.o: ./lib/%.c $(LIBDEPS)
|
|
mkdir -p $(LIBDIR)
|
|
$(CC) $< $(CFLAGS) $(CPPFLAGS) -o $@ -c
|
|
|
|
$(TEST_GEN_PROGS): $(LIB)
|
|
|
|
$(OUTPUT)/%_ipv4: %.c
|
|
$(LINK.c) $^ $(LDLIBS) -o $@
|
|
|
|
$(OUTPUT)/%_ipv6: %.c
|
|
$(LINK.c) -DIPV6_TEST $^ $(LDLIBS) -o $@
|
|
|
|
$(OUTPUT)/icmps-accept_ipv4: CFLAGS+= -DTEST_ICMPS_ACCEPT
|
|
$(OUTPUT)/icmps-accept_ipv6: CFLAGS+= -DTEST_ICMPS_ACCEPT
|
|
$(OUTPUT)/bench-lookups_ipv4: LDLIBS+= -lm
|
|
$(OUTPUT)/bench-lookups_ipv6: LDLIBS+= -lm
|