Nikita Zhandarovich b6dd09b3da wifi: carl9170: add a proper sanity check for endpoints ... Syzkaller reports [1] hitting a warning which is caused by presence of a wrong endpoint type at the URB sumbitting stage. While there was a check for a specific 4th endpoint, since it can switch types between bulk and interrupt, other endpoints are trusted implicitly. Similar warning is triggered in a couple of other syzbot issues [2]. Fix the issue by doing a comprehensive check of all endpoints taking into account difference between high- and full-speed configuration. [1] Syzkaller report: ... WARNING: CPU: 0 PID: 4721 at drivers/usb/core/urb.c:504 usb_submit_urb+0xed6/0x1880 drivers/usb/core/urb.c:504 ... Call Trace: <TASK> carl9170_usb_send_rx_irq_urb+0x273/0x340 drivers/net/wireless/ath/carl9170/usb.c:504 carl9170_usb_init_device drivers/net/wireless/ath/carl9170/usb.c:939 [inline] carl9170_usb_firmware_finish drivers/net/wireless/ath/carl9170/usb.c:999 [inline] carl9170_usb_firmware_step2+0x175/0x240 drivers/net/wireless/ath/carl9170/usb.c:1028 request_firmware_work_func+0x130/0x240 drivers/base/firmware_loader/main.c:1107 process_one_work+0x9bf/0x1710 kernel/workqueue.c:2289 worker_thread+0x669/0x1090 kernel/workqueue.c:2436 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 </TASK> [2] Related syzkaller crashes: Link: https://syzkaller.appspot.com/bug?extid=e394db78ae0b0032cb4d Link: https://syzkaller.appspot.com/bug?extid=9468df99cb63a4a4c4e1 Reported-and-tested-by: syzbot+0ae4804973be759fa420@syzkaller.appspotmail.com Fixes: a84fab3cbf ("carl9170: 802.11 rx/tx processing and usb backend") Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru> Acked-By: Christian Lamparter <chunkeey@gmail.com> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Link: https://msgid.link/20240422183355.3785-1-n.zhandarovich@fintech.ru		2024-04-29 20:06:47 +03:00
..
carl9170.h
cmd.c	wifi: carl9170: Fix multiple -Warray-bounds warnings	2023-03-24 16:53:23 +02:00
cmd.h
debug.c
debug.h
eeprom.h
fw.c
fwcmd.h	wifi: carl9170: Replace fake flex-array with flexible-array member	2023-03-24 16:54:01 +02:00
fwdesc.h
hw.h
Kconfig
led.c
mac.c
main.c	wifi: mac80211: simplify non-chanctx drivers	2024-02-08 12:58:32 +01:00
Makefile	wifi: carl9170: Remove -Warray-bounds exception	2022-10-12 09:36:38 +03:00
phy.c
phy.h
rx.c
tx.c	wifi: carl9170: re-fix fortified-memset warning	2024-04-04 13:09:45 +03:00
usb.c	wifi: carl9170: add a proper sanity check for endpoints	2024-04-29 20:06:47 +03:00
version.h
wlan.h