mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
ed5c2f5fd1
The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Crt Mori <cmo@melexis.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013 Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/* Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5 Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860 Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes Acked-by: Corey Minyard <cminyard@mvista.com> # for IPMI Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power Acked-by: Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
120 lines
2.8 KiB
C
120 lines
2.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2017 Pengutronix, Juergen Borleis <kernel@pengutronix.de>
|
|
*/
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/of.h>
|
|
|
|
#include "lan9303.h"
|
|
|
|
struct lan9303_i2c {
|
|
struct i2c_client *device;
|
|
struct lan9303 chip;
|
|
};
|
|
|
|
static const struct regmap_config lan9303_i2c_regmap_config = {
|
|
.reg_bits = 8,
|
|
.val_bits = 32,
|
|
.reg_stride = 1,
|
|
.can_multi_write = true,
|
|
.max_register = 0x0ff, /* address bits 0..1 are not used */
|
|
.reg_format_endian = REGMAP_ENDIAN_LITTLE,
|
|
|
|
.volatile_table = &lan9303_register_set,
|
|
.wr_table = &lan9303_register_set,
|
|
.rd_table = &lan9303_register_set,
|
|
|
|
.cache_type = REGCACHE_NONE,
|
|
};
|
|
|
|
static int lan9303_i2c_probe(struct i2c_client *client,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct lan9303_i2c *sw_dev;
|
|
int ret;
|
|
|
|
sw_dev = devm_kzalloc(&client->dev, sizeof(struct lan9303_i2c),
|
|
GFP_KERNEL);
|
|
if (!sw_dev)
|
|
return -ENOMEM;
|
|
|
|
sw_dev->chip.regmap = devm_regmap_init_i2c(client,
|
|
&lan9303_i2c_regmap_config);
|
|
if (IS_ERR(sw_dev->chip.regmap)) {
|
|
ret = PTR_ERR(sw_dev->chip.regmap);
|
|
dev_err(&client->dev, "Failed to allocate register map: %d\n",
|
|
ret);
|
|
return ret;
|
|
}
|
|
|
|
/* link forward and backward */
|
|
sw_dev->device = client;
|
|
i2c_set_clientdata(client, sw_dev);
|
|
sw_dev->chip.dev = &client->dev;
|
|
|
|
sw_dev->chip.ops = &lan9303_indirect_phy_ops;
|
|
|
|
ret = lan9303_probe(&sw_dev->chip, client->dev.of_node);
|
|
if (ret != 0)
|
|
return ret;
|
|
|
|
dev_info(&client->dev, "LAN9303 I2C driver loaded successfully\n");
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void lan9303_i2c_remove(struct i2c_client *client)
|
|
{
|
|
struct lan9303_i2c *sw_dev = i2c_get_clientdata(client);
|
|
|
|
if (!sw_dev)
|
|
return;
|
|
|
|
lan9303_remove(&sw_dev->chip);
|
|
|
|
i2c_set_clientdata(client, NULL);
|
|
}
|
|
|
|
static void lan9303_i2c_shutdown(struct i2c_client *client)
|
|
{
|
|
struct lan9303_i2c *sw_dev = i2c_get_clientdata(client);
|
|
|
|
if (!sw_dev)
|
|
return;
|
|
|
|
lan9303_shutdown(&sw_dev->chip);
|
|
|
|
i2c_set_clientdata(client, NULL);
|
|
}
|
|
|
|
/*-------------------------------------------------------------------------*/
|
|
|
|
static const struct i2c_device_id lan9303_i2c_id[] = {
|
|
{ "lan9303", 0 },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, lan9303_i2c_id);
|
|
|
|
static const struct of_device_id lan9303_i2c_of_match[] = {
|
|
{ .compatible = "smsc,lan9303-i2c", },
|
|
{ /* sentinel */ },
|
|
};
|
|
MODULE_DEVICE_TABLE(of, lan9303_i2c_of_match);
|
|
|
|
static struct i2c_driver lan9303_i2c_driver = {
|
|
.driver = {
|
|
.name = "LAN9303_I2C",
|
|
.of_match_table = of_match_ptr(lan9303_i2c_of_match),
|
|
},
|
|
.probe = lan9303_i2c_probe,
|
|
.remove = lan9303_i2c_remove,
|
|
.shutdown = lan9303_i2c_shutdown,
|
|
.id_table = lan9303_i2c_id,
|
|
};
|
|
module_i2c_driver(lan9303_i2c_driver);
|
|
|
|
MODULE_AUTHOR("Juergen Borleis <kernel@pengutronix.de>");
|
|
MODULE_DESCRIPTION("Driver for SMSC/Microchip LAN9303 three port ethernet switch in I2C managed mode");
|
|
MODULE_LICENSE("GPL v2");
|