public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-11-01 09:13:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
linux/drivers/net/wireguard
History
Eric Dumazet 93da8d75a6 wireguard: use DEV_STATS_INC() 
wg_xmit() can be called concurrently, KCSAN reported [1]
some device stats updates can be lost.

Use DEV_STATS_INC() for this unlikely case.

[1]
BUG: KCSAN: data-race in wg_xmit / wg_xmit

read-write to 0xffff888104239160 of 8 bytes by task 1375 on cpu 0:
wg_xmit+0x60f/0x680 drivers/net/wireguard/device.c:231
__netdev_start_xmit include/linux/netdevice.h:4918 [inline]
netdev_start_xmit include/linux/netdevice.h:4932 [inline]
xmit_one net/core/dev.c:3543 [inline]
dev_hard_start_xmit+0x11b/0x3f0 net/core/dev.c:3559
...

read-write to 0xffff888104239160 of 8 bytes by task 1378 on cpu 1:
wg_xmit+0x60f/0x680 drivers/net/wireguard/device.c:231
__netdev_start_xmit include/linux/netdevice.h:4918 [inline]
netdev_start_xmit include/linux/netdevice.h:4932 [inline]
xmit_one net/core/dev.c:3543 [inline]
dev_hard_start_xmit+0x11b/0x3f0 net/core/dev.c:3559
...

v2: also change wg_packet_consume_data_done() (Hangbin Liu)
    and wg_packet_purge_staged_packets()

Fixes: e7096c131e ("net: WireGuard secure network tunnel")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2023-11-19 19:48:25 +00:00
..
selftest wireguard: allowedips: expand maximum node depth 2023-08-07 12:26:57 -07:00
allowedips.c wireguard: allowedips: expand maximum node depth 2023-08-07 12:26:57 -07:00
allowedips.h
cookie.c wireguard: do not include crypto/algapi.h 2023-09-15 18:29:44 +08:00
cookie.h
device.c wireguard: use DEV_STATS_INC() 2023-11-19 19:48:25 +00:00
device.h
main.c
Makefile
messages.h
netlink.c wireguard: do not include crypto/algapi.h 2023-09-15 18:29:44 +08:00
netlink.h
noise.c wireguard: do not include crypto/algapi.h 2023-09-15 18:29:44 +08:00
noise.h
peer.c
peer.h
peerlookup.c
peerlookup.h
queueing.c wireguard: queueing: use saner cpu selection wrapping 2023-07-03 09:17:52 +01:00
queueing.h wireguard: queueing: use saner cpu selection wrapping 2023-07-03 09:17:52 +01:00
ratelimiter.c
ratelimiter.h
receive.c wireguard: use DEV_STATS_INC() 2023-11-19 19:48:25 +00:00
send.c wireguard: use DEV_STATS_INC() 2023-11-19 19:48:25 +00:00
socket.c
socket.h
timers.c wireguard: timers: move to using timer_delete_sync 2023-07-03 09:17:52 +01:00
timers.h
version.h