Lijun Pan 1f45dc2206 ibmvnic: continue fatal error reset after passive init ... Commit f9c6cea0b3 ("ibmvnic: Skip fatal error reset after passive init") says "If the passive CRQ initialization occurs before the FATAL reset task is processed, the FATAL error reset task would try to access a CRQ message queue that was freed, causing an oops. The problem may be most likely to occur during DLPAR add vNIC with a non-default MTU, because the DLPAR process will automatically issue a change MTU request. Fix this by not processing fatal error reset if CRQ is passively initialized after client-driven CRQ initialization fails." The original commit skips a specific reset condition, but that does not fix the problem it claims to fix, and misses a reset condition. The effective fix is commit 0e435befae ("ibmvnic: fix NULL pointer dereference in ibmvic_reset_crq") and commit a0faaa27c7 ("ibmvnic: fix NULL pointer dereference in reset_sub_crq_queues"). With above two fixes, there are no more crashes seen as described even without the original commit, so I would like to revert the original commit. Fixes: f9c6cea0b3 ("ibmvnic: Skip fatal error reset after passive init") Signed-off-by: Lijun Pan <ljp@linux.ibm.com> Link: https://lore.kernel.org/r/20201223204904.12677-1-ljp@linux.ibm.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2020-12-23 12:56:10 -08:00
..
ehea	net: ehea: convert tasklets to use new tasklet_setup() API	2020-09-14 13:02:37 -07:00
emac	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
ibmveth.c	ibmveth: Fix use of ibmveth in a bridge.	2020-10-27 17:52:51 -07:00
ibmveth.h	net/ethtool: Introduce link_ksettings API for virtual network devices	2020-02-29 21:48:55 -08:00
ibmvnic.c	ibmvnic: continue fatal error reset after passive init	2020-12-23 12:56:10 -08:00
ibmvnic.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-12-03 15:44:09 -08:00
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00