public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-11-16 11:44:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
linux/tools/bpf/bpftool
History
Jakub Kicinski dde7011a82 tools: bpftool: fix potential NULL pointer dereference in do_load 
This patch fixes a possible null pointer dereference in
do_load, detected by the semantic patch deref_null.cocci,
with the following warning:

./tools/bpf/bpftool/prog.c:1021:23-25: ERROR: map_replace is NULL but dereferenced.

The following code has potential null pointer references:
881             map_replace = reallocarray(map_replace, old_map_fds + 1,
882                                        sizeof(*map_replace));
883             if (!map_replace) {
884                     p_err("mem alloc failed");
885                     goto err_free_reuse_maps;
886             }

...
1019 err_free_reuse_maps:
1020         for (i = 0; i < old_map_fds; i++)
1021                 close(map_replace[i].fd);
1022         free(map_replace);

Fixes: 3ff5a4dc5d ("tools: bpftool: allow reuse of maps with bpftool prog load")
Co-developed-by: Wen Yang <wen.yang99@zte.com.cn>
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-11-22 00:45:51 +01:00
..
bash-completion tools: bpftool: fix completion for "bpftool map update" 2018-10-21 20:45:14 +02:00
Documentation tools: bpftool: update references to other man pages in documentation 2018-11-09 08:20:52 +01:00
.gitignore tools/bpftool: ignore build products 2018-07-26 02:50:26 +02:00
btf_dumper.c bpf: btf: add btf print functionality 2018-07-14 13:00:40 +02:00
cfg.c
cfg.h
cgroup.c bpftool: introduce cgroup tree command 2018-07-07 01:38:38 +02:00
common.c tools: bpftool: pass an argument to silence open_obj_pinned() 2018-11-09 08:20:52 +01:00
jit_disasm.c tools: bpftool: use 4 context mode for the NFP disasm 2018-10-18 22:16:02 +02:00
json_writer.c
json_writer.h
main.c tools: bpftool: print nb of cmds to stdout (not stderr) for batch mode 2018-10-21 20:45:14 +02:00
main.h tools: bpftool: pass an argument to silence open_obj_pinned() 2018-11-09 08:20:52 +01:00
Makefile bpftool: Allow add linker flags via EXTRA_LDFLAGS variable 2018-10-11 10:24:53 +02:00
map.c tools: bpftool: add map create command 2018-10-15 16:39:21 -07:00
map_perf_ring.c bpf, libbpf: simplify and cleanup perf ring buffer walk 2018-10-20 23:13:32 -07:00
net.c libbpf: Consistent prefixes for interfaces in nlattr.h. 2018-10-04 16:04:16 +02:00
netlink_dumper.c libbpf: Consistent prefixes for interfaces in nlattr.h. 2018-10-04 16:04:16 +02:00
netlink_dumper.h bpftool: Fix bpftool net output 2018-09-27 21:07:44 +02:00
perf.c tools/bpftool: fix a bug in bpftool perf 2018-06-13 02:03:17 +02:00
prog.c tools: bpftool: fix potential NULL pointer dereference in do_load 2018-11-22 00:45:51 +01:00
xlated_dumper.c tools: bpf: make use of reallocarray 2018-07-11 22:13:34 +02:00
xlated_dumper.h tools: bpftool: add delimiters to multi-function JITed dumps 2018-05-24 09:20:50 +02:00