mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-05-24 10:39:52 +00:00

If vimc module is removed while streaming is in progress, sensor subdev unregister runs into general protection fault when it tries to unregister media entities. This is a common subdev problem related to releasing pads from v4l2_device_unregister_subdev() before calling unregister. Unregister references pads during unregistering subdev. The sd release handler is the right place for releasing all sd resources including pads. The release handlers currently release all resources except the pads. Fix v4l2_device_unregister_subdev() not release pads and release pads from the sd_int_op release handlers. kernel: [ 4136.715839] general protection fault: 0000 [#1] SMP PTI kernel: [ 4136.715847] CPU: 2 PID: 1972 Comm: bash Not tainted 5.3.0-rc2+ #4 kernel: [ 4136.715850] Hardware name: Dell Inc. OptiPlex 790/0HY9JP, BIOS A18 09/24/2013 kernel: [ 4136.715858] RIP: 0010:media_gobj_destroy.part.16+0x1f/0x60 kernel: [ 4136.715863] Code: ff 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90 55 48 89 fe 48 89 e5 53 48 89 fb 48 c7 c7 00 7f cf b0 e8 24 fa ff ff 48 8b 03 <48> 83 80 a0 00 00 00 01 48 8b 43 18 48 8b 53 10 48 89 42 08 48 89 kernel: [ 4136.715866] RSP: 0018:ffff9b2248fe3cb0 EFLAGS: 00010246 kernel: [ 4136.715870] RAX: bcf2bfbfa0d63c2f RBX: ffff88c3eb37e9c0 RCX: 00000000802a0018 kernel: [ 4136.715873] RDX: ffff88c3e4f6a078 RSI: ffff88c3eb37e9c0 RDI: ffffffffb0cf7f00 kernel: [ 4136.715876] RBP: ffff9b2248fe3cb8 R08: 0000000001000002 R09: ffffffffb0492b00 kernel: [ 4136.715879] R10: ffff9b2248fe3c28 R11: 0000000000000001 R12: 0000000000000038 kernel: [ 4136.715881] R13: ffffffffc09a1628 R14: ffff88c3e4f6a028 R15: fffffffffffffff2 kernel: [ 4136.715885] FS: 00007f8389647740(0000) GS:ffff88c465500000(0000) knlGS:0000000000000000 kernel: [ 4136.715888] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 kernel: [ 4136.715891] CR2: 000055d008f80fd8 CR3: 00000001996ec005 CR4: 00000000000606e0 kernel: [ 4136.715894] Call Trace: kernel: [ 4136.715903] media_gobj_destroy+0x14/0x20 kernel: [ 4136.715908] __media_device_unregister_entity+0xb3/0xe0 kernel: [ 4136.715915] media_device_unregister_entity+0x30/0x40 kernel: [ 4136.715920] v4l2_device_unregister_subdev+0xa8/0xe0 kernel: [ 4136.715928] vimc_ent_sd_unregister+0x1e/0x30 [vimc] kernel: [ 4136.715933] vimc_sen_rm+0x16/0x20 [vimc] kernel: [ 4136.715938] vimc_remove+0x3e/0xa0 [vimc] kernel: [ 4136.715945] platform_drv_remove+0x25/0x50 kernel: [ 4136.715951] device_release_driver_internal+0xe0/0x1b0 kernel: [ 4136.715956] device_driver_detach+0x14/0x20 kernel: [ 4136.715960] unbind_store+0xd1/0x130 kernel: [ 4136.715965] drv_attr_store+0x27/0x40 kernel: [ 4136.715971] sysfs_kf_write+0x48/0x60 kernel: [ 4136.715976] kernfs_fop_write+0x128/0x1b0 kernel: [ 4136.715982] __vfs_write+0x1b/0x40 kernel: [ 4136.715987] vfs_write+0xc3/0x1d0 kernel: [ 4136.715993] ksys_write+0xaa/0xe0 kernel: [ 4136.715999] __x64_sys_write+0x1a/0x20 kernel: [ 4136.716005] do_syscall_64+0x5a/0x130 kernel: [ 4136.716010] entry_SYSCALL_64_after_hwframe+0x4 Signed-off-by: Shuah Khan <skhan@linuxfoundation.org> Acked-by: Helen Koike <helen.koike@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
388 lines
9.9 KiB
C
388 lines
9.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* vimc-scaler.c Virtual Media Controller Driver
|
|
*
|
|
* Copyright (C) 2015-2017 Helen Koike <helen.fornazier@gmail.com>
|
|
*/
|
|
|
|
#include <linux/moduleparam.h>
|
|
#include <linux/vmalloc.h>
|
|
#include <linux/v4l2-mediabus.h>
|
|
#include <media/v4l2-subdev.h>
|
|
|
|
#include "vimc-common.h"
|
|
|
|
static unsigned int sca_mult = 3;
|
|
module_param(sca_mult, uint, 0000);
|
|
MODULE_PARM_DESC(sca_mult, " the image size multiplier");
|
|
|
|
#define IS_SINK(pad) (!pad)
|
|
#define IS_SRC(pad) (pad)
|
|
#define MAX_ZOOM 8
|
|
|
|
struct vimc_sca_device {
|
|
struct vimc_ent_device ved;
|
|
struct v4l2_subdev sd;
|
|
struct device *dev;
|
|
/* NOTE: the source fmt is the same as the sink
|
|
* with the width and hight multiplied by mult
|
|
*/
|
|
struct v4l2_mbus_framefmt sink_fmt;
|
|
/* Values calculated when the stream starts */
|
|
u8 *src_frame;
|
|
unsigned int src_line_size;
|
|
unsigned int bpp;
|
|
};
|
|
|
|
static const struct v4l2_mbus_framefmt sink_fmt_default = {
|
|
.width = 640,
|
|
.height = 480,
|
|
.code = MEDIA_BUS_FMT_RGB888_1X24,
|
|
.field = V4L2_FIELD_NONE,
|
|
.colorspace = V4L2_COLORSPACE_DEFAULT,
|
|
};
|
|
|
|
static int vimc_sca_init_cfg(struct v4l2_subdev *sd,
|
|
struct v4l2_subdev_pad_config *cfg)
|
|
{
|
|
struct v4l2_mbus_framefmt *mf;
|
|
unsigned int i;
|
|
|
|
mf = v4l2_subdev_get_try_format(sd, cfg, 0);
|
|
*mf = sink_fmt_default;
|
|
|
|
for (i = 1; i < sd->entity.num_pads; i++) {
|
|
mf = v4l2_subdev_get_try_format(sd, cfg, i);
|
|
*mf = sink_fmt_default;
|
|
mf->width = mf->width * sca_mult;
|
|
mf->height = mf->height * sca_mult;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int vimc_sca_enum_mbus_code(struct v4l2_subdev *sd,
|
|
struct v4l2_subdev_pad_config *cfg,
|
|
struct v4l2_subdev_mbus_code_enum *code)
|
|
{
|
|
const struct vimc_pix_map *vpix = vimc_pix_map_by_index(code->index);
|
|
|
|
/* We don't support bayer format */
|
|
if (!vpix || vpix->bayer)
|
|
return -EINVAL;
|
|
|
|
code->code = vpix->code;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int vimc_sca_enum_frame_size(struct v4l2_subdev *sd,
|
|
struct v4l2_subdev_pad_config *cfg,
|
|
struct v4l2_subdev_frame_size_enum *fse)
|
|
{
|
|
const struct vimc_pix_map *vpix;
|
|
|
|
if (fse->index)
|
|
return -EINVAL;
|
|
|
|
/* Only accept code in the pix map table in non bayer format */
|
|
vpix = vimc_pix_map_by_code(fse->code);
|
|
if (!vpix || vpix->bayer)
|
|
return -EINVAL;
|
|
|
|
fse->min_width = VIMC_FRAME_MIN_WIDTH;
|
|
fse->min_height = VIMC_FRAME_MIN_HEIGHT;
|
|
|
|
if (IS_SINK(fse->pad)) {
|
|
fse->max_width = VIMC_FRAME_MAX_WIDTH;
|
|
fse->max_height = VIMC_FRAME_MAX_HEIGHT;
|
|
} else {
|
|
fse->max_width = VIMC_FRAME_MAX_WIDTH * MAX_ZOOM;
|
|
fse->max_height = VIMC_FRAME_MAX_HEIGHT * MAX_ZOOM;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int vimc_sca_get_fmt(struct v4l2_subdev *sd,
|
|
struct v4l2_subdev_pad_config *cfg,
|
|
struct v4l2_subdev_format *format)
|
|
{
|
|
struct vimc_sca_device *vsca = v4l2_get_subdevdata(sd);
|
|
|
|
/* Get the current sink format */
|
|
format->format = (format->which == V4L2_SUBDEV_FORMAT_TRY) ?
|
|
*v4l2_subdev_get_try_format(sd, cfg, 0) :
|
|
vsca->sink_fmt;
|
|
|
|
/* Scale the frame size for the source pad */
|
|
if (IS_SRC(format->pad)) {
|
|
format->format.width = vsca->sink_fmt.width * sca_mult;
|
|
format->format.height = vsca->sink_fmt.height * sca_mult;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void vimc_sca_adjust_sink_fmt(struct v4l2_mbus_framefmt *fmt)
|
|
{
|
|
const struct vimc_pix_map *vpix;
|
|
|
|
/* Only accept code in the pix map table in non bayer format */
|
|
vpix = vimc_pix_map_by_code(fmt->code);
|
|
if (!vpix || vpix->bayer)
|
|
fmt->code = sink_fmt_default.code;
|
|
|
|
fmt->width = clamp_t(u32, fmt->width, VIMC_FRAME_MIN_WIDTH,
|
|
VIMC_FRAME_MAX_WIDTH) & ~1;
|
|
fmt->height = clamp_t(u32, fmt->height, VIMC_FRAME_MIN_HEIGHT,
|
|
VIMC_FRAME_MAX_HEIGHT) & ~1;
|
|
|
|
if (fmt->field == V4L2_FIELD_ANY)
|
|
fmt->field = sink_fmt_default.field;
|
|
|
|
vimc_colorimetry_clamp(fmt);
|
|
}
|
|
|
|
static int vimc_sca_set_fmt(struct v4l2_subdev *sd,
|
|
struct v4l2_subdev_pad_config *cfg,
|
|
struct v4l2_subdev_format *fmt)
|
|
{
|
|
struct vimc_sca_device *vsca = v4l2_get_subdevdata(sd);
|
|
struct v4l2_mbus_framefmt *sink_fmt;
|
|
|
|
if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) {
|
|
/* Do not change the format while stream is on */
|
|
if (vsca->src_frame)
|
|
return -EBUSY;
|
|
|
|
sink_fmt = &vsca->sink_fmt;
|
|
} else {
|
|
sink_fmt = v4l2_subdev_get_try_format(sd, cfg, 0);
|
|
}
|
|
|
|
/*
|
|
* Do not change the format of the source pad,
|
|
* it is propagated from the sink
|
|
*/
|
|
if (IS_SRC(fmt->pad)) {
|
|
fmt->format = *sink_fmt;
|
|
fmt->format.width = sink_fmt->width * sca_mult;
|
|
fmt->format.height = sink_fmt->height * sca_mult;
|
|
} else {
|
|
/* Set the new format in the sink pad */
|
|
vimc_sca_adjust_sink_fmt(&fmt->format);
|
|
|
|
dev_dbg(vsca->dev, "%s: sink format update: "
|
|
"old:%dx%d (0x%x, %d, %d, %d, %d) "
|
|
"new:%dx%d (0x%x, %d, %d, %d, %d)\n", vsca->sd.name,
|
|
/* old */
|
|
sink_fmt->width, sink_fmt->height, sink_fmt->code,
|
|
sink_fmt->colorspace, sink_fmt->quantization,
|
|
sink_fmt->xfer_func, sink_fmt->ycbcr_enc,
|
|
/* new */
|
|
fmt->format.width, fmt->format.height, fmt->format.code,
|
|
fmt->format.colorspace, fmt->format.quantization,
|
|
fmt->format.xfer_func, fmt->format.ycbcr_enc);
|
|
|
|
*sink_fmt = fmt->format;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct v4l2_subdev_pad_ops vimc_sca_pad_ops = {
|
|
.init_cfg = vimc_sca_init_cfg,
|
|
.enum_mbus_code = vimc_sca_enum_mbus_code,
|
|
.enum_frame_size = vimc_sca_enum_frame_size,
|
|
.get_fmt = vimc_sca_get_fmt,
|
|
.set_fmt = vimc_sca_set_fmt,
|
|
};
|
|
|
|
static int vimc_sca_s_stream(struct v4l2_subdev *sd, int enable)
|
|
{
|
|
struct vimc_sca_device *vsca = v4l2_get_subdevdata(sd);
|
|
|
|
if (enable) {
|
|
const struct vimc_pix_map *vpix;
|
|
unsigned int frame_size;
|
|
|
|
if (vsca->src_frame)
|
|
return 0;
|
|
|
|
/* Save the bytes per pixel of the sink */
|
|
vpix = vimc_pix_map_by_code(vsca->sink_fmt.code);
|
|
vsca->bpp = vpix->bpp;
|
|
|
|
/* Calculate the width in bytes of the src frame */
|
|
vsca->src_line_size = vsca->sink_fmt.width *
|
|
sca_mult * vsca->bpp;
|
|
|
|
/* Calculate the frame size of the source pad */
|
|
frame_size = vsca->src_line_size * vsca->sink_fmt.height *
|
|
sca_mult;
|
|
|
|
/* Allocate the frame buffer. Use vmalloc to be able to
|
|
* allocate a large amount of memory
|
|
*/
|
|
vsca->src_frame = vmalloc(frame_size);
|
|
if (!vsca->src_frame)
|
|
return -ENOMEM;
|
|
|
|
} else {
|
|
if (!vsca->src_frame)
|
|
return 0;
|
|
|
|
vfree(vsca->src_frame);
|
|
vsca->src_frame = NULL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct v4l2_subdev_video_ops vimc_sca_video_ops = {
|
|
.s_stream = vimc_sca_s_stream,
|
|
};
|
|
|
|
static const struct v4l2_subdev_ops vimc_sca_ops = {
|
|
.pad = &vimc_sca_pad_ops,
|
|
.video = &vimc_sca_video_ops,
|
|
};
|
|
|
|
static void vimc_sca_fill_pix(u8 *const ptr,
|
|
const u8 *const pixel,
|
|
const unsigned int bpp)
|
|
{
|
|
unsigned int i;
|
|
|
|
/* copy the pixel to the pointer */
|
|
for (i = 0; i < bpp; i++)
|
|
ptr[i] = pixel[i];
|
|
}
|
|
|
|
static void vimc_sca_scale_pix(const struct vimc_sca_device *const vsca,
|
|
const unsigned int lin, const unsigned int col,
|
|
const u8 *const sink_frame)
|
|
{
|
|
unsigned int i, j, index;
|
|
const u8 *pixel;
|
|
|
|
/* Point to the pixel value in position (lin, col) in the sink frame */
|
|
index = VIMC_FRAME_INDEX(lin, col,
|
|
vsca->sink_fmt.width,
|
|
vsca->bpp);
|
|
pixel = &sink_frame[index];
|
|
|
|
dev_dbg(vsca->dev,
|
|
"sca: %s: --- scale_pix sink pos %dx%d, index %d ---\n",
|
|
vsca->sd.name, lin, col, index);
|
|
|
|
/* point to the place we are going to put the first pixel
|
|
* in the scaled src frame
|
|
*/
|
|
index = VIMC_FRAME_INDEX(lin * sca_mult, col * sca_mult,
|
|
vsca->sink_fmt.width * sca_mult, vsca->bpp);
|
|
|
|
dev_dbg(vsca->dev, "sca: %s: scale_pix src pos %dx%d, index %d\n",
|
|
vsca->sd.name, lin * sca_mult, col * sca_mult, index);
|
|
|
|
/* Repeat this pixel mult times */
|
|
for (i = 0; i < sca_mult; i++) {
|
|
/* Iterate through each beginning of a
|
|
* pixel repetition in a line
|
|
*/
|
|
for (j = 0; j < sca_mult * vsca->bpp; j += vsca->bpp) {
|
|
dev_dbg(vsca->dev,
|
|
"sca: %s: sca: scale_pix src pos %d\n",
|
|
vsca->sd.name, index + j);
|
|
|
|
/* copy the pixel to the position index + j */
|
|
vimc_sca_fill_pix(&vsca->src_frame[index + j],
|
|
pixel, vsca->bpp);
|
|
}
|
|
|
|
/* move the index to the next line */
|
|
index += vsca->src_line_size;
|
|
}
|
|
}
|
|
|
|
static void vimc_sca_fill_src_frame(const struct vimc_sca_device *const vsca,
|
|
const u8 *const sink_frame)
|
|
{
|
|
unsigned int i, j;
|
|
|
|
/* Scale each pixel from the original sink frame */
|
|
/* TODO: implement scale down, only scale up is supported for now */
|
|
for (i = 0; i < vsca->sink_fmt.height; i++)
|
|
for (j = 0; j < vsca->sink_fmt.width; j++)
|
|
vimc_sca_scale_pix(vsca, i, j, sink_frame);
|
|
}
|
|
|
|
static void *vimc_sca_process_frame(struct vimc_ent_device *ved,
|
|
const void *sink_frame)
|
|
{
|
|
struct vimc_sca_device *vsca = container_of(ved, struct vimc_sca_device,
|
|
ved);
|
|
|
|
/* If the stream in this node is not active, just return */
|
|
if (!vsca->src_frame)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
vimc_sca_fill_src_frame(vsca, sink_frame);
|
|
|
|
return vsca->src_frame;
|
|
};
|
|
|
|
static void vimc_sca_release(struct v4l2_subdev *sd)
|
|
{
|
|
struct vimc_sca_device *vsca =
|
|
container_of(sd, struct vimc_sca_device, sd);
|
|
|
|
vimc_pads_cleanup(vsca->ved.pads);
|
|
kfree(vsca);
|
|
}
|
|
|
|
static const struct v4l2_subdev_internal_ops vimc_sca_int_ops = {
|
|
.release = vimc_sca_release,
|
|
};
|
|
|
|
void vimc_sca_rm(struct vimc_device *vimc, struct vimc_ent_device *ved)
|
|
{
|
|
struct vimc_sca_device *vsca;
|
|
|
|
vsca = container_of(ved, struct vimc_sca_device, ved);
|
|
vimc_ent_sd_unregister(ved, &vsca->sd);
|
|
}
|
|
|
|
struct vimc_ent_device *vimc_sca_add(struct vimc_device *vimc,
|
|
const char *vcfg_name)
|
|
{
|
|
struct v4l2_device *v4l2_dev = &vimc->v4l2_dev;
|
|
struct vimc_sca_device *vsca;
|
|
int ret;
|
|
|
|
/* Allocate the vsca struct */
|
|
vsca = kzalloc(sizeof(*vsca), GFP_KERNEL);
|
|
if (!vsca)
|
|
return NULL;
|
|
|
|
/* Initialize ved and sd */
|
|
ret = vimc_ent_sd_register(&vsca->ved, &vsca->sd, v4l2_dev,
|
|
vcfg_name,
|
|
MEDIA_ENT_F_PROC_VIDEO_SCALER, 2,
|
|
(const unsigned long[2]) {MEDIA_PAD_FL_SINK,
|
|
MEDIA_PAD_FL_SOURCE},
|
|
&vimc_sca_int_ops, &vimc_sca_ops);
|
|
if (ret) {
|
|
kfree(vsca);
|
|
return NULL;
|
|
}
|
|
|
|
vsca->ved.process_frame = vimc_sca_process_frame;
|
|
vsca->dev = &vimc->pdev.dev;
|
|
|
|
/* Initialize the frame format */
|
|
vsca->sink_fmt = sink_fmt_default;
|
|
|
|
return &vsca->ved;
|
|
}
|