Michal Hocko d1b5c5671d btrfs: Prevent from early transaction abort ... Btrfs relies on GFP_NOFS allocation when committing the transaction but this allocation context is rather weak wrt. reclaim capabilities. The page allocator currently tries hard to not fail these allocations if they are small (<=PAGE_ALLOC_COSTLY_ORDER) so this is not a problem currently but there is an attempt to move away from the default no-fail behavior and allow these allocation to fail more eagerly. And this would lead to a pre-mature transaction abort as follows: [ 55.328093] Call Trace: [ 55.328890] [<ffffffff8154e6f0>] dump_stack+0x4f/0x7b [ 55.330518] [<ffffffff8108fa28>] ? console_unlock+0x334/0x363 [ 55.332738] [<ffffffff8110873e>] __alloc_pages_nodemask+0x81d/0x8d4 [ 55.334910] [<ffffffff81100752>] pagecache_get_page+0x10e/0x20c [ 55.336844] [<ffffffffa007d916>] alloc_extent_buffer+0xd0/0x350 [btrfs] [ 55.338973] [<ffffffffa0059d8c>] btrfs_find_create_tree_block+0x15/0x17 [btrfs] [ 55.341329] [<ffffffffa004f728>] btrfs_alloc_tree_block+0x18c/0x405 [btrfs] [ 55.343566] [<ffffffffa003fa34>] split_leaf+0x1e4/0x6a6 [btrfs] [ 55.345577] [<ffffffffa0040567>] btrfs_search_slot+0x671/0x831 [btrfs] [ 55.347679] [<ffffffff810682d7>] ? get_parent_ip+0xe/0x3e [ 55.349434] [<ffffffffa0041cb2>] btrfs_insert_empty_items+0x5d/0xa8 [btrfs] [ 55.351681] [<ffffffffa004ecfb>] __btrfs_run_delayed_refs+0x7a6/0xf35 [btrfs] [ 55.353979] [<ffffffffa00512ea>] btrfs_run_delayed_refs+0x6e/0x226 [btrfs] [ 55.356212] [<ffffffffa0060e21>] ? start_transaction+0x192/0x534 [btrfs] [ 55.358378] [<ffffffffa0060e21>] ? start_transaction+0x192/0x534 [btrfs] [ 55.360626] [<ffffffffa0060221>] btrfs_commit_transaction+0x4c/0xaba [btrfs] [ 55.362894] [<ffffffffa0060e21>] ? start_transaction+0x192/0x534 [btrfs] [ 55.365221] [<ffffffffa0073428>] btrfs_sync_file+0x29c/0x310 [btrfs] [ 55.367273] [<ffffffff81186808>] vfs_fsync_range+0x8f/0x9e [ 55.369047] [<ffffffff81186833>] vfs_fsync+0x1c/0x1e [ 55.370654] [<ffffffff81186869>] do_fsync+0x34/0x4e [ 55.372246] [<ffffffff81186ab3>] SyS_fsync+0x10/0x14 [ 55.373851] [<ffffffff81554f97>] system_call_fastpath+0x12/0x6f [ 55.381070] BTRFS: error (device hdb1) in btrfs_run_delayed_refs:2821: errno=-12 Out of memory [ 55.382431] BTRFS warning (device hdb1): Skipping commit of aborted transaction. [ 55.382433] BTRFS warning (device hdb1): cleanup_transaction:1692: Aborting unused transaction(IO failure). [ 55.384280] ------------[ cut here ]------------ [ 55.384312] WARNING: CPU: 0 PID: 3010 at fs/btrfs/delayed-ref.c:438 btrfs_select_ref_head+0xd9/0xfe [btrfs]() [...] [ 55.384337] Call Trace: [ 55.384353] [<ffffffff8154e6f0>] dump_stack+0x4f/0x7b [ 55.384357] [<ffffffff8107f717>] ? down_trylock+0x2d/0x37 [ 55.384359] [<ffffffff81046977>] warn_slowpath_common+0xa1/0xbb [ 55.384398] [<ffffffffa00a1d6b>] ? btrfs_select_ref_head+0xd9/0xfe [btrfs] [ 55.384400] [<ffffffff81046a34>] warn_slowpath_null+0x1a/0x1c [ 55.384423] [<ffffffffa00a1d6b>] btrfs_select_ref_head+0xd9/0xfe [btrfs] [ 55.384446] [<ffffffffa004e5f7>] ? __btrfs_run_delayed_refs+0xa2/0xf35 [btrfs] [ 55.384455] [<ffffffffa004e600>] __btrfs_run_delayed_refs+0xab/0xf35 [btrfs] [ 55.384476] [<ffffffffa00512ea>] btrfs_run_delayed_refs+0x6e/0x226 [btrfs] [ 55.384499] [<ffffffffa0060e21>] ? start_transaction+0x192/0x534 [btrfs] [ 55.384521] [<ffffffffa0060e21>] ? start_transaction+0x192/0x534 [btrfs] [ 55.384543] [<ffffffffa0060221>] btrfs_commit_transaction+0x4c/0xaba [btrfs] [ 55.384565] [<ffffffffa0060e21>] ? start_transaction+0x192/0x534 [btrfs] [ 55.384588] [<ffffffffa0073428>] btrfs_sync_file+0x29c/0x310 [btrfs] [ 55.384591] [<ffffffff81186808>] vfs_fsync_range+0x8f/0x9e [ 55.384592] [<ffffffff81186833>] vfs_fsync+0x1c/0x1e [ 55.384593] [<ffffffff81186869>] do_fsync+0x34/0x4e [ 55.384594] [<ffffffff81186ab3>] SyS_fsync+0x10/0x14 [ 55.384595] [<ffffffff81554f97>] system_call_fastpath+0x12/0x6f [...] [ 55.384608] ---[ end trace c29799da1d4dd621 ]--- [ 55.437323] BTRFS info (device hdb1): forced readonly [ 55.438815] BTRFS info (device hdb1): delayed_refs has NO entry Fix this by being explicit about the no-fail behavior of this allocation path and use __GFP_NOFAIL. Signed-off-by: Michal Hocko <mhocko@suse.com> Signed-off-by: Chris Mason <clm@fb.com>		2015-08-19 14:25:15 -07:00
..
tests	btrfs: qgroup: Switch self test to extent-oriented qgroup mechanism.	2015-06-10 09:26:05 -07:00
acl.c	btrfs: remove useless ACL check	2014-06-09 17:20:42 -07:00
async-thread.c	btrfs: Fix lockdep warning of wr_ctx->wr_lock in scrub_free_wr_ctx()	2015-06-10 07:04:52 -07:00
async-thread.h	btrfs: Fix lockdep warning of wr_ctx->wr_lock in scrub_free_wr_ctx()	2015-06-10 07:04:52 -07:00
backref.c	Btrfs: fix warning in backref walking	2015-08-09 07:33:50 -07:00
backref.h	btrfs: cleanup, remove inode_item_info helper	2015-01-14 19:23:47 +01:00
btrfs_inode.h	Btrfs: fix warning of bytes_may_use	2015-07-01 17:17:21 -07:00
check-integrity.c	Merge branch 'cleanups-post-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.1	2015-03-25 10:52:48 -07:00
check-integrity.h
compression.c	Merge branch 'cleanups-post-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.1	2015-03-25 10:52:48 -07:00
compression.h	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00
ctree.c	btrfs: abort transaction on btrfs_reloc_cow_block()	2015-08-09 07:07:14 -07:00
ctree.h	Merge branch 'jeffm-discard-4.3' into for-linus-4.3	2015-08-09 07:35:33 -07:00
delayed-inode.c	Btrfs: fill ->last_trans for delayed inode in btrfs_fill_inode.	2015-04-26 06:27:03 -07:00
delayed-inode.h
delayed-ref.c	btrfs: delayed-ref: double free in btrfs_add_delayed_tree_ref()	2015-06-24 12:28:03 -07:00
delayed-ref.h	btrfs: qgroup: Add the ability to skip given qgroup for old/new_roots.	2015-06-10 09:26:23 -07:00
dev-replace.c	btrfs: its btrfs_err() instead of btrfs_error()	2015-07-22 18:20:53 -07:00
dev-replace.h
dir-item.c	Btrfs: make xattr replace operations atomic	2014-11-20 17:20:07 -08:00
disk-io.c	Merge branch 'jeffm-discard-4.3' into for-linus-4.3	2015-08-09 07:35:33 -07:00
disk-io.h	Btrfs: disk-io: replace root args iff only fs_info used	2015-02-16 18:48:43 +01:00
export.c	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
export.h
extent-tree.c	Merge branch 'jeffm-discard-4.3' into for-linus-4.3	2015-08-09 07:35:33 -07:00
extent-tree.h	btrfs: qgroup: Add new qgroup calculation function	2015-06-10 09:25:49 -07:00
extent_io.c	btrfs: Prevent from early transaction abort	2015-08-19 14:25:15 -07:00
extent_io.h	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00
extent_map.c	Btrfs: do not move em to modified list when unpinning	2014-11-21 11:59:54 -08:00
extent_map.h	Btrfs: fix NULL pointer crash when running balance and scrub concurrently	2014-06-19 14:20:55 -07:00
file-item.c	Merge branch 'cleanups-post-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.1	2015-03-25 10:52:48 -07:00
file.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
free-space-cache.c	btrfs: add missing discards when unpinning extents with -o discard	2015-07-29 08:15:29 -07:00
free-space-cache.h	Btrfs: allow block group cache writeout outside critical section in commit	2015-04-10 14:07:22 -07:00
hash.c	btrfs: LLVMLinux: Remove VLAIS	2014-10-14 10:51:22 +02:00
hash.h
inode-item.c	Btrfs: fix fsync log replay for inodes with a mix of regular refs and extrefs	2015-01-21 18:02:05 -08:00
inode-map.c	Btrfs: fix race between caching kthread and returning inode to inode cache	2015-06-30 14:36:46 -07:00
inode-map.h
inode.c	Btrfs: add support for blkio controllers	2015-08-09 07:35:06 -07:00
ioctl.c	btrfs: fix clone / extent-same deadlocks	2015-08-09 07:34:25 -07:00
Kconfig	rcu: Make SRCU optional by using CONFIG_SRCU	2015-01-06 11:04:29 -08:00
locking.c	btrfs: Add WARN_ON() for double lock in btrfs_tree_lock()	2015-08-09 07:07:14 -07:00
locking.h	btrfs: fix lockups from btrfs_clear_path_blocking	2014-11-19 10:34:35 -08:00
lzo.c	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00
Makefile	Btrfs: add sanity tests for new qgroup accounting code	2014-06-09 17:20:49 -07:00
math.h	btrfs: cleanup 64bit/32bit divs, compile time constants	2015-03-03 17:23:57 +01:00
ordered-data.c	Btrfs: fix memory corruption on failure to submit bio for direct IO	2015-07-01 17:17:18 -07:00
ordered-data.h	Btrfs: avoid syncing log in the fast fsync path when not necessary	2015-06-10 07:02:43 -07:00
orphan.c	btrfs: kill the key type accessor helpers	2014-09-17 13:37:12 -07:00
print-tree.c	btrfs: remove parameter blocksize from read_tree_block	2014-10-02 17:14:50 +02:00
print-tree.h
props.c	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00
props.h
qgroup.c	btrfs: qgroup: allow user to clear the limitation on qgroup	2015-06-30 13:20:00 -07:00
qgroup.h	btrfs: qgroup: Cleanup the old ref_node-oriented mechanism.	2015-06-10 09:26:11 -07:00
raid56.c	Btrfs: add RAID 5/6 BTRFS_RBIO_REBUILD_MISSING operation	2015-08-09 07:34:26 -07:00
raid56.h	Btrfs: add RAID 5/6 BTRFS_RBIO_REBUILD_MISSING operation	2015-08-09 07:34:26 -07:00
rcu-string.h
reada.c	Btrfs: count devices correctly in readahead during RAID 5/6 replace	2015-08-09 07:34:26 -07:00
relocation.c	btrfs: Remove unnecessary variants in relocation.c	2015-08-09 07:07:14 -07:00
root-tree.c	Btrfs: use bitfield instead of integer data type for the some variants in btrfs_root	2014-06-09 17:20:40 -07:00
scrub.c	Btrfs: fix parity scrub of RAID 5/6 with missing device	2015-08-09 07:34:26 -07:00
send.c	Btrfs: use received_uuid of parent during send	2015-06-12 13:20:38 -07:00
send.h
struct-funcs.c
super.c	Merge branch 'jeffm-discard-4.3' into for-linus-4.3	2015-08-09 07:35:33 -07:00
sysfs.c	Btrfs: Check if kobject is initialized before put	2015-06-22 14:43:31 +02:00
sysfs.h	Btrfs: sysfs: btrfs_sysfs_remove_fsid() make it non static	2015-05-27 12:27:22 +02:00
transaction.c	Merge branch 'jeffm-discard-4.3' into for-linus-4.3	2015-08-09 07:35:33 -07:00
transaction.h	btrfs: add missing discards when unpinning extents with -o discard	2015-07-29 08:15:29 -07:00
tree-defrag.c	btrfs: let tree defrag work in SSD mode	2015-06-02 19:34:33 -07:00
tree-log.c	btrfs: Remove unused arguments in tree-log.c	2015-08-19 14:25:15 -07:00
tree-log.h	Btrfs: fix metadata inconsistencies after directory fsync	2015-03-26 17:56:23 -07:00
ulist.c	btrfs: ulist: Add ulist_del() function.	2015-06-10 09:26:17 -07:00
ulist.h	btrfs: ulist: Add ulist_del() function.	2015-06-10 09:26:17 -07:00
uuid-tree.c	Btrfs: make btrfs_search_forward return with nodes unlocked	2014-09-17 13:38:02 -07:00
volumes.c	Merge branch 'jeffm-discard-4.3' into for-linus-4.3	2015-08-09 07:35:33 -07:00
volumes.h	Merge branch 'jeffm-discard-4.3' into for-linus-4.3	2015-08-09 07:35:33 -07:00
xattr.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-26 17:22:07 -07:00
xattr.h
zlib.c	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00