Linus Torvalds 80e1e82398 Fix race in tty_fasync() properly ... This reverts commit 7036251180 ("tty: fix race in tty_fasync") and commit b04da8bfdf ("fnctl: f_modown should call write_lock_irqsave/ restore") that tried to fix up some of the fallout but was incomplete. It turns out that we really cannot hold 'tty->ctrl_lock' over calling __f_setown, because not only did that cause problems with interrupt disables (which the second commit fixed), it also causes a potential ABBA deadlock due to lock ordering. Thanks to Tetsuo Handa for following up on the issue, and running lockdep to show the problem. It goes roughly like this: - f_getown gets filp->f_owner.lock for reading without interrupts disabled, so an interrupt that happens while that lock is held can cause a lockdep chain from f_owner.lock -> sighand->siglock. - at the same time, the tty->ctrl_lock -> f_owner.lock chain that commit 7036251180 introduced, together with the pre-existing sighand->siglock -> tty->ctrl_lock chain means that we have a lock dependency the other way too. So instead of extending tty->ctrl_lock over the whole __f_setown() call, we now just take a reference to the 'pid' structure while holding the lock, and then release it after having done the __f_setown. That still guarantees that 'struct pid' won't go away from under us, which is all we really ever needed. Reported-and-tested-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Acked-by: Américo Wang <xiyou.wangcong@gmail.com> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2010-02-07 10:26:01 -08:00
..
accessibility
acpi
amba
ata	[libata] Call flush_dcache_page after PIO data transfers in libata-sff.c	2010-02-04 01:04:50 -05:00
atm
auxdisplay
base
block	pktcdvd: removing device does not remove its sysfs dir	2010-02-02 18:11:23 -08:00
bluetooth	Bluetooth: Add DFU driver for Atheros Bluetooth chipset AR3011	2010-01-30 05:57:34 -08:00
cdrom
char	Fix race in tty_fasync() properly	2010-02-07 10:26:01 -08:00
clocksource
connector	connector: Delete buggy notification code.	2010-02-02 15:58:48 -08:00
cpufreq
cpuidle
crypto	crypto: padlock-sha - Add import/export support	2010-02-02 06:50:25 +11:00
dca
dio
dma
edac
eisa
firewire
firmware
gpio
gpu	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/anholt/drm-intel	2010-02-06 13:01:39 -08:00
hid
hwmon	hwmon: (w83781d) Request I/O ports individually for probing	2010-02-05 19:58:36 +01:00
i2c
ide
idle
ieee1394
ieee802154
infiniband
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2010-01-29 11:15:32 -08:00
isdn
leds
lguest
macintosh
mca
md
media	saa7146: stop DMA before de-allocating DMA scatter/gather page buffers	2010-02-01 22:02:03 -02:00
memstick
message
mfd	mfd: Fix asic3 build	2010-01-29 21:03:09 +01:00
misc
mmc
mtd	Merge branch 'for-linus' of git://git.infradead.org/ubi-2.6	2010-01-28 12:57:50 -08:00
net	be2net: use eq-id to calculate cev-isr reg offset	2010-02-02 07:48:40 -08:00
nubus
of
oprofile
parisc
parport
pci	CS5536: apply pci quirk for BIOS SMBUS bug	2010-02-05 07:36:50 -08:00
pcmcia
platform
pnp
power
pps
ps3
rapidio
regulator	regulator: Specify REGULATOR_CHANGE_STATUS for WM835x LED constraints	2010-02-01 13:52:44 +00:00
rtc	rtc-fm3130: add missing braces	2010-02-02 18:11:21 -08:00
s390
sbus
scsi
serial	uartlite: fix crash when using as console	2010-02-02 18:11:22 -08:00
sfi
sh
sn
spi	spi: spi_sh_msiof: Fixed data sampling on the correct edge	2010-02-02 11:29:15 +09:00
ssb
staging	Merge branch 'drm-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6	2010-02-01 10:46:49 -08:00
tc
telephony
thermal
uio
usb	usb: r8a66597-hdc disable interrupts fix	2010-02-02 11:30:45 +09:00
uwb
video	imxfb: correct location of callbacks in suspend and resume	2010-02-02 18:11:22 -08:00
virtio
vlynq
w1
watchdog
xen
zorro
Kconfig
Makefile