mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-04 00:06:36 +00:00
c6c5b14dac
Due to changes in memory resources caused by either memory hotplug or online/offline events, the elfcorehdr, which describes the CPUs and memory of the crashed kernel to the kernel that collects the dump (known as second/fadump kernel), becomes outdated. Consequently, attempting dump collection with an outdated elfcorehdr can lead to failed or inaccurate dump collection. Memory hotplug or online/offline events is referred as memory add/remove events in reset of the commit message. The current solution to address the aforementioned issue is as follows: Monitor memory add/remove events in userspace using udev rules, and re-register fadump whenever there are changes in memory resources. This leads to the creation of a new elfcorehdr with updated system memory information. There are several notable issues associated with re-registering fadump for every memory add/remove events. 1. Bulk memory add/remove events with udev-based fadump re-registration can lead to race conditions and, more importantly, it creates a wide window during which fadump is inactive until all memory add/remove events are settled. 2. Re-registering fadump for every memory add/remove event is inefficient. 3. The memory for elfcorehdr is allocated based on the memblock regions available during early boot and remains fixed thereafter. However, if elfcorehdr is later recreated with additional memblock regions, its size will increase, potentially leading to memory corruption. Address the aforementioned challenges by shifting the creation of elfcorehdr from the first kernel (also referred as the crashed kernel), where it was created and frequently recreated for every memory add/remove event, to the fadump kernel. As a result, the elfcorehdr only needs to be created once, thus eliminating the necessity to re-register fadump during memory add/remove events. At present, the first kernel prepares fadump header and stores it in the fadump reserved area. The fadump header includes the start address of the elfcorehdr, crashing CPU details, and other relevant information. In the event of a crash in the first kernel, the second/fadump boots and accesses the fadump header prepared by the first kernel. It then performs the following steps in a platform-specific function [rtas|opal]_fadump_process: 1. Sanity check for fadump header 2. Update CPU notes in elfcorehdr Along with the above, update the setup_fadump()/fadump.c to create elfcorehdr and set its address to the global variable elfcorehdr_addr for the vmcore module to process it in the second/fadump kernel. Section below outlines the information required to create the elfcorehdr and the changes made to make it available to the fadump kernel if it's not already. To create elfcorehdr, the following crashed kernel information is required: CPU notes, vmcoreinfo, and memory ranges. At present, the CPU notes are already prepared in the fadump kernel, so no changes are needed in that regard. The fadump kernel has access to all crashed kernel memory regions, including boot memory regions that are relocated by firmware to fadump reserved areas, so no changes for that either. However, it is necessary to add new members to the fadump header, i.e., the 'fadump_crash_info_header' structure, in order to pass the crashed kernel's vmcoreinfo address and its size to fadump kernel. In addition to the vmcoreinfo address and size, there are a few other attributes also added to the fadump_crash_info_header structure. 1. version: It stores the fadump header version, which is currently set to 1. This provides flexibility to update the fadump crash info header in the future without changing the magic number. For each change in the fadump header, the version will be increased. This will help the updated kernel determine how to handle kernel dumps from older kernels. The magic number remains relevant for checking fadump header corruption. 2. pt_regs_sz/cpu_mask_sz: Store size of pt_regs and cpu_mask structure of first kernel. These attributes are used to prevent dump processing if the sizes of pt_regs or cpu_mask structure differ between the first and fadump kernels. Note: if either first/crashed kernel or second/fadump kernel do not have the changes introduced here then kernel fail to collect the dump and prints relevant error message on the console. Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/20240422195932.1583833-2-sourabhjain@linux.ibm.com |
||
|---|---|---|
| .. | ||
| ptrace | ||
| syscalls | ||
| trace | ||
| vdso | ||
| .gitignore | ||
| 85xx_entry_mapping.S | ||
| align.c | ||
| asm-offsets.c | ||
| audit.c | ||
| audit_32.h | ||
| btext.c | ||
| cacheinfo.c | ||
| cacheinfo.h | ||
| compat_audit.c | ||
| cpu_setup_6xx.S | ||
| cpu_setup_44x.S | ||
| cpu_setup_e500.S | ||
| cpu_setup_pa6t.S | ||
| cpu_setup_power.c | ||
| cpu_setup_ppc970.S | ||
| cpu_specs.h | ||
| cpu_specs_8xx.h | ||
| cpu_specs_40x.h | ||
| cpu_specs_44x.h | ||
| cpu_specs_47x.h | ||
| cpu_specs_85xx.h | ||
| cpu_specs_book3s_32.h | ||
| cpu_specs_book3s_64.h | ||
| cpu_specs_e500mc.h | ||
| cputable.c | ||
| crash_dump.c | ||
| dawr.c | ||
| dbell.c | ||
| dma-iommu.c | ||
| dma-mask.c | ||
| dma-swiotlb.c | ||
| dt_cpu_ftrs.c | ||
| early_32.c | ||
| eeh.c | ||
| eeh_cache.c | ||
| eeh_driver.c | ||
| eeh_event.c | ||
| eeh_pe.c | ||
| eeh_sysfs.c | ||
| entry_32.S | ||
| epapr_hcalls.S | ||
| epapr_paravirt.c | ||
| exceptions-64e.S | ||
| exceptions-64s.S | ||
| fadump.c | ||
| firmware.c | ||
| fpu.S | ||
| head_8xx.S | ||
| head_32.h | ||
| head_40x.S | ||
| head_44x.S | ||
| head_64.S | ||
| head_85xx.S | ||
| head_book3s_32.S | ||
| head_booke.h | ||
| hw_breakpoint.c | ||
| hw_breakpoint_constraints.c | ||
| idle.c | ||
| idle_6xx.S | ||
| idle_64e.S | ||
| idle_85xx.S | ||
| idle_book3s.S | ||
| ima_arch.c | ||
| interrupt.c | ||
| interrupt_64.S | ||
| io-workarounds.c | ||
| io.c | ||
| iomap.c | ||
| iommu.c | ||
| irq.c | ||
| irq_64.c | ||
| isa-bridge.c | ||
| jump_label.c | ||
| kdebugfs.c | ||
| kgdb.c | ||
| kprobes-ftrace.c | ||
| kprobes.c | ||
| kvm.c | ||
| kvm_emul.S | ||
| l2cr_6xx.S | ||
| legacy_serial.c | ||
| Makefile | ||
| mce.c | ||
| mce_power.c | ||
| misc.S | ||
| misc_32.S | ||
| misc_64.S | ||
| module.c | ||
| module_32.c | ||
| module_64.c | ||
| msi.c | ||
| note.S | ||
| nvram_64.c | ||
| of_platform.c | ||
| optprobes.c | ||
| optprobes_head.S | ||
| paca.c | ||
| pci-common.c | ||
| pci-hotplug.c | ||
| pci_32.c | ||
| pci_64.c | ||
| pci_dn.c | ||
| pci_of_scan.c | ||
| pmc.c | ||
| ppc_save_regs.S | ||
| proc_powerpc.c | ||
| process.c | ||
| prom.c | ||
| prom_entry_64.S | ||
| prom_init.c | ||
| prom_init_check.sh | ||
| prom_parse.c | ||
| reloc_32.S | ||
| reloc_64.S | ||
| rtas-proc.c | ||
| rtas-rtc.c | ||
| rtas.c | ||
| rtas_entry.S | ||
| rtas_flash.c | ||
| rtas_pci.c | ||
| rtasd.c | ||
| secure_boot.c | ||
| security.c | ||
| secvar-ops.c | ||
| secvar-sysfs.c | ||
| setup-common.c | ||
| setup.h | ||
| setup_32.c | ||
| setup_64.c | ||
| signal.c | ||
| signal.h | ||
| signal_32.c | ||
| signal_64.c | ||
| smp-tbsync.c | ||
| smp.c | ||
| stacktrace.c | ||
| static_call.c | ||
| suspend.c | ||
| switch.S | ||
| swsusp.c | ||
| swsusp_32.S | ||
| swsusp_64.c | ||
| swsusp_85xx.S | ||
| swsusp_asm64.S | ||
| sys_ppc32.c | ||
| syscall.c | ||
| syscalls.c | ||
| sysfs.c | ||
| systbl.c | ||
| tau_6xx.c | ||
| time.c | ||
| tm.S | ||
| traps.c | ||
| ucall.S | ||
| udbg.c | ||
| udbg_16550.c | ||
| uprobes.c | ||
| vdso.c | ||
| vdso32_wrapper.S | ||
| vdso64_wrapper.S | ||
| vecemu.c | ||
| vector.S | ||
| vmlinux.lds.S | ||
| watchdog.c | ||