linux/net/mptcp
Matthieu Baerts (NGI0) e598d8981f mptcp: blackhole only if 1st SYN retrans w/o MPC is accepted
The Fixes commit mentioned this:

> An MPTCP firewall blackhole can be detected if the following SYN
> retransmission after a fallback to "plain" TCP is accepted.

But in fact, this blackhole was detected if any following SYN
retransmissions after a fallback to TCP was accepted.

That's because 'mptcp_subflow_early_fallback()' will set 'request_mptcp'
to 0, and 'mpc_drop' will never be reset to 0 after.

This is an issue, because some not so unusual situations might cause the
kernel to detect a false-positive blackhole, e.g. a client trying to
connect to a server while the network is not ready yet, causing a few
SYN retransmissions, before reaching the end server.

Fixes: 27069e7cb3 ("mptcp: disable active MPTCP in case of blackhole")
Cc: stable@vger.kernel.org
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2025-01-30 14:02:19 +01:00
..
bpf.c
crypto.c move asm/unaligned.h to linux/unaligned.h 2024-10-02 17:23:23 -04:00
crypto_test.c
ctrl.c mptcp: blackhole only if 1st SYN retrans w/o MPC is accepted 2025-01-30 14:02:19 +01:00
diag.c mptcp: annotate data-races around subflow->fully_established 2024-10-28 15:55:45 -07:00
fastopen.c mptcp: pr_debug: add missing \n at the end 2024-08-27 14:45:16 -07:00
Kconfig
Makefile
mib.c mptcp: prevent MPC handshake on port-based signal endpoints 2024-10-15 10:57:02 -07:00
mib.h mptcp: prevent MPC handshake on port-based signal endpoints 2024-10-15 10:57:02 -07:00
mptcp_diag.c
mptcp_pm_gen.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2024-11-07 13:44:16 -08:00
mptcp_pm_gen.h
options.c mptcp: consolidate suboption status 2025-01-27 15:07:02 -08:00
pm.c mptcp: implement mptcp_pm_connection_closed 2024-10-28 15:55:45 -07:00
pm_netlink.c mptcp: pm: only set fullmesh for subflow endp 2025-01-27 15:07:02 -08:00
pm_userspace.c mptcp: fix for setting remote ipv4mapped address 2025-01-15 13:19:04 -08:00
protocol.c mptcp: handle fastopen disconnect correctly 2025-01-27 15:07:02 -08:00
protocol.h mptcp: consolidate suboption status 2025-01-27 15:07:02 -08:00
sched.c mptcp: remove unneeded lock when listing scheds 2024-11-05 17:54:39 -08:00
sockopt.c mptcp: pr_debug: add missing \n at the end 2024-08-27 14:45:16 -07:00
subflow.c mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone() 2024-11-09 09:09:07 -08:00
syncookies.c
token.c
token_test.c