mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
bd9b51e79c
As it is, default ->i_fop has NULL ->open() (along with all other methods). The only case where it matters is reopening (via procfs symlink) a file that didn't get its ->f_op from ->i_fop - anything else will have ->i_fop assigned to something sane (default would fail on read/write/ioctl/etc.). Unfortunately, such case exists - alloc_file() users, especially anon_get_file() ones. There we have tons of opened files of very different kinds sharing the same inode. As the result, attempt to reopen those via procfs succeeds and you get a descriptor you can't do anything with. Moreover, in case of sockets we set ->i_fop that will only be used on such reopen attempts - and put a failing ->open() into it to make sure those do not succeed. It would be simpler to put such ->open() into default ->i_fop and leave it unchanged both for anon inode (as we do anyway) and for socket ones. Result: * everything going through do_dentry_open() works as it used to * sock_no_open() kludge is gone * attempts to reopen anon-inode files fail as they really ought to * ditto for aio_private_file() * ditto for perfmon - this one actually tried to imitate sock_no_open() trick, but failed to set ->i_fop, so in the current tree reopens succeed and yield completely useless descriptor. Intent clearly had been to fail with -ENXIO on such reopens; now it actually does. * everything else that used alloc_file() keeps working - it has ->i_fop set for its inodes anyway Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| acpi-ext.c | ||
| acpi.c | ||
| asm-offsets.c | ||
| audit.c | ||
| brl_emu.c | ||
| crash.c | ||
| crash_dump.c | ||
| cyclone.c | ||
| dma-mapping.c | ||
| efi.c | ||
| efi_stub.S | ||
| elfcore.c | ||
| entry.h | ||
| entry.S | ||
| err_inject.c | ||
| esi.c | ||
| esi_stub.S | ||
| fsys.S | ||
| fsyscall_gtod_data.h | ||
| ftrace.c | ||
| gate-data.S | ||
| gate.lds.S | ||
| gate.S | ||
| head.S | ||
| ia64_ksyms.c | ||
| init_task.c | ||
| iosapic.c | ||
| irq.c | ||
| irq_ia64.c | ||
| irq_lsapic.c | ||
| ivt.S | ||
| jprobes.S | ||
| kprobes.c | ||
| machine_kexec.c | ||
| machvec.c | ||
| Makefile | ||
| Makefile.gate | ||
| mca.c | ||
| mca_asm.S | ||
| mca_drv.c | ||
| mca_drv.h | ||
| mca_drv_asm.S | ||
| minstate.h | ||
| module.c | ||
| msi_ia64.c | ||
| nr-irqs.c | ||
| numa.c | ||
| pal.S | ||
| palinfo.c | ||
| paravirt.c | ||
| paravirt_inst.h | ||
| paravirt_patch.c | ||
| paravirt_patchlist.c | ||
| paravirt_patchlist.h | ||
| paravirtentry.S | ||
| patch.c | ||
| pci-dma.c | ||
| pci-swiotlb.c | ||
| perfmon.c | ||
| perfmon_default_smpl.c | ||
| perfmon_generic.h | ||
| perfmon_itanium.h | ||
| perfmon_mckinley.h | ||
| perfmon_montecito.h | ||
| process.c | ||
| ptrace.c | ||
| relocate_kernel.S | ||
| sal.c | ||
| salinfo.c | ||
| setup.c | ||
| sigframe.h | ||
| signal.c | ||
| smp.c | ||
| smpboot.c | ||
| stacktrace.c | ||
| sys_ia64.c | ||
| time.c | ||
| topology.c | ||
| traps.c | ||
| unaligned.c | ||
| uncached.c | ||
| unwind.c | ||
| unwind_decoder.c | ||
| unwind_i.h | ||
| vmlinux.lds.S | ||