public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-05-24 10:39:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
linux/drivers/net/ethernet/intel/i40e
History
Stefan Assmann b6f23d3817 i40e: always propagate error value in i40e_set_vsi_promisc() 
The for loop in i40e_set_vsi_promisc() reports errors via dev_err() but
does not propagate the error up the call chain. Instead it continues the
loop and potentially overwrites the reported error value.
This results in the error being recorded in the log buffer, but the
caller might never know anything went the wrong way.

To avoid this situation i40e_set_vsi_promisc() needs to temporarily store
the error after reporting it. This is still not optimal as multiple
different errors may occur, so store the first error and hope that's
the main issue.

Fixes: 37d318d780 (i40e: Remove scheduling while atomic possibility)
Reported-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2020-09-09 15:06:24 -07:00
..
i40e.h i40e: Add support for a new feature Total Port Shutdown 2020-07-01 14:17:16 -07:00
i40e_adminq.c ethernet/intel: Convert fallthrough code comments 2020-07-01 13:47:43 -07:00
i40e_adminq.h
i40e_adminq_cmd.h i40e: Set RX_ONLY mode for unicast promiscuous on VLAN 2020-08-14 15:05:05 -07:00
i40e_alloc.h
i40e_client.c i40e: Move client header location 2020-06-25 22:25:13 -07:00
i40e_common.c i40e: Set RX_ONLY mode for unicast promiscuous on VLAN 2020-08-14 15:05:05 -07:00
i40e_dcb.c i40e: Fix for persistent lldp support 2019-10-25 13:38:19 -07:00
i40e_dcb.h i40e: remove unused defines 2020-06-25 22:25:13 -07:00
i40e_dcb_nl.c
i40e_ddp.c
i40e_debugfs.c i40e: introduce new dump desc XDP command 2020-07-01 14:44:17 -07:00
i40e_devids.h i40e: Add support for 5Gbps cards 2020-06-25 22:25:13 -07:00
i40e_diag.c
i40e_diag.h
i40e_ethtool.c i40e: Add support for a new feature Total Port Shutdown 2020-07-01 14:17:16 -07:00
i40e_hmc.c i40e: Implement debug macro hw_dbg using dev_dbg 2019-09-09 11:22:20 -07:00
i40e_hmc.h i40e: remove unused defines 2020-06-25 22:25:13 -07:00
i40e_lan_hmc.c treewide: Use sizeof_field() macro 2019-12-09 10:36:44 -08:00
i40e_lan_hmc.h
i40e_main.c i40e: Fix crash during removing i40e driver 2020-08-14 15:05:21 -07:00
i40e_nvm.c i40e: Fix for persistent lldp support 2019-10-25 13:38:19 -07:00
i40e_osdep.h i40e: remove unused defines 2020-06-25 22:25:13 -07:00
i40e_prototype.h i40e: Make i40e_shutdown_adminq() return void 2020-05-28 20:19:47 -07:00
i40e_ptp.c ethernet/intel: Convert fallthrough code comments 2020-07-01 13:47:43 -07:00
i40e_register.h i40e: detect and log info about pre-recovery mode 2020-06-25 22:25:13 -07:00
i40e_status.h
i40e_trace.h
i40e_txrx.c i40e: eliminate division in napi_poll data path 2020-07-01 14:27:11 -07:00
i40e_txrx.h i40e: optimize AF_XDP Tx completion path 2020-07-01 14:24:14 -07:00
i40e_txrx_common.h i40e: Separate kernel allocated rx_bi rings from AF_XDP rings 2020-05-21 17:31:26 -07:00
i40e_type.h i40e: remove unused defines 2020-06-25 22:25:13 -07:00
i40e_virtchnl_pf.c i40e: always propagate error value in i40e_set_vsi_promisc() 2020-09-09 15:06:24 -07:00
i40e_virtchnl_pf.h i40e: remove unused defines 2020-06-25 22:25:13 -07:00
i40e_xsk.c i40e: move check of full Tx ring to outside of send loop 2020-07-01 14:31:41 -07:00
i40e_xsk.h i40e: optimize AF_XDP Tx completion path 2020-07-01 14:24:14 -07:00
Makefile