mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-18 22:14:16 +00:00
a4543e21ae
This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commitefb0cb50c4("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid Fixes:ccd3517faf("arm64: dts: qcom: sc8280xp: Add reference device") Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Andrew Halaney <ahalaney@redhat.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20220829094903.v2.3.Ie7d2c50d2b42ef2d364f3a0c8e300e5ce1875b79@changeid
440 lines
8.2 KiB
Text
440 lines
8.2 KiB
Text
// SPDX-License-Identifier: BSD-3-Clause
|
|
/*
|
|
* Copyright (c) 2021, The Linux Foundation. All rights reserved.
|
|
* Copyright (c) 2022, Linaro Limited
|
|
*/
|
|
|
|
/dts-v1/;
|
|
|
|
#include <dt-bindings/gpio/gpio.h>
|
|
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
|
|
|
|
#include "sc8280xp.dtsi"
|
|
#include "sc8280xp-pmics.dtsi"
|
|
|
|
/ {
|
|
model = "Qualcomm SC8280XP CRD";
|
|
compatible = "qcom,sc8280xp-crd", "qcom,sc8280xp";
|
|
|
|
aliases {
|
|
serial0 = &qup2_uart17;
|
|
};
|
|
|
|
backlight {
|
|
compatible = "pwm-backlight";
|
|
pwms = <&pmc8280c_lpg 3 1000000>;
|
|
enable-gpios = <&pmc8280_1_gpios 8 GPIO_ACTIVE_HIGH>;
|
|
power-supply = <&vreg_edp_bl>;
|
|
|
|
pinctrl-names = "default";
|
|
pinctrl-0 = <&edp_bl_en>, <&edp_bl_pwm>;
|
|
};
|
|
|
|
chosen {
|
|
stdout-path = "serial0:115200n8";
|
|
};
|
|
|
|
vreg_edp_bl: regulator-edp-bl {
|
|
compatible = "regulator-fixed";
|
|
|
|
regulator-name = "VREG_EDP_BL";
|
|
regulator-min-microvolt = <3600000>;
|
|
regulator-max-microvolt = <3600000>;
|
|
|
|
gpio = <&pmc8280_1_gpios 9 GPIO_ACTIVE_HIGH>;
|
|
enable-active-high;
|
|
|
|
pinctrl-names = "default";
|
|
pinctrl-0 = <&edp_bl_reg_en>;
|
|
|
|
regulator-boot-on;
|
|
};
|
|
|
|
vreg_misc_3p3: regulator-misc-3p3 {
|
|
compatible = "regulator-fixed";
|
|
|
|
regulator-name = "VREG_MISC_3P3";
|
|
regulator-min-microvolt = <3300000>;
|
|
regulator-max-microvolt = <3300000>;
|
|
|
|
gpio = <&pmc8280_1_gpios 1 GPIO_ACTIVE_HIGH>;
|
|
enable-active-high;
|
|
|
|
pinctrl-names = "default";
|
|
pinctrl-0 = <&misc_3p3_reg_en>;
|
|
|
|
regulator-boot-on;
|
|
regulator-always-on;
|
|
};
|
|
};
|
|
|
|
&apps_rsc {
|
|
pmc8280-1-rpmh-regulators {
|
|
compatible = "qcom,pm8350-rpmh-regulators";
|
|
qcom,pmic-id = "b";
|
|
|
|
vdd-l3-l5-supply = <&vreg_s11b>;
|
|
|
|
vreg_s11b: smps11 {
|
|
regulator-name = "vreg_s11b";
|
|
regulator-min-microvolt = <1272000>;
|
|
regulator-max-microvolt = <1272000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
};
|
|
|
|
vreg_l3b: ldo3 {
|
|
regulator-name = "vreg_l3b";
|
|
regulator-min-microvolt = <1200000>;
|
|
regulator-max-microvolt = <1200000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
regulator-boot-on;
|
|
regulator-always-on;
|
|
};
|
|
|
|
vreg_l4b: ldo4 {
|
|
regulator-name = "vreg_l4b";
|
|
regulator-min-microvolt = <912000>;
|
|
regulator-max-microvolt = <912000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
};
|
|
|
|
vreg_l6b: ldo6 {
|
|
regulator-name = "vreg_l6b";
|
|
regulator-min-microvolt = <880000>;
|
|
regulator-max-microvolt = <880000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
regulator-boot-on;
|
|
};
|
|
};
|
|
|
|
pmc8280c-rpmh-regulators {
|
|
compatible = "qcom,pm8350c-rpmh-regulators";
|
|
qcom,pmic-id = "c";
|
|
|
|
vreg_l1c: ldo1 {
|
|
regulator-name = "vreg_l1c";
|
|
regulator-min-microvolt = <1800000>;
|
|
regulator-max-microvolt = <1800000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
};
|
|
|
|
vreg_l7c: ldo7 {
|
|
regulator-name = "vreg_l7c";
|
|
regulator-min-microvolt = <2504000>;
|
|
regulator-max-microvolt = <2504000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
regulator-allow-set-load;
|
|
regulator-allowed-modes =
|
|
<RPMH_REGULATOR_MODE_LPM
|
|
RPMH_REGULATOR_MODE_HPM>;
|
|
};
|
|
|
|
vreg_l13c: ldo13 {
|
|
regulator-name = "vreg_l13c";
|
|
regulator-min-microvolt = <3072000>;
|
|
regulator-max-microvolt = <3072000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
};
|
|
};
|
|
|
|
pmc8280-2-rpmh-regulators {
|
|
compatible = "qcom,pm8350-rpmh-regulators";
|
|
qcom,pmic-id = "d";
|
|
|
|
vdd-l1-l4-supply = <&vreg_s11b>;
|
|
|
|
vreg_l3d: ldo3 {
|
|
regulator-name = "vreg_l3d";
|
|
regulator-min-microvolt = <1200000>;
|
|
regulator-max-microvolt = <1200000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
regulator-allow-set-load;
|
|
regulator-allowed-modes =
|
|
<RPMH_REGULATOR_MODE_LPM
|
|
RPMH_REGULATOR_MODE_HPM>;
|
|
};
|
|
|
|
vreg_l4d: ldo4 {
|
|
regulator-name = "vreg_l4d";
|
|
regulator-min-microvolt = <1200000>;
|
|
regulator-max-microvolt = <1200000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
};
|
|
|
|
vreg_l6d: ldo6 {
|
|
regulator-name = "vreg_l6d";
|
|
regulator-min-microvolt = <880000>;
|
|
regulator-max-microvolt = <880000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
};
|
|
|
|
vreg_l7d: ldo7 {
|
|
regulator-name = "vreg_l7d";
|
|
regulator-min-microvolt = <3072000>;
|
|
regulator-max-microvolt = <3072000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
};
|
|
|
|
vreg_l9d: ldo9 {
|
|
regulator-name = "vreg_l9d";
|
|
regulator-min-microvolt = <912000>;
|
|
regulator-max-microvolt = <912000>;
|
|
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
|
|
};
|
|
};
|
|
};
|
|
|
|
&pmc8280c_lpg {
|
|
status = "okay";
|
|
};
|
|
|
|
&pmk8280_pon_pwrkey {
|
|
status = "okay";
|
|
};
|
|
|
|
&qup0 {
|
|
status = "okay";
|
|
};
|
|
|
|
&qup0_i2c4 {
|
|
clock-frequency = <400000>;
|
|
|
|
pinctrl-names = "default";
|
|
pinctrl-0 = <&qup0_i2c4_default>;
|
|
|
|
status = "okay";
|
|
|
|
touchscreen@10 {
|
|
compatible = "hid-over-i2c";
|
|
reg = <0x10>;
|
|
|
|
hid-descr-addr = <0x1>;
|
|
interrupts-extended = <&tlmm 175 IRQ_TYPE_LEVEL_LOW>;
|
|
vdd-supply = <&vreg_misc_3p3>;
|
|
|
|
pinctrl-names = "default";
|
|
pinctrl-0 = <&ts0_default>;
|
|
};
|
|
};
|
|
|
|
&qup1 {
|
|
status = "okay";
|
|
};
|
|
|
|
&qup2 {
|
|
status = "okay";
|
|
};
|
|
|
|
&qup2_i2c5 {
|
|
clock-frequency = <400000>;
|
|
|
|
pinctrl-names = "default";
|
|
pinctrl-0 = <&qup2_i2c5_default>;
|
|
|
|
status = "okay";
|
|
|
|
touchpad@15 {
|
|
compatible = "hid-over-i2c";
|
|
reg = <0x15>;
|
|
|
|
hid-descr-addr = <0x1>;
|
|
interrupts-extended = <&tlmm 182 IRQ_TYPE_LEVEL_LOW>;
|
|
vdd-supply = <&vreg_misc_3p3>;
|
|
|
|
pinctrl-names = "default";
|
|
pinctrl-0 = <&tpad_default>;
|
|
|
|
wakeup-source;
|
|
};
|
|
|
|
keyboard@68 {
|
|
compatible = "hid-over-i2c";
|
|
reg = <0x68>;
|
|
|
|
hid-descr-addr = <0x1>;
|
|
interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>;
|
|
vdd-supply = <&vreg_misc_3p3>;
|
|
|
|
pinctrl-names = "default";
|
|
pinctrl-0 = <&kybd_default>;
|
|
|
|
wakeup-source;
|
|
};
|
|
};
|
|
|
|
&qup2_uart17 {
|
|
compatible = "qcom,geni-debug-uart";
|
|
|
|
status = "okay";
|
|
};
|
|
|
|
&remoteproc_adsp {
|
|
firmware-name = "qcom/sc8280xp/qcadsp8280.mbn";
|
|
|
|
status = "okay";
|
|
};
|
|
|
|
&remoteproc_nsp0 {
|
|
firmware-name = "qcom/sc8280xp/qccdsp8280.mbn";
|
|
|
|
status = "okay";
|
|
};
|
|
|
|
&ufs_mem_hc {
|
|
reset-gpios = <&tlmm 228 GPIO_ACTIVE_LOW>;
|
|
|
|
vcc-supply = <&vreg_l7c>;
|
|
vcc-max-microamp = <800000>;
|
|
vccq-supply = <&vreg_l3d>;
|
|
vccq-max-microamp = <900000>;
|
|
|
|
status = "okay";
|
|
};
|
|
|
|
&ufs_mem_phy {
|
|
vdda-phy-supply = <&vreg_l6b>;
|
|
vdda-pll-supply = <&vreg_l3b>;
|
|
|
|
status = "okay";
|
|
};
|
|
|
|
&usb_0 {
|
|
status = "okay";
|
|
};
|
|
|
|
&usb_0_dwc3 {
|
|
/* TODO: Define USB-C connector properly */
|
|
dr_mode = "host";
|
|
};
|
|
|
|
&usb_0_hsphy {
|
|
vdda-pll-supply = <&vreg_l9d>;
|
|
vdda18-supply = <&vreg_l1c>;
|
|
vdda33-supply = <&vreg_l7d>;
|
|
|
|
status = "okay";
|
|
};
|
|
|
|
&usb_0_qmpphy {
|
|
vdda-phy-supply = <&vreg_l9d>;
|
|
vdda-pll-supply = <&vreg_l4d>;
|
|
|
|
status = "okay";
|
|
};
|
|
|
|
&usb_1 {
|
|
status = "okay";
|
|
};
|
|
|
|
&usb_1_dwc3 {
|
|
/* TODO: Define USB-C connector properly */
|
|
dr_mode = "host";
|
|
};
|
|
|
|
&usb_1_hsphy {
|
|
vdda-pll-supply = <&vreg_l4b>;
|
|
vdda18-supply = <&vreg_l1c>;
|
|
vdda33-supply = <&vreg_l13c>;
|
|
|
|
status = "okay";
|
|
};
|
|
|
|
&usb_1_qmpphy {
|
|
vdda-phy-supply = <&vreg_l4b>;
|
|
vdda-pll-supply = <&vreg_l3b>;
|
|
|
|
status = "okay";
|
|
};
|
|
|
|
&xo_board_clk {
|
|
clock-frequency = <38400000>;
|
|
};
|
|
|
|
/* PINCTRL - additions to nodes defined in sc8280xp.dtsi */
|
|
|
|
&pmc8280_1_gpios {
|
|
edp_bl_en: edp-bl-en-state {
|
|
pins = "gpio8";
|
|
function = "normal";
|
|
};
|
|
|
|
edp_bl_reg_en: edp-bl-reg-en-state {
|
|
pins = "gpio9";
|
|
function = "normal";
|
|
};
|
|
|
|
misc_3p3_reg_en: misc-3p3-reg-en-state {
|
|
pins = "gpio1";
|
|
function = "normal";
|
|
};
|
|
};
|
|
|
|
&pmc8280c_gpios {
|
|
edp_bl_pwm: edp-bl-pwm-state {
|
|
pins = "gpio8";
|
|
function = "func1";
|
|
};
|
|
};
|
|
|
|
&tlmm {
|
|
gpio-reserved-ranges = <74 6>, <83 4>, <125 2>, <128 2>, <154 7>;
|
|
|
|
kybd_default: kybd-default-state {
|
|
disable {
|
|
pins = "gpio102";
|
|
function = "gpio";
|
|
output-low;
|
|
};
|
|
|
|
int-n {
|
|
pins = "gpio104";
|
|
function = "gpio";
|
|
bias-disable;
|
|
};
|
|
|
|
reset {
|
|
pins = "gpio105";
|
|
function = "gpio";
|
|
bias-disable;
|
|
};
|
|
};
|
|
|
|
qup0_i2c4_default: qup0-i2c4-default-state {
|
|
pins = "gpio171", "gpio172";
|
|
function = "qup4";
|
|
|
|
bias-disable;
|
|
drive-strength = <16>;
|
|
};
|
|
|
|
qup2_i2c5_default: qup2-i2c5-default-state {
|
|
pins = "gpio81", "gpio82";
|
|
function = "qup21";
|
|
|
|
bias-disable;
|
|
drive-strength = <16>;
|
|
};
|
|
|
|
tpad_default: tpad-default-state {
|
|
int-n {
|
|
pins = "gpio182";
|
|
function = "gpio";
|
|
bias-disable;
|
|
};
|
|
};
|
|
|
|
ts0_default: ts0-default-state {
|
|
int-n {
|
|
pins = "gpio175";
|
|
function = "gpio";
|
|
bias-disable;
|
|
};
|
|
|
|
reset-n {
|
|
pins = "gpio99";
|
|
function = "gpio";
|
|
output-high;
|
|
drive-strength = <16>;
|
|
};
|
|
};
|
|
};
|