Vladimir Oltean 56378f3ccb net: dsa: make user ports return to init_net on netns deletion ... As pointed out during review, currently the following set of commands crashes the kernel: $ ip netns add ns0 $ ip link set swp0 netns ns0 $ ip netns del ns0 WARNING: CPU: 1 PID: 27 at net/core/dev.c:10884 unregister_netdevice_many+0xaa4/0xaec Workqueue: netns cleanup_net pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : unregister_netdevice_many+0xaa4/0xaec lr : unregister_netdevice_many+0x700/0xaec Call trace: unregister_netdevice_many+0xaa4/0xaec default_device_exit_batch+0x294/0x340 ops_exit_list+0xac/0xc4 cleanup_net+0x2e4/0x544 process_one_work+0x4ec/0xb40 ---[ end trace 0000000000000000 ]--- unregister_netdevice: waiting for swp0 to become free. Usage count = 2 This is because since DSA user ports, since they started populating dev->rtnl_link_ops in the blamed commit, gained a different treatment from default_device_exit_net(), which thinks these interfaces can now be unregistered. They can't; so set netns_refund = true to restore the behavior prior to populating dev->rtnl_link_ops. Fixes: 95f510d0b7 ("net: dsa: allow the DSA master to be seen and changed through rtnetlink") Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Link: https://lore.kernel.org/r/20220921185428.1767001-1-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2022-09-26 11:28:57 -07:00
..
dsa.c	net: dsa: allow the DSA master to be seen and changed through rtnetlink	2022-09-20 10:32:35 +02:00
dsa2.c	net: dsa: don't keep track of admin/oper state on LAG DSA masters	2022-09-20 10:32:35 +02:00
dsa_priv.h	net: dsa: allow masters to join a LAG	2022-09-20 10:32:36 +02:00
Kconfig
Makefile	net: dsa: allow the DSA master to be seen and changed through rtnetlink	2022-09-20 10:32:35 +02:00
master.c	net: dsa: allow masters to join a LAG	2022-09-20 10:32:36 +02:00
netlink.c	net: dsa: make user ports return to init_net on netns deletion	2022-09-26 11:28:57 -07:00
port.c	net: dsa: allow masters to join a LAG	2022-09-20 10:32:36 +02:00
slave.c	net: dsa: allow masters to join a LAG	2022-09-20 10:32:36 +02:00
switch.c	net: dsa: allow masters to join a LAG	2022-09-20 10:32:36 +02:00
tag_8021q.c	net: dsa: introduce dsa_port_get_master()	2022-09-20 10:32:35 +02:00
tag_ar9331.c
tag_brcm.c
tag_dsa.c
tag_gswip.c
tag_hellcreek.c	net: dsa: hellcreek: Print warning only once	2022-08-31 19:54:04 -07:00
tag_ksz.c
tag_lan9303.c
tag_mtk.c
tag_ocelot.c
tag_ocelot_8021q.c
tag_qca.c
tag_rtl4_a.c
tag_rtl8_4.c
tag_rzn1_a5psw.c
tag_sja1105.c
tag_trailer.c
tag_xrs700x.c