mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
ac5d44fbf3
Building the amd display driver with link-time optimizations revealed a bug
that caused dal_cmd_tbl_helper_dce80_get_table() and
dal_cmd_tbl_helper_dce110_get_table() get called with an incompatible
return type between the two callers in command_table_helper.c and
command_table_helper2.c:
drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.h:31: error: type of 'dal_cmd_tbl_helper_dce80_get_table' does not match original declaration [-Werror=lto-type-mismatch]
const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table(void);
drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351: note: 'dal_cmd_tbl_helper_dce80_get_table' was previously declared here
const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table(void)
drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce110/command_table_helper_dce110.h:32: error: type of 'dal_cmd_tbl_helper_dce110_get_table' does not match original declaration [-Werror=lto-type-mismatch]
const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table(void);
drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce110/command_table_helper_dce110.c:361: note: 'dal_cmd_tbl_helper_dce110_get_table' was previously declared here
const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table(void)
The two versions of the structure are obviously derived from the same
one, but have diverged over time, before they got added to the kernel.
This moves the structure to a new shared header file and uses the superset
of the members, to ensure the interfaces are all compatible.
Fixes:
|
||
|---|---|---|
| .. | ||
| dce80 | ||
| dce110 | ||
| dce112 | ||
| bios_parser.c | ||
| bios_parser.h | ||
| bios_parser2.c | ||
| bios_parser2.h | ||
| bios_parser_common.c | ||
| bios_parser_common.h | ||
| bios_parser_helper.c | ||
| bios_parser_helper.h | ||
| bios_parser_interface.c | ||
| bios_parser_types_internal.h | ||
| bios_parser_types_internal2.h | ||
| command_table.c | ||
| command_table.h | ||
| command_table2.c | ||
| command_table2.h | ||
| command_table_helper.c | ||
| command_table_helper.h | ||
| command_table_helper2.c | ||
| command_table_helper2.h | ||
| command_table_helper_struct.h | ||
| Makefile | ||