mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-18 22:14:16 +00:00
078d3ee7c1
According to CXL r3.2 section 8.2.1.2, the PCI_COMMAND register fields,
including Memory Space Enable bit, have no effect on the behavior of an
RCD Upstream Port. Retaining this check may incorrectly cause
cxl_pci_probe() to fail on a valid RCD upstream Port.
While the specification is explicit only for RCD Upstream Ports, this
check is solely for accessing the RCRB, which is always mapped through
memory space. Therefore, its safe to remove the check entirely. In
practice, firmware reliably enables the Memory Space Enable bit for
RCH Downstream Ports and no failures have been observed.
Removing the check simplifies the code and avoids unnecessary
special-casing, while relying on BIOS/firmware to configure devices
correctly. Moreover, any failures due to inaccessible RCRB regions
will still be caught either in __rcrb_to_component() or while
parsing the component register block.
The following failure was observed in dmesg when the check was present:
cxl_pci 0000:7f:00.0: No component registers (-6)
Fixes:
|
||
|---|---|---|
| .. | ||
| acpi.c | ||
| cdat.c | ||
| core.h | ||
| features.c | ||
| hdm.c | ||
| Makefile | ||
| mbox.c | ||
| mce.c | ||
| mce.h | ||
| memdev.c | ||
| pci.c | ||
| pmem.c | ||
| pmu.c | ||
| port.c | ||
| ras.c | ||
| region.c | ||
| regs.c | ||
| suspend.c | ||
| trace.c | ||
| trace.h | ||