mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-04 08:17:46 +00:00
a0386bba70
The value returned by an spi driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Jérôme Pouiller <jerome.pouiller@silabs.com> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Acked-by: Claudius Heine <ch@denx.de> Acked-by: Stefan Schmidt <stefan@datenfreihafen.org> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-by: Ulf Hansson <ulf.hansson@linaro.org> # For MMC Acked-by: Marcus Folkesson <marcus.folkesson@gmail.com> Acked-by: Łukasz Stelmach <l.stelmach@samsung.com> Acked-by: Lee Jones <lee.jones@linaro.org> Link: https://lore.kernel.org/r/20220123175201.34839-6-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
120 lines
2.7 KiB
C
120 lines
2.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Microchip KSZ9477 series register access through SPI
|
|
*
|
|
* Copyright (C) 2017-2019 Microchip Technology Inc.
|
|
*/
|
|
|
|
#include <asm/unaligned.h>
|
|
|
|
#include <linux/delay.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/spi/spi.h>
|
|
|
|
#include "ksz_common.h"
|
|
|
|
#define SPI_ADDR_SHIFT 24
|
|
#define SPI_ADDR_ALIGN 3
|
|
#define SPI_TURNAROUND_SHIFT 5
|
|
|
|
KSZ_REGMAP_TABLE(ksz9477, 32, SPI_ADDR_SHIFT,
|
|
SPI_TURNAROUND_SHIFT, SPI_ADDR_ALIGN);
|
|
|
|
static int ksz9477_spi_probe(struct spi_device *spi)
|
|
{
|
|
struct regmap_config rc;
|
|
struct ksz_device *dev;
|
|
int i, ret;
|
|
|
|
dev = ksz_switch_alloc(&spi->dev, spi);
|
|
if (!dev)
|
|
return -ENOMEM;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(ksz9477_regmap_config); i++) {
|
|
rc = ksz9477_regmap_config[i];
|
|
rc.lock_arg = &dev->regmap_mutex;
|
|
dev->regmap[i] = devm_regmap_init_spi(spi, &rc);
|
|
if (IS_ERR(dev->regmap[i])) {
|
|
ret = PTR_ERR(dev->regmap[i]);
|
|
dev_err(&spi->dev,
|
|
"Failed to initialize regmap%i: %d\n",
|
|
ksz9477_regmap_config[i].val_bits, ret);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
if (spi->dev.platform_data)
|
|
dev->pdata = spi->dev.platform_data;
|
|
|
|
/* setup spi */
|
|
spi->mode = SPI_MODE_3;
|
|
ret = spi_setup(spi);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = ksz9477_switch_register(dev);
|
|
|
|
/* Main DSA driver may not be started yet. */
|
|
if (ret)
|
|
return ret;
|
|
|
|
spi_set_drvdata(spi, dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void ksz9477_spi_remove(struct spi_device *spi)
|
|
{
|
|
struct ksz_device *dev = spi_get_drvdata(spi);
|
|
|
|
if (dev)
|
|
ksz_switch_remove(dev);
|
|
|
|
spi_set_drvdata(spi, NULL);
|
|
}
|
|
|
|
static void ksz9477_spi_shutdown(struct spi_device *spi)
|
|
{
|
|
struct ksz_device *dev = spi_get_drvdata(spi);
|
|
|
|
if (dev)
|
|
dsa_switch_shutdown(dev->ds);
|
|
|
|
spi_set_drvdata(spi, NULL);
|
|
}
|
|
|
|
static const struct of_device_id ksz9477_dt_ids[] = {
|
|
{ .compatible = "microchip,ksz9477" },
|
|
{ .compatible = "microchip,ksz9897" },
|
|
{ .compatible = "microchip,ksz9893" },
|
|
{ .compatible = "microchip,ksz9563" },
|
|
{ .compatible = "microchip,ksz8563" },
|
|
{ .compatible = "microchip,ksz9567" },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, ksz9477_dt_ids);
|
|
|
|
static struct spi_driver ksz9477_spi_driver = {
|
|
.driver = {
|
|
.name = "ksz9477-switch",
|
|
.owner = THIS_MODULE,
|
|
.of_match_table = of_match_ptr(ksz9477_dt_ids),
|
|
},
|
|
.probe = ksz9477_spi_probe,
|
|
.remove = ksz9477_spi_remove,
|
|
.shutdown = ksz9477_spi_shutdown,
|
|
};
|
|
|
|
module_spi_driver(ksz9477_spi_driver);
|
|
|
|
MODULE_ALIAS("spi:ksz9477");
|
|
MODULE_ALIAS("spi:ksz9897");
|
|
MODULE_ALIAS("spi:ksz9893");
|
|
MODULE_ALIAS("spi:ksz9563");
|
|
MODULE_ALIAS("spi:ksz8563");
|
|
MODULE_ALIAS("spi:ksz9567");
|
|
MODULE_AUTHOR("Woojung Huh <Woojung.Huh@microchip.com>");
|
|
MODULE_DESCRIPTION("Microchip KSZ9477 Series Switch SPI access Driver");
|
|
MODULE_LICENSE("GPL");
|