Jon Maloy 988f3f1603 tipc: eliminate message disordering during binding table update ... We have seen the following race scenario: 1) named_distribute() builds a "bulk" message, containing a PUBLISH item for a certain publication. This is based on the contents of the binding tables's 'cluster_scope' list. 2) tipc_named_withdraw() removes the same publication from the list, bulds a WITHDRAW message and distributes it to all cluster nodes. 3) tipc_named_node_up(), which was calling named_distribute(), sends out the bulk message built under 1) 4) The WITHDRAW message arrives at the just detected node, finds no corresponding publication, and is dropped. 5) The PUBLISH item arrives at the same node, is added to its binding table, and remains there forever. This arrival disordering was earlier taken care of by the backlog queue, originally added for a different purpose, which was removed in the commit referred to below, but we now need a different solution. In this commit, we replace the rcu lock protecting the 'cluster_scope' list with a regular RW lock which comprises even the sending of the bulk message. This both guarantees both the list integrity and the message sending order. We will later add a commit which cleans up this code further. Note that this commit needs recently added commit d3092b2efc ("tipc: fix unsafe rcu locking when accessing publication list") to apply cleanly. Fixes: 37922ea4a3 ("tipc: permit overlapping service ranges in name table") Reported-by: Tuong Lien Tong <tuong.t.lien@dektech.com.au> Acked-by: Ying Xue <ying.xue@windriver.com> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-10-22 19:29:12 -07:00
..
addr.c
addr.h
bcast.c	tipc: correct spelling errors for struct tipc_bc_base's comment	2018-09-03 22:03:07 -07:00
bcast.h
bearer.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-03 21:00:17 -07:00
bearer.h
core.c
core.h
diag.c	tipc: switch to rhashtable iterator	2018-08-29 18:04:54 -07:00
discover.c
discover.h
eth_media.c
group.c	tipc: fix info leak from kernel tipc_event	2018-10-18 16:49:53 -07:00
group.h
ib_media.c
Kconfig
link.c	tipc: initialize broadcast link stale counter correctly	2018-10-15 22:03:34 -07:00
link.h	tipc: fix failover problem	2018-09-29 11:45:14 -07:00
Makefile
monitor.c
monitor.h
msg.c	tipc: buffer overflow handling in listener socket	2018-09-29 11:24:22 -07:00
msg.h	tipc: buffer overflow handling in listener socket	2018-09-29 11:24:22 -07:00
name_distr.c	tipc: eliminate message disordering during binding table update	2018-10-22 19:29:12 -07:00
name_distr.h
name_table.c	tipc: eliminate message disordering during binding table update	2018-10-22 19:29:12 -07:00
name_table.h	tipc: eliminate message disordering during binding table update	2018-10-22 19:29:12 -07:00
net.c
net.h
netlink.c	tipc: switch to rhashtable iterator	2018-08-29 18:04:54 -07:00
netlink.h
netlink_compat.c	tipc: check return value of __tipc_dump_start()	2018-09-12 13:15:04 -07:00
node.c	tipc: ignore STATE_MSG on wrong link session	2018-10-01 22:35:30 -07:00
node.h	tipc: add SYN bit to connection setup messages	2018-09-29 11:24:22 -07:00
socket.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-12 21:38:46 -07:00
socket.h	tipc: call start and done ops directly in __tipc_nl_compat_dumpit()	2018-09-06 21:49:18 -07:00
subscr.c
subscr.h
sysctl.c
topsrv.c	tipc: use destination length for copy string	2018-10-22 19:25:32 -07:00
topsrv.h
udp_media.c	tipc: support binding to specific ip address when activating UDP bearer	2018-10-15 21:56:56 -07:00
udp_media.h