Maxime Ripard 977697e20b drm/atomic: Pass the full state to planes atomic disable and update ... The current atomic helpers have either their object state being passed as an argument or the full atomic state. The former is the pattern that was done at first, before switching to the latter for new hooks or when it was needed. Let's convert the remaining helpers to provide a consistent interface, this time with the planes atomic_update and atomic_disable. The conversion was done using the coccinelle script below, built tested on all the drivers. @@ identifier plane, plane_state; symbol state; @@ struct drm_plane_helper_funcs { ... void (*atomic_update)(struct drm_plane *plane, - struct drm_plane_state *plane_state); + struct drm_atomic_state *state); ... } @@ identifier plane, plane_state; symbol state; @@ struct drm_plane_helper_funcs { ... void (*atomic_disable)(struct drm_plane *plane, - struct drm_plane_state *plane_state); + struct drm_atomic_state *state); ... } @ plane_atomic_func @ identifier helpers; identifier func; @@ ( static const struct drm_plane_helper_funcs helpers = { ..., .atomic_update = func, ..., }; | static const struct drm_plane_helper_funcs helpers = { ..., .atomic_disable = func, ..., }; ) @@ struct drm_plane_helper_funcs *FUNCS; identifier f; identifier crtc_state; identifier plane, plane_state, state; expression e; @@ f(struct drm_crtc_state *crtc_state) { ... struct drm_atomic_state *state = e; <+... ( - FUNCS->atomic_disable(plane, plane_state) + FUNCS->atomic_disable(plane, state) | - FUNCS->atomic_update(plane, plane_state) + FUNCS->atomic_update(plane, state) ) ...+> } @@ identifier plane_atomic_func.func; identifier plane; symbol state; @@ func(struct drm_plane *plane, - struct drm_plane_state *state) + struct drm_plane_state *old_plane_state) { <... - state + old_plane_state ...> } @ ignores_old_state @ identifier plane_atomic_func.func; identifier plane, old_state; @@ func(struct drm_plane *plane, struct drm_plane_state *old_state) { ... when != old_state } @ adds_old_state depends on plane_atomic_func && !ignores_old_state @ identifier plane_atomic_func.func; identifier plane, plane_state; @@ func(struct drm_plane *plane, struct drm_plane_state *plane_state) { + struct drm_plane_state *plane_state = drm_atomic_get_old_plane_state(state, plane); ... } @ depends on plane_atomic_func @ identifier plane_atomic_func.func; identifier plane, plane_state; @@ func(struct drm_plane *plane, - struct drm_plane_state *plane_state + struct drm_atomic_state *state ) { ... } @ include depends on adds_old_state @ @@ #include <drm/drm_atomic.h> @ no_include depends on !include && adds_old_state @ @@ + #include <drm/drm_atomic.h> #include <drm/...> @@ identifier plane_atomic_func.func; identifier plane, state; identifier plane_state; @@ func(struct drm_plane *plane, struct drm_atomic_state *state) { ... struct drm_plane_state *plane_state = drm_atomic_get_old_plane_state(state, plane); <+... - plane_state->state + state ...+> } Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://patchwork.freedesktop.org/patch/msgid/20210219120032.260676-9-maxime@cerno.tech		2021-02-25 08:05:28 +01:00
..
dcss	drm/atomic: Pass the full state to planes atomic disable and update	2021-02-25 08:05:28 +01:00
dw_hdmi-imx.c	drm/imx: dw_hdmi-imx: use drm managed resources	2021-01-04 12:59:33 +01:00
imx-drm-core.c	Merge drm/drm-next into drm-misc-next	2020-11-10 17:11:37 +01:00
imx-drm.h
imx-ldb.c	drm/imx: imx-ldb: use drm managed resources	2021-01-04 12:59:33 +01:00
imx-tve.c	drm/imx: imx-tve: use drm managed resources	2021-01-04 12:59:33 +01:00
ipuv3-crtc.c	drm/imx: ipuv3-crtc: use drm managed resources	2021-01-04 12:59:34 +01:00
ipuv3-plane.c	drm/atomic: Pass the full state to planes atomic disable and update	2021-02-25 08:05:28 +01:00
ipuv3-plane.h	drm/imx: ipuv3-plane: use drm managed resources	2021-01-04 12:59:34 +01:00
Kconfig	drm/imx: depend on COMMON_CLK to fix compile tests	2021-01-04 12:54:18 +01:00
Makefile	drm/imx: Add initial support for DCSS on iMX8MQ	2020-09-09 16:39:48 +02:00
parallel-display.c	drm/imx: parallel-display: use drm managed resources	2021-01-04 12:59:34 +01:00