Brian Norris 96f30c8f0a tools build: Correct libsubcmd fixdep dependencies ... All built targets need fixdep to be built first, before handling object dependencies [1]. We're missing one such dependency before the libsubcmd target. This resolves .cmd file generation issues such that the following sequence produces many fewer results: $ git clean -xfd tools/ $ make tools/objtool $ grep "cannot find fixdep" $(find tools/objtool -name '*.cmd') In particular, only a buggy tools/objtool/libsubcmd/.fixdep.o.cmd remains, due to circular dependencies of fixdep on itself. Such incomplete .cmd files don't usually cause a direct problem, since they're designed to fail "open", but they can cause some subtle problems that would otherwise be handled by proper fixdep'd dependency files. [2] [1] This problem is better described in commit abb26210a3 ("perf tools: Force fixdep compilation at the start of the build"). I don't apply its solution here, because additional recursive make can be a bit of overkill. [2] Example failure case: cp -arl linux-src linux-src2 cd linux-src2 make O=/path/to/out cd ../linux-src rm -rf ../linux-src2 make O=/path/to/out Previously, we'd see errors like: make[6]: *** No rule to make target '/path/to/linux-src2/tools/include/linux/compiler.h', needed by '/path/to/out/tools/bpf/resolve_btfids/libsubcmd/exec-cmd.o'. Stop. Now, the properly-fixdep'd .cmd files will ignore a missing /path/to/linux-src2/... Signed-off-by: Brian Norris <briannorris@chromium.org> Acked-by: Jiri Olsa <jolsa@kernel.org> Cc: Ian Rogers <irogers@google.com> Cc: Josh Poimboeuf <jpoimboe@kernel.org> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Richter <tmricht@linux.ibm.com> Link: https://lore.kernel.org/all/ZGVi9HbI43R5trN8@bhelgaas/ Link: https://lore.kernel.org/all/Zk-C5Eg84yt6_nml@google.com/ Link: https://lore.kernel.org/r/20240715203325.3832977-2-briannorris@chromium.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2024-08-05 12:08:29 -03:00
..
api	perf list: Give clues if failed to open tracing events directory	2024-08-01 12:11:33 -03:00
bpf	libbpf: Fix no-args func prototype BTF dumping syntax	2024-07-17 22:42:47 +02:00
perf	libperf: Add gitignore	2024-08-01 12:11:33 -03:00
subcmd	tools build: Correct libsubcmd fixdep dependencies	2024-08-05 12:08:29 -03:00
symbol
thermal
argv_split.c
bitmap.c	radix tree test suite: put definition of bitmap_clear() into lib/bitmap.c	2024-07-10 14:24:27 -07:00
ctype.c
find_bit.c
hweight.c
list_sort.c	tools/lib/list_sort: remove redundant code for cond_resched handling	2024-06-24 22:25:04 -07:00
rbtree.c	tools lib rbtree: pick some improvements from the kernel rbtree code	2024-05-08 08:41:27 -07:00
slab.c
str_error_r.c
string.c	perf annotate: Add disasm_line__parse() to parse raw instruction for powerpc	2024-07-31 16:12:59 -03:00
vsprintf.c
zalloc.c