Babu Moger 67bf649344 x86/resctrl: Fix min_cbm_bits for AMD ... AMD systems support zero CBM (capacity bit mask) for cache allocation. That is reflected in rdt_init_res_defs_amd() by: r->cache.arch_has_empty_bitmaps = true; However given the unified code in cbm_validate(), checking for: val == 0 && !arch_has_empty_bitmaps is not enough because of another check in cbm_validate(): if ((zero_bit - first_bit) < r->cache.min_cbm_bits) The default value of r->cache.min_cbm_bits = 1. Leading to: $ cd /sys/fs/resctrl $ mkdir foo $ cd foo $ echo L3:0=0 > schemata -bash: echo: write error: Invalid argument $ cat /sys/fs/resctrl/info/last_cmd_status Need at least 1 bits in the mask Initialize the min_cbm_bits to 0 for AMD. Also, remove the default setting of min_cbm_bits and initialize it separately. After the fix: $ cd /sys/fs/resctrl $ mkdir foo $ cd foo $ echo L3:0=0 > schemata $ cat /sys/fs/resctrl/info/last_cmd_status ok Fixes: 316e7f901f ("x86/resctrl: Add struct rdt_cache::arch_has_{sparse, empty}_bitmaps") Co-developed-by: Stephane Eranian <eranian@google.com> Signed-off-by: Stephane Eranian <eranian@google.com> Signed-off-by: Babu Moger <babu.moger@amd.com> Signed-off-by: Borislav Petkov <bp@suse.de> Reviewed-by: Ingo Molnar <mingo@kernel.org> Reviewed-by: James Morse <james.morse@arm.com> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/lkml/20220517001234.3137157-1-eranian@google.com		2022-10-18 20:25:16 +02:00
..
core.c	x86/resctrl: Fix min_cbm_bits for AMD	2022-10-18 20:25:16 +02:00
ctrlmondata.c	x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes	2022-09-23 14:25:05 +02:00
internal.h	x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes	2022-09-23 14:25:05 +02:00
Makefile	x86/resctrl: Avoid confusion over the new X86_RESCTRL config	2019-02-02 10:34:52 +01:00
monitor.c	x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes	2022-09-23 14:25:05 +02:00
pseudo_lock.c	x86/resctrl: Kill off alloc_enabled	2022-09-22 14:34:33 +02:00
pseudo_lock_event.h
rdtgroup.c	x86/resctrl: Add resctrl_rmid_realloc_limit to abstract x86's boot_cpu_data	2022-09-23 14:24:16 +02:00