linux/drivers/mmc/host
Ulf Hansson 04f2f45f41 mmc: sdricoh_cs: Respect the cmd->busy_timeout from the mmc core
Using a fixed 1s polling timeout for all commands is a bit problematic.

For some commands it means waiting longer than needed for the polling to be
aborted, which may not a big issue, but still. For other commands, like for
an erase (CMD38) that uses a R1B response, may require longer timeouts than
1s. In these cases, we may end up treating the command as it failed, while
it just needed some more time to complete successfully.

Fix the problem by respecting the cmd->busy_timeout, which is provided by
the mmc core.

Note that, even if the sdricoh_cs driver may currently not support HW busy
detection on DAT0, some comments in the code refer to that the HW may
support it. Therefore, it seems better to be proactive in this case.

Cc: Sascha Sommer <saschasommer@freenet.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20200508095228.14230-1-ulf.hansson@linaro.org
2020-05-28 11:22:14 +02:00
..
alcor.c mmc: alcor: Fix a resource leak in the error path for ->probe() 2020-05-07 15:10:25 +02:00
android-goldfish.c mmc: android-goldfish: Enable MMC_CAP2_NO_SDIO 2020-05-28 11:20:56 +02:00
atmel-mci.c mmc: atmel-mci: Respect the cmd->busy_timeout from the mmc core 2020-05-28 11:21:00 +02:00
au1xmmc.c mmc: au1xmmc: Drop redundant code in au1xmmc_send_command() 2020-05-28 11:20:56 +02:00
bcm2835.c mmc: bcm2835: Use dma_request_chan() instead dma_request_slave_channel() 2019-12-19 08:19:43 +01:00
cavium-octeon.c mmc: cavium-octeon: remove nonsense variable coercion 2020-03-27 13:26:25 +01:00
cavium-thunderx.c mmc: cavium: Add missed pci_release_regions 2019-12-18 12:55:11 +01:00
cavium.c
cavium.h
cb710-mmc.c mmc: cb710: Inform the mmc core about the maximum busy timeout 2020-05-28 11:22:13 +02:00
cb710-mmc.h
cqhci.c mmc: cqhci: Avoid false "cqhci: CQE stuck on" by not open-coding timeout loop 2020-04-20 09:24:39 +02:00
cqhci.h mmc: cqhci: Add cqhci_deactivate() 2020-03-24 14:39:52 +01:00
davinci_mmc.c mmc: core: Remove mmc_gpiod_request_*(invert_gpio) 2019-12-18 13:37:07 +01:00
dw_mmc-bluefield.c
dw_mmc-exynos.c
dw_mmc-exynos.h
dw_mmc-hi3798cv200.c mmc: dw_mmc: hi3798cv200: make array degrees static const, makes object smaller 2019-09-11 16:10:37 +02:00
dw_mmc-k3.c mmc: host: Prepare host drivers for mmc_regulator_set_vqmmc() returning > 0 2020-05-28 11:20:58 +02:00
dw_mmc-pci.c
dw_mmc-pltfm.c
dw_mmc-pltfm.h
dw_mmc-rockchip.c
dw_mmc-zx.c
dw_mmc-zx.h
dw_mmc.c mmc: host: Prepare host drivers for mmc_regulator_set_vqmmc() returning > 0 2020-05-28 11:20:58 +02:00
dw_mmc.h
jz4740_mmc.c mmc: jz4740: Inform the mmc core about the maximum busy timeout 2020-05-28 11:21:01 +02:00
Kconfig mmc: sdhci-of-at91: make MMC_SDHCI_OF_AT91 depend on HAVE_CLK 2020-05-28 11:21:01 +02:00
Makefile mmc: Add MMC host software queue support 2020-03-24 14:35:39 +01:00
meson-gx-mmc.c mmc: host: Prepare host drivers for mmc_regulator_set_vqmmc() returning > 0 2020-05-28 11:20:58 +02:00
meson-mx-sdio.c mmc: meson-mx-sdio: trigger a soft reset after a timeout or CRC error 2020-05-28 11:21:42 +02:00
mmc_hsq.c mmc: host: Introduce the request_atomic() for the host 2020-05-28 11:20:59 +02:00
mmc_hsq.h mmc: host: Introduce the request_atomic() for the host 2020-05-28 11:20:59 +02:00
mmc_spi.c mmc: mmc_spi: Respect the cmd->busy_timeout from the mmc core 2020-05-28 11:21:02 +02:00
mmci.c mmc: mmci: Switch to mmc_regulator_set_vqmmc() 2020-05-28 11:20:58 +02:00
mmci.h mmc: mmci_sdmmc: Implement signal voltage callbacks 2020-03-24 14:35:40 +01:00
mmci_qcom_dml.c
mmci_stm32_sdmmc.c mmc: mmci_sdmmc: fix power on issue due to pwr_reg initialization 2020-05-28 11:21:00 +02:00
moxart-mmc.c mmc: moxart: Use dma_request_chan() directly for channel request 2019-11-14 16:28:56 +01:00
mtk-sd.c mmc: host: Prepare host drivers for mmc_regulator_set_vqmmc() returning > 0 2020-05-28 11:20:58 +02:00
mvsdio.c mmc: mvsdio: convert to devm_platform_ioremap_resource 2019-12-18 14:55:11 +01:00
mvsdio.h
mxcmmc.c mmc: mxcmmc: Use dma_request_chan() instead dma_request_slave_channel() 2019-12-19 08:19:42 +01:00
mxs-mmc.c mmc: mxs: Use dma_request_chan() instead dma_request_slave_channel() 2019-12-19 08:19:42 +01:00
of_mmc_spi.c
omap.c
omap_hsmmc.c mmc: omap_hsmmc: Convert to pinctrl_select_default_state() 2019-12-16 13:00:41 +01:00
owl-mmc.c mmc: owl-mmc: Respect the cmd->busy_timeout from the mmc core 2020-05-28 11:21:01 +02:00
pxamci.c mmc: pxamci: Use dma_request_chan() instead dma_request_slave_channel() 2019-12-19 08:19:42 +01:00
pxamci.h
renesas_sdhi.h mmc: renesas_sdhi: Avoid bad TAP in HS400 2020-05-28 11:21:02 +02:00
renesas_sdhi_core.c mmc: renesas_sdhi: Avoid bad TAP in HS400 2020-05-28 11:21:02 +02:00
renesas_sdhi_internal_dmac.c mmc: renesas_sdhi: use recent tap values for HS400 2019-12-16 12:29:36 +01:00
renesas_sdhi_sys_dmac.c mmc: renesas_sdhi_sys_dmac: Remove all R-Car Gen3 SoCs 2019-09-11 15:58:39 +02:00
rtsx_pci_sdmmc.c mmc: rtsx_pci: Fix support for speed-modes that relies on tuning 2020-03-18 11:55:02 +01:00
rtsx_usb_sdmmc.c
s3cmci.c mmc: s3cmci: Drop redundant code in s3cmci_setup_data() 2020-05-28 11:20:56 +02:00
s3cmci.h
sdhci-acpi.c mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040 2020-05-11 10:51:30 +02:00
sdhci-bcm-kona.c
sdhci-brcmstb.c mmc: sdhci-brcmstb: Fix incorrect switch to HS mode 2020-01-20 12:01:19 +01:00
sdhci-cadence.c mmc: Replace zero-length array with flexible-array member 2020-03-24 14:39:45 +01:00
sdhci-cns3xxx.c
sdhci-dove.c
sdhci-esdhc-imx.c mmc: sdhci: use FIELD_GET/PREP for capabilities bit masks 2020-05-28 11:20:57 +02:00
sdhci-esdhc.h mmc: sdhci-esdhc: update contact email 2020-05-28 11:21:03 +02:00
sdhci-iproc.c mmc: sdhci: iproc: Add custom set_power() callback for bcm2711 2020-03-24 14:39:53 +01:00
sdhci-milbeaut.c mmc: sdhci: milbeaut: Use sdhci_set_power_and_voltage() 2020-03-24 14:39:53 +01:00
sdhci-msm.c mmc: sdhci-msm: Fix error handling for dev_pm_opp_of_add_table() 2020-05-28 11:21:02 +02:00
sdhci-of-arasan.c mmc: sdhci-of-arasan: Remove uninitialized ret variables 2020-05-28 11:20:58 +02:00
sdhci-of-aspeed.c mmc: sdhci-of-aspeed: add inversion signal presence 2019-11-20 13:40:47 +01:00
sdhci-of-at91.c mmc: sdhci: use FIELD_GET/PREP for capabilities bit masks 2020-05-28 11:20:57 +02:00
sdhci-of-dwcmshc.c
sdhci-of-esdhc.c mmc: sdhci-of-esdhc: fix serious issue clock is always disabled 2020-01-20 12:10:36 +01:00
sdhci-of-hlwd.c
sdhci-omap.c mmc: sdhci-omap: Add Support for Suspend/Resume 2020-03-24 14:39:52 +01:00
sdhci-pci-arasan.c
sdhci-pci-core.c mmc: sdhci: use FIELD_GET/PREP for capabilities bit masks 2020-05-28 11:20:57 +02:00
sdhci-pci-data.c
sdhci-pci-dwc-mshc.c
sdhci-pci-gli.c mmc: sdhci-pci-gli: Fix can not access GL9750 after reboot from Windows 10 2020-05-07 15:10:25 +02:00
sdhci-pci-o2micro.c mmc: sdhci-pci-o2micro: Make some symbols static 2020-05-28 11:21:01 +02:00
sdhci-pci.h mmc: Replace zero-length array with flexible-array member 2020-03-24 14:39:45 +01:00
sdhci-pic32.c
sdhci-pltfm.c mmc: Remove dev_err() usage after platform_get_irq() 2019-09-11 15:58:39 +02:00
sdhci-pltfm.h mmc: Replace zero-length array with flexible-array member 2020-03-24 14:39:45 +01:00
sdhci-pxav2.c
sdhci-pxav3.c
sdhci-s3c.c mmc: sdhci-s3c: convert to devm_platform_ioremap_resource 2019-12-18 14:46:06 +01:00
sdhci-sirf.c mmc: core: Remove mmc_gpiod_request_*(invert_gpio) 2019-12-18 13:37:07 +01:00
sdhci-spear.c mmc: sdhci-spear: convert to devm_platform_ioremap_resource 2019-12-18 14:46:06 +01:00
sdhci-sprd.c mmc: host: sdhci-sprd: Implement the request_atomic() API 2020-05-28 11:20:59 +02:00
sdhci-st.c
sdhci-tegra.c sdhci: tegra: Enable MMC_CAP_WAIT_WHILE_BUSY host capability 2020-03-24 14:39:52 +01:00
sdhci-xenon-phy.c
sdhci-xenon.c mmc: sdhci-xenon: fix annoying 1.8V regulator warning 2020-04-20 10:09:03 +02:00
sdhci-xenon.h
sdhci.c mmc: sdhci: add spin lock for sdhci_set_default_irqs in sdhci_init 2020-05-28 11:20:59 +02:00
sdhci.h mmc: host: sdhci: Implement the request_atomic() API 2020-05-28 11:20:59 +02:00
sdhci_am654.c mmc: sdhci: am654: Use sdhci_set_power_and_voltage() 2020-03-24 14:39:53 +01:00
sdhci_f_sdh30.c mmc: sdhci_f_sdh30: convert to devm_platform_ioremap_resource 2019-12-18 14:46:06 +01:00
sdhci_f_sdh30.h mmc: sdhci-milbeaut: add Milbeaut SD controller driver 2019-11-13 16:10:16 +01:00
sdricoh_cs.c mmc: sdricoh_cs: Respect the cmd->busy_timeout from the mmc core 2020-05-28 11:22:14 +02:00
sh_mmcif.c mmc: sh_mmcif: Use dma_request_chan() instead dma_request_slave_channel() 2019-12-19 08:19:42 +01:00
sunxi-mmc.c mmc: host: Prepare host drivers for mmc_regulator_set_vqmmc() returning > 0 2020-05-28 11:20:58 +02:00
tifm_sd.c mmc: tifm_sd: Inform the mmc core about the maximum busy timeout 2020-05-28 11:21:02 +02:00
tmio_mmc.c Revert "mmc: tmio: move runtime PM enablement to the driver implementations" 2019-09-13 13:48:35 +02:00
tmio_mmc.h mmc: tmio: factor out TAP usage 2020-03-24 14:35:38 +01:00
tmio_mmc_core.c mmc: tmio: remove superfluous callback wrappers 2020-03-24 14:35:38 +01:00
toshsd.c
toshsd.h
uniphier-sd.c mmc: uniphier-sd: Convert to pinctrl_select_default_state() 2019-12-16 13:00:41 +01:00
usdhi6rol0.c mmc: usdhi6rol0: Inform the mmc core about the maximum busy timeout 2020-05-28 11:21:00 +02:00
ushc.c
via-sdmmc.c mmc: via-sdmmc: Respect the cmd->busy_timeout from the mmc core 2020-05-28 11:21:02 +02:00
vub300.c mmc: vub300: Use scnprintf() for avoiding potential buffer overflow 2020-03-24 14:39:52 +01:00
wbsd.c mmc: wbsd: Replace hardcoded command numbers with existing defines 2020-05-28 11:20:56 +02:00
wbsd.h
wmt-sdmmc.c