Florian Westphal 947e492c0f netfilter: nft_compat: don't use refcount_inc on newly allocated entry ... When I moved the refcount to refcount_t type I missed the fact that refcount_inc() will result in use-after-free warning with CONFIG_REFCOUNT_FULL=y builds. The correct fix would be to init the reference count to 1 at allocation time, but, unfortunately we cannot do this, as we can't undo that in case something else fails later in the batch. So only solution I see is to special-case the 'new entry' condition and replace refcount_inc() with a "delayed" refcount_set(1) in this case, as done here. The .activate callback can be removed to simplify things, we only need to make sure that deactivate() decrements/unlinks the entry from the list at end of transaction phase (commit or abort). Fixes: 12c44aba66 ("netfilter: nft_compat: use refcnt_t type for nft_xt reference count") Reported-by: Jordan Glover <Golden_Miller83@protonmail.ch> Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>		2019-02-05 14:10:33 +01:00
..
ipset	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2018-12-20 18:20:26 -08:00
ipvs	ipvs: Fix signed integer overflow when setsockopt timeout	2019-01-24 13:38:54 +01:00
core.c	jump_label: move 'asm goto' support test to Kconfig	2019-01-06 09:46:51 +09:00
Kconfig
Makefile
nf_conncount.c	netfilter: nf_conncount: fix argument order to find_next_bit	2018-12-29 02:45:22 +01:00
nf_conntrack_acct.c	netfilter: conntrack: remove empty pernet fini stubs	2018-12-21 00:51:54 +01:00
nf_conntrack_amanda.c
nf_conntrack_broadcast.c
nf_conntrack_core.c	netfilter: nf_nat: skip nat clash resolution for same-origin entries	2019-02-04 14:26:11 +01:00
nf_conntrack_ecache.c	netfilter: conntrack: remove empty pernet fini stubs	2018-12-21 00:51:54 +01:00
nf_conntrack_expect.c
nf_conntrack_extend.c
nf_conntrack_ftp.c
nf_conntrack_h323_asn1.c
nf_conntrack_h323_main.c
nf_conntrack_h323_types.c
nf_conntrack_helper.c	netfilter: conntrack: remove empty pernet fini stubs	2018-12-21 00:51:54 +01:00
nf_conntrack_irc.c
nf_conntrack_labels.c
nf_conntrack_netbios_ns.c
nf_conntrack_netlink.c
nf_conntrack_pptp.c
nf_conntrack_proto.c
nf_conntrack_proto_dccp.c
nf_conntrack_proto_generic.c
nf_conntrack_proto_gre.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2018-12-20 18:20:26 -08:00
nf_conntrack_proto_icmp.c
nf_conntrack_proto_icmpv6.c
nf_conntrack_proto_sctp.c
nf_conntrack_proto_tcp.c
nf_conntrack_proto_udp.c	netfilter: conntrack: udp: set stream timeout to 2 minutes	2018-12-21 00:48:46 +01:00
nf_conntrack_sane.c
nf_conntrack_seqadj.c
nf_conntrack_sip.c
nf_conntrack_snmp.c
nf_conntrack_standalone.c	netfilter: conntrack: merge ecache and timestamp sysctl tables with main one	2018-12-21 00:51:51 +01:00
nf_conntrack_tftp.c
nf_conntrack_timeout.c
nf_conntrack_timestamp.c	netfilter: conntrack: remove empty pernet fini stubs	2018-12-21 00:51:54 +01:00
nf_dup_netdev.c
nf_flow_table_core.c	netfilter: nft_flow_offload: fix interaction with vrf slave device	2019-01-11 00:55:37 +01:00
nf_flow_table_inet.c
nf_flow_table_ip.c
nf_internals.h
nf_log.c
nf_log_common.c
nf_log_netdev.c
nf_nat_amanda.c
nf_nat_core.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2018-12-20 18:20:26 -08:00
nf_nat_ftp.c
nf_nat_helper.c
nf_nat_irc.c
nf_nat_proto.c
nf_nat_redirect.c
nf_nat_sip.c
nf_nat_tftp.c
nf_queue.c
nf_sockopt.c
nf_synproxy_core.c
nf_tables_api.c	netfilter: nf_tables: unbind set in rule from commit path	2019-02-04 17:29:17 +01:00
nf_tables_core.c
nf_tables_set_core.c
nf_tables_trace.c
nfnetlink.c
nfnetlink_acct.c
nfnetlink_cthelper.c
nfnetlink_cttimeout.c
nfnetlink_log.c
nfnetlink_osf.c	netfilter: nfnetlink_osf: add missing fmatch check	2019-01-28 11:09:11 +01:00
nfnetlink_queue.c
nft_bitwise.c
nft_byteorder.c
nft_chain_filter.c
nft_cmp.c
nft_compat.c	netfilter: nft_compat: don't use refcount_inc on newly allocated entry	2019-02-05 14:10:33 +01:00
nft_connlimit.c	netfilter: nf_conncount: merge lookup and add functions	2018-12-29 02:45:20 +01:00
nft_counter.c
nft_ct.c
nft_dup_netdev.c
nft_dynset.c	netfilter: nf_tables: unbind set in rule from commit path	2019-02-04 17:29:17 +01:00
nft_exthdr.c
nft_fib.c
nft_fib_inet.c
nft_fib_netdev.c
nft_flow_offload.c	netfilter: nft_flow_offload: fix checking method of conntrack helper	2019-01-14 12:50:59 +01:00
nft_fwd_netdev.c
nft_hash.c
nft_immediate.c	netfilter: nf_tables: unbind set in rule from commit path	2019-02-04 17:29:17 +01:00
nft_limit.c
nft_log.c
nft_lookup.c	netfilter: nf_tables: unbind set in rule from commit path	2019-02-04 17:29:17 +01:00
nft_masq.c
nft_meta.c
nft_nat.c
nft_numgen.c
nft_objref.c	netfilter: nf_tables: unbind set in rule from commit path	2019-02-04 17:29:17 +01:00
nft_osf.c
nft_payload.c
nft_queue.c
nft_quota.c
nft_range.c
nft_redir.c
nft_reject.c
nft_reject_inet.c
nft_rt.c
nft_set_bitmap.c
nft_set_hash.c
nft_set_rbtree.c
nft_socket.c
nft_tproxy.c
nft_tunnel.c
nft_xfrm.c
utils.c
x_tables.c
xt_addrtype.c
xt_AUDIT.c
xt_bpf.c
xt_cgroup.c
xt_CHECKSUM.c
xt_CLASSIFY.c
xt_cluster.c
xt_comment.c
xt_connbytes.c
xt_connlabel.c
xt_connlimit.c
xt_connmark.c
xt_CONNSECMARK.c
xt_conntrack.c
xt_cpu.c
xt_CT.c
xt_dccp.c
xt_devgroup.c
xt_DSCP.c
xt_dscp.c
xt_ecn.c
xt_esp.c
xt_hashlimit.c	mm: convert totalram_pages and totalhigh_pages variables to atomic	2018-12-28 12:11:47 -08:00
xt_helper.c
xt_hl.c
xt_HL.c
xt_HMARK.c
xt_IDLETIMER.c
xt_ipcomp.c
xt_iprange.c
xt_ipvs.c
xt_l2tp.c
xt_LED.c
xt_length.c
xt_limit.c
xt_LOG.c
xt_mac.c
xt_mark.c
xt_multiport.c
xt_nat.c
xt_NETMAP.c
xt_nfacct.c
xt_NFLOG.c
xt_NFQUEUE.c
xt_osf.c
xt_owner.c
xt_physdev.c
xt_pkttype.c
xt_policy.c
xt_quota.c
xt_RATEEST.c
xt_rateest.c
xt_realm.c
xt_recent.c
xt_REDIRECT.c
xt_repldata.h
xt_sctp.c
xt_SECMARK.c
xt_set.c
xt_socket.c
xt_state.c
xt_statistic.c
xt_string.c
xt_TCPMSS.c
xt_tcpmss.c
xt_TCPOPTSTRIP.c
xt_tcpudp.c
xt_TEE.c
xt_time.c
xt_TPROXY.c
xt_TRACE.c
xt_u32.c