public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 08:43:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
linux/drivers/usb/host
History
Alan Stern 7d8021c967 USB: OHCI: Fix race between ED unlink and URB submission 
This patch fixes a bug introduced by commit 977dcfdc60 ("USB: OHCI:
don't lose track of EDs when a controller dies").  The commit changed
ed_state from ED_UNLINK to ED_IDLE too early, before finish_urb() had
been called.  The user-visible consequence is that the driver
occasionally crashes or locks up when an URB is submitted while
another URB for the same endpoint is being unlinked.

This patch moves the ED state change later, to the right place.  The
drawback is that now we may unnecessarily execute some instructions
multiple times when a controller dies.  Since controllers dying is an
exceptional occurrence, a little wasted time won't matter.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Heiko Przybyl <lil_tux@web.de>
Tested-by: Heiko Przybyl <lil_tux@web.de>
Fixes: 977dcfdc60
CC: <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-07-22 14:46:50 -07:00
..
whci USB: whci-hcd: Delete an unnecessary check before the function call "usb_put_hcd" 2015-03-18 16:56:40 +01:00
bcma-hcd.c treewide: Remove unnecessary BCMA_CORETABLE_END macro 2015-02-11 14:38:28 -08:00
ehci-atmel.c USB: ehci-atmel: rework clk handling 2015-03-18 13:28:35 +01:00
ehci-dbg.c USB: ehci-dbg.c: move assignment out of if () block 2015-05-10 16:01:10 +02:00
ehci-exynos.c Driver core patches for 3.19-rc1 2014-12-14 16:10:09 -08:00
ehci-fsl.c drivers:usb:fsl:Make fsl ehci drv an independent driver module 2015-05-24 09:29:36 -07:00
ehci-fsl.h
ehci-grlib.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ehci-hcd.c drivers:usb:fsl: Fix compilation error for fsl ehci drv 2015-05-31 16:14:07 +09:00
ehci-hub.c drivers:usb:fsl: Fix compilation error for fsl ehci drv 2015-05-31 16:14:07 +09:00
ehci-mem.c
ehci-msm.c Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap" 2015-04-28 12:51:30 +02:00
ehci-mv.c
ehci-mxc.c
ehci-omap.c
ehci-orion.c usb: ehci-orion: add more constants for register values 2015-03-26 10:50:52 +01:00
ehci-pci.c ehci-pci: disable for Intel MID platforms (update) 2015-02-03 15:28:31 -08:00
ehci-platform.c phy: for 4.2 merge window 2015-06-03 14:13:41 +09:00
ehci-pmcmsp.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ehci-ppc-of.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ehci-ps3.c
ehci-q.c
ehci-sched.c USB: EHCI: adjust error return code 2015-01-09 09:58:49 -08:00
ehci-sead3.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ehci-sh.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ehci-spear.c
ehci-st.c
ehci-sysfs.c
ehci-tegra.c USB: ehci-tegra: fix inefficient copy of unaligned buffers 2015-05-08 01:43:44 +02:00
ehci-tilegx.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ehci-timer.c
ehci-w90x900.c Driver core patches for 3.19-rc1 2014-12-14 16:10:09 -08:00
ehci-xilinx-of.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ehci.h drivers:usb:fsl: Fix compilation error for fsl ehci drv 2015-05-31 16:14:07 +09:00
fhci-dbg.c
fhci-hcd.c
fhci-hub.c fhci-hub: use USB_DT_HUB 2015-04-03 19:03:19 +02:00
fhci-mem.c
fhci-q.c
fhci-sched.c
fhci-tds.c
fhci.h
fotg210-hcd.c usb: generic resume timeout for v4.1 2015-04-10 13:45:27 +02:00
fotg210.h
fsl-mph-dr-of.c drivers:usb:fsl: Add support for USB controller version-2.5 2015-05-31 15:51:24 +09:00
fusbh200-hcd.c USB: fusbh200-hcd.c: move assignment out of if () block 2015-05-10 16:01:10 +02:00
fusbh200.h
hwa-hc.c
imx21-dbg.c
imx21-hcd.c imx21-hcd: use USB_DT_HUB 2015-04-03 19:03:18 +02:00
imx21-hcd.h
isp116x-hcd.c USB: isp116x-hcd.c: move assignment out of if () block 2015-05-10 16:01:11 +02:00
isp116x.h
isp1362-hcd.c isp1362-hcd: use USB_DT_HUB 2015-04-03 19:03:18 +02:00
isp1362.h
Kconfig Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus 2015-06-27 12:44:34 -07:00
Makefile drivers:usb:fsl:Make fsl ehci drv an independent driver module 2015-05-24 09:29:36 -07:00
max3421-hcd.c max3421-hcd: use USB_DT_HUB 2015-04-03 19:03:18 +02:00
ohci-at91.c USB: host: ohci-at91: remove useless uclk clock 2015-03-26 10:54:01 +01:00
ohci-da8xx.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ohci-dbg.c USB: ohci-dbg.c: move assignment out of if () block 2015-05-10 16:01:11 +02:00
ohci-exynos.c Driver core patches for 3.19-rc1 2014-12-14 16:10:09 -08:00
ohci-hcd.c USB: ohci-hcd.c: move assignment out of if () block 2015-05-10 16:01:11 +02:00
ohci-hub.c ohci-hub: use USB_DT_HUB 2015-04-03 19:03:17 +02:00
ohci-jz4740.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ohci-mem.c
ohci-nxp.c
ohci-omap.c Driver core patches for 3.19-rc1 2014-12-14 16:10:09 -08:00
ohci-omap3.c
ohci-pci.c
ohci-platform.c usb: ohci-platform: Use devm_of_phy_get_by_index 2015-05-11 21:42:25 +05:30
ohci-ppc-of.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ohci-ps3.c
ohci-pxa27x.c Driver core patches for 3.19-rc1 2014-12-14 16:10:09 -08:00
ohci-q.c USB: OHCI: Fix race between ED unlink and URB submission 2015-07-22 14:46:50 -07:00
ohci-s3c2410.c ohci-s3c2410: use HUB_CHAR_* 2015-01-25 21:01:13 +08:00
ohci-sa1111.c
ohci-sm501.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ohci-spear.c Driver core patches for 3.19-rc1 2014-12-14 16:10:09 -08:00
ohci-st.c
ohci-tilegx.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ohci-tmio.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
ohci.h
oxu210hp-hcd.c usb: generic resume timeout for v4.1 2015-04-10 13:45:27 +02:00
oxu210hp.h
pci-quirks.c usb: host: pci_quirks: joing string literals 2015-01-31 09:05:06 -08:00
pci-quirks.h
r8a66597-hcd.c usb: generic resume timeout for v4.1 2015-04-10 13:45:27 +02:00
r8a66597.h
sl811-hcd.c usb: generic resume timeout for v4.1 2015-04-10 13:45:27 +02:00
sl811.h
sl811_cs.c
ssb-hcd.c USB: ssb: use devm_kzalloc 2015-06-08 14:26:22 -07:00
u132-hcd.c u132-hcd: use USB_DT_HUB 2015-04-03 19:03:16 +02:00
uhci-debug.c
uhci-grlib.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
uhci-hcd.c
uhci-hcd.h
uhci-hub.c usb: generic resume timeout for v4.1 2015-04-10 13:45:27 +02:00
uhci-pci.c
uhci-platform.c usb: host: drop owner assignment from platform_drivers 2015-01-09 12:31:53 -08:00
uhci-q.c
xhci-dbg.c xhci: clean up work to remove unused parameters for functions in xhci-mem.c 2015-01-09 10:05:47 -08:00
xhci-ext-caps.h
xhci-hub.c xhci: do not report PLC when link is in internal resume state 2015-07-22 14:19:37 -07:00
xhci-mem.c usb: xhci: Bugfix for NULL pointer deference in xhci_endpoint_init() function 2015-07-22 14:19:36 -07:00
xhci-mvebu.c
xhci-mvebu.h
xhci-pci.c xhci: Workaround to get D3 working in Intel xHCI 2015-07-22 14:19:36 -07:00
xhci-plat.c usb: xhci: Fix suspend/resume when used with OTG core 2015-05-31 15:45:31 +09:00
xhci-rcar.c
xhci-rcar.h
xhci-ring.c xhci: prevent bus_suspend if SS port resuming in phase 1 2015-07-22 14:19:37 -07:00
xhci-trace.c
xhci-trace.h tracing: Add TRACE_SYSTEM_VAR to xhci-hcd 2015-04-07 12:31:55 -04:00
xhci.c xhci: Calculate old endpoints correctly on device reset 2015-07-22 14:19:36 -07:00
xhci.h xhci: prevent bus_suspend if SS port resuming in phase 1 2015-07-22 14:19:37 -07:00