mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-11-01 09:13:37 +00:00
bfb1a7c91f
In __WARN_FLAGS(), we had two asm statements (abbreviated):
asm volatile("ud2");
asm volatile(".pushsection .discard.reachable");
These pair of statements are used to trigger an exception, but then help
objtool understand that for warnings, control flow will be restored
immediately afterwards.
The problem is that volatile is not a compiler barrier. GCC explicitly
documents this:
> Note that the compiler can move even volatile asm instructions
> relative to other code, including across jump instructions.
Also, no clobbers are specified to prevent instructions from subsequent
statements from being scheduled by compiler before the second asm
statement. This can lead to instructions from subsequent statements
being emitted by the compiler before the second asm statement.
Providing a scheduling model such as via -march= options enables the
compiler to better schedule instructions with known latencies to hide
latencies from data hazards compared to inline asm statements in which
latencies are not estimated.
If an instruction gets scheduled by the compiler between the two asm
statements, then objtool will think that it is not reachable, producing
a warning.
To prevent instructions from being scheduled in between the two asm
statements, merge them.
Also remove an unnecessary unreachable() asm annotation from BUG() in
favor of __builtin_unreachable(). objtool is able to track that the ud2
from BUG() terminates control flow within the function.
Link: https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Volatile
Link: https://github.com/ClangBuiltLinux/linux/issues/1483
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lore.kernel.org/r/20220202205557.2260694-1-ndesaulniers@google.com
88 lines
2.3 KiB
C
88 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _ASM_X86_BUG_H
|
|
#define _ASM_X86_BUG_H
|
|
|
|
#include <linux/stringify.h>
|
|
#include <linux/instrumentation.h>
|
|
|
|
/*
|
|
* Despite that some emulators terminate on UD2, we use it for WARN().
|
|
*/
|
|
#define ASM_UD2 ".byte 0x0f, 0x0b"
|
|
#define INSN_UD2 0x0b0f
|
|
#define LEN_UD2 2
|
|
|
|
#ifdef CONFIG_GENERIC_BUG
|
|
|
|
#ifdef CONFIG_X86_32
|
|
# define __BUG_REL(val) ".long " __stringify(val)
|
|
#else
|
|
# define __BUG_REL(val) ".long " __stringify(val) " - 2b"
|
|
#endif
|
|
|
|
#ifdef CONFIG_DEBUG_BUGVERBOSE
|
|
|
|
#define _BUG_FLAGS(ins, flags, extra) \
|
|
do { \
|
|
asm_inline volatile("1:\t" ins "\n" \
|
|
".pushsection __bug_table,\"aw\"\n" \
|
|
"2:\t" __BUG_REL(1b) "\t# bug_entry::bug_addr\n" \
|
|
"\t" __BUG_REL(%c0) "\t# bug_entry::file\n" \
|
|
"\t.word %c1" "\t# bug_entry::line\n" \
|
|
"\t.word %c2" "\t# bug_entry::flags\n" \
|
|
"\t.org 2b+%c3\n" \
|
|
".popsection\n" \
|
|
extra \
|
|
: : "i" (__FILE__), "i" (__LINE__), \
|
|
"i" (flags), \
|
|
"i" (sizeof(struct bug_entry))); \
|
|
} while (0)
|
|
|
|
#else /* !CONFIG_DEBUG_BUGVERBOSE */
|
|
|
|
#define _BUG_FLAGS(ins, flags, extra) \
|
|
do { \
|
|
asm_inline volatile("1:\t" ins "\n" \
|
|
".pushsection __bug_table,\"aw\"\n" \
|
|
"2:\t" __BUG_REL(1b) "\t# bug_entry::bug_addr\n" \
|
|
"\t.word %c0" "\t# bug_entry::flags\n" \
|
|
"\t.org 2b+%c1\n" \
|
|
".popsection\n" \
|
|
extra \
|
|
: : "i" (flags), \
|
|
"i" (sizeof(struct bug_entry))); \
|
|
} while (0)
|
|
|
|
#endif /* CONFIG_DEBUG_BUGVERBOSE */
|
|
|
|
#else
|
|
|
|
#define _BUG_FLAGS(ins, flags, extra) asm volatile(ins)
|
|
|
|
#endif /* CONFIG_GENERIC_BUG */
|
|
|
|
#define HAVE_ARCH_BUG
|
|
#define BUG() \
|
|
do { \
|
|
instrumentation_begin(); \
|
|
_BUG_FLAGS(ASM_UD2, 0, ""); \
|
|
__builtin_unreachable(); \
|
|
} while (0)
|
|
|
|
/*
|
|
* This instrumentation_begin() is strictly speaking incorrect; but it
|
|
* suppresses the complaints from WARN()s in noinstr code. If such a WARN()
|
|
* were to trigger, we'd rather wreck the machine in an attempt to get the
|
|
* message out than not know about it.
|
|
*/
|
|
#define __WARN_FLAGS(flags) \
|
|
do { \
|
|
__auto_type f = BUGFLAG_WARNING|(flags); \
|
|
instrumentation_begin(); \
|
|
_BUG_FLAGS(ASM_UD2, f, ASM_REACHABLE); \
|
|
instrumentation_end(); \
|
|
} while (0)
|
|
|
|
#include <asm-generic/bug.h>
|
|
|
|
#endif /* _ASM_X86_BUG_H */
|