public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-05-24 10:39:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
linux/drivers/mmc/host
History
Alek Du b704441e38 mmc: sdhci: fix the timeout check window for clock and reset 
We observed some premature timeouts on a virtualization platform, the log
is like this:

case 1:
[159525.255629] mmc1: Internal clock never stabilised.
[159525.255818] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
[159525.256049] mmc1: sdhci: Sys addr:  0x00000000 | Version:  0x00001002
...
[159525.257205] mmc1: sdhci: Wake-up:   0x00000000 | Clock:    0x0000fa03
From the clock control register dump, we are pretty sure the clock was
stablized.

case 2:
[  914.550127] mmc1: Reset 0x2 never completed.
[  914.550321] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
[  914.550608] mmc1: sdhci: Sys addr:  0x00000010 | Version:  0x00001002

After checking the sdhci code, we found the timeout check actually has a
little window that the CPU can be scheduled out and when it comes back,
the original time set or check is not valid.

Fixes: 5a436cc0af ("mmc: sdhci: Optimize delay loops")
Cc: stable@vger.kernel.org      # v4.12+
Signed-off-by: Alek Du <alek.du@intel.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
2018-12-06 11:22:00 +01:00
..
android-goldfish.c mmc: android-goldfish: fix bad logic of sg_copy_{from,to}_buffer conversion 2018-08-21 16:06:17 +02:00
atmel-mci.c mmc: atmel-mci: fix bad logic of sg_copy_{from,to}_buffer conversion 2018-08-21 16:06:17 +02:00
au1xmmc.c mmc: au1xmmc: handle highmem pages 2018-05-29 12:24:26 +02:00
bcm2835.c
cavium-octeon.c
cavium-thunderx.c
cavium.c
cavium.h
cb710-mmc.c
cb710-mmc.h
cqhci.c
cqhci.h
davinci_mmc.c
dw_mmc-bluefield.c
dw_mmc-exynos.c mmc: dw_mmc-exynos: Add tuning for sdr and ddr timing for USH-I mode 2018-10-08 12:02:22 +02:00
dw_mmc-exynos.h
dw_mmc-hi3798cv200.c mmc: dw_mmc: hi3798cv200: add MMC_CAP_CMD23 cap 2018-10-08 11:40:43 +02:00
dw_mmc-k3.c
dw_mmc-pci.c
dw_mmc-pltfm.c
dw_mmc-pltfm.h
dw_mmc-rockchip.c
dw_mmc-zx.c
dw_mmc-zx.h
dw_mmc.c mmc: dw_mmc: fix card threshold control configuration 2018-07-03 10:57:16 +02:00
dw_mmc.h
jz4740_mmc.c mmc: jz4740: Add support for the JZ4725B 2018-10-08 11:40:43 +02:00
Kconfig mmc: renesas_sdhi: Add r8a77470 SDHI1 support 2018-10-15 14:39:17 +02:00
Makefile mmc: mmci: add stm32 sdmmc variant 2018-10-09 09:16:53 +02:00
meson-gx-mmc.c
meson-mx-sdio.c mmc: meson-mx-sdio: mark expected switch fall-through 2018-10-08 11:40:43 +02:00
mmc_spi.c
mmci.c mmc: mmci: add stm32 sdmmc variant 2018-10-09 09:16:53 +02:00
mmci.h mmc: mmci: add stm32 sdmmc variant 2018-10-09 09:16:53 +02:00
mmci_qcom_dml.c mmc: mmci: add dma_error callback 2018-10-09 09:13:03 +02:00
mmci_qcom_dml.h mmc: mmci: Add and implement a ->dma_setup() callback for qcom dml 2018-08-01 12:01:13 +02:00
mmci_stm32_sdmmc.c mmc: mmci: add stm32 sdmmc variant 2018-10-09 09:16:53 +02:00
moxart-mmc.c
mtk-sd.c mmc: mediatek: drop too much code of tuning method 2018-10-15 15:00:29 +02:00
mvsdio.c mmc: mvsdio: Enable MMC_CAP_ERASE 2018-05-31 15:02:16 +02:00
mvsdio.h
mxcmmc.c mmc: mxcmmc: replace spin_lock_irqsave with spin_lock in ISR 2018-10-08 11:40:43 +02:00
mxs-mmc.c
of_mmc_spi.c
omap.c MMC: OMAP: fix broken MMC on OMAP15XX/OMAP5910/OMAP310 2018-12-04 14:34:51 +01:00
omap_hsmmc.c mmc: omap_hsmmc: Delete platform data GPIO CD and WP 2018-10-08 11:40:43 +02:00
pxamci.c mmc: pxamci: provide a short-hand for &pdev->dev 2018-07-16 11:21:45 +02:00
pxamci.h
renesas_sdhi.h mmc: use SPDX identifier for Renesas drivers 2018-10-08 11:40:43 +02:00
renesas_sdhi_core.c mmc: renesas_sdhi: skip SCC error check when retuning 2018-10-08 11:40:43 +02:00
renesas_sdhi_internal_dmac.c mmc: tmio: simplify the DMA mode test 2018-10-15 14:52:50 +02:00
renesas_sdhi_sys_dmac.c mmc: tmio: simplify the DMA mode test 2018-10-15 14:52:50 +02:00
rtsx_pci_sdmmc.c
rtsx_usb_sdmmc.c
s3cmci.c
s3cmci.h
sdhci-acpi.c Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2018-10-23 13:32:18 +01:00
sdhci-bcm-kona.c mmc: sdhci-*: Don't emit error msg if sdhci_add_host() fails 2018-05-29 12:24:26 +02:00
sdhci-brcmstb.c
sdhci-cadence.c
sdhci-cns3xxx.c
sdhci-dove.c
sdhci-esdhc-imx.c mmc: sdhci-esdhc-imx: fix indent 2018-07-16 11:41:13 +02:00
sdhci-esdhc.h mmc: sdhci-of-esdhc: add erratum A008171 support 2018-10-08 11:40:43 +02:00
sdhci-iproc.c mmc: sdhci-iproc: Add ACPI support 2018-10-08 11:40:43 +02:00
sdhci-msm.c mmc: sdhci-msm: Remove redundant dev_err call in sdhci_msm_probe() 2018-07-16 11:21:45 +02:00
sdhci-of-arasan.c mmc: sdhci-of-arasan: Add Support for AM654 MMC and PHY 2018-10-09 08:59:26 +02:00
sdhci-of-at91.c
sdhci-of-dwcmshc.c mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation 2018-10-08 11:40:43 +02:00
sdhci-of-esdhc.c mmc: sdhci-of-esdhc: add erratum A008171 support 2018-10-08 11:40:43 +02:00
sdhci-of-hlwd.c
sdhci-omap.c mmc: sdhci-omap: Fix DCRC error handling during tuning 2018-12-05 13:01:23 +01:00
sdhci-pci-arasan.c
sdhci-pci-core.c mmc: sdhci-pci: Workaround GLK firmware failing to restore the tuning value 2018-11-19 14:11:07 +01:00
sdhci-pci-data.c
sdhci-pci-dwc-mshc.c mmc: sdhci-pci-dwc-mshc: synopsys dwc mshc support 2018-07-16 11:21:45 +02:00
sdhci-pci-o2micro.c mmc: sdhci-pci-o2micro: Add quirk for O2 Micro dev 0x8620 rev 0x01 2018-10-08 11:40:43 +02:00
sdhci-pci.h mmc: sdhci-pci-dwc-mshc: synopsys dwc mshc support 2018-07-16 11:21:45 +02:00
sdhci-pic32.c mmc: sdhci-*: Don't emit error msg if sdhci_add_host() fails 2018-05-29 12:24:26 +02:00
sdhci-pltfm.c mmc: sdhci-pltfm: Convert DT properties to generic device properties 2018-10-08 11:40:43 +02:00
sdhci-pltfm.h mmc: sdhci-pltfm: Convert DT properties to generic device properties 2018-10-08 11:40:43 +02:00
sdhci-pxav2.c mmc: sdhci-*: Don't emit error msg if sdhci_add_host() fails 2018-05-29 12:24:26 +02:00
sdhci-pxav3.c mmc: sdhci: pxav3: Delete GPIO handling 2018-10-08 11:40:43 +02:00
sdhci-s3c.c mmc: sdhci-*: Don't emit error msg if sdhci_add_host() fails 2018-05-29 12:24:26 +02:00
sdhci-sirf.c mmc: sdhci: sirf: Use the slot GPIO descriptor 2018-10-08 11:40:43 +02:00
sdhci-spear.c mmc: sdhci: spear: Use the slot GPIO descriptor 2018-10-08 11:40:43 +02:00
sdhci-sprd.c mmc: sdhci-sprd: Add Spreadtrum's initial host controller 2018-10-08 11:40:43 +02:00
sdhci-st.c mmc: sdhci-*: Don't emit error msg if sdhci_add_host() fails 2018-05-29 12:24:26 +02:00
sdhci-tegra.c mmc: tegra: fix inconsistent IS_ERR and PTR_ERR 2018-10-08 11:40:43 +02:00
sdhci-xenon-phy.c mmc: Convert to using %pOFn instead of device_node.name 2018-10-08 11:40:43 +02:00
sdhci-xenon.c
sdhci-xenon.h
sdhci.c mmc: sdhci: fix the timeout check window for clock and reset 2018-12-06 11:22:00 +01:00
sdhci.h mmc: sdhci: Add Auto CMD Auto Select support 2018-10-08 11:40:43 +02:00
sdhci_f_sdh30.c
sdricoh_cs.c
sh_mmcif.c mmc: use SPDX identifier for Renesas drivers 2018-10-08 11:40:43 +02:00
sunxi-mmc.c mmc: sunxi: Use new timing mode for A64 eMMC controller 2018-10-08 11:40:43 +02:00
tifm_sd.c mmc: tifm_sd: Mark expected switch fall-through 2018-10-08 11:40:43 +02:00
tmio_mmc.c mmc: tmio: remove TMIO_MMC_HAVE_HIGH_REG flag 2018-10-15 14:39:45 +02:00
tmio_mmc.h mmc: tmio: simplify the DMA mode test 2018-10-15 14:52:50 +02:00
tmio_mmc_core.c mmc: tmio: simplify the DMA mode test 2018-10-15 14:52:50 +02:00
toshsd.c
toshsd.h
uniphier-sd.c mmc: uniphier-sd: avoid using broken DMA RX channel 2018-10-15 14:53:21 +02:00
usdhi6rol0.c mmc: use SPDX identifier for Renesas drivers 2018-10-08 11:40:43 +02:00
ushc.c
via-sdmmc.c
vub300.c
wbsd.c mmc: wbsd: handle highmem pages 2018-05-21 15:49:21 +02:00
wbsd.h
wmt-sdmmc.c