Maciej Fijalkowski 792b208658 ice: fix vsi->txq_map sizing ... The approach of having XDP queue per CPU regardless of user's setting exposed a hidden bug that could occur in case when Rx queue count differ from Tx queue count. Currently vsi->txq_map's size is equal to the doubled vsi->alloc_txq, which is not correct due to the fact that XDP rings were previously based on the Rx queue count. Below splat can be seen when ethtool -L is used and XDP rings are configured: [ 682.875339] BUG: kernel NULL pointer dereference, address: 000000000000000f [ 682.883403] #PF: supervisor read access in kernel mode [ 682.889345] #PF: error_code(0x0000) - not-present page [ 682.895289] PGD 0 P4D 0 [ 682.898218] Oops: 0000 [#1] PREEMPT SMP PTI [ 682.903055] CPU: 42 PID: 2878 Comm: ethtool Tainted: G OE 5.15.0-rc5+ #1 [ 682.912214] Hardware name: Intel Corp. GRANTLEY/GRANTLEY, BIOS GRRFCRB1.86B.0276.D07.1605190235 05/19/2016 [ 682.923380] RIP: 0010:devres_remove+0x44/0x130 [ 682.928527] Code: 49 89 f4 55 48 89 fd 4c 89 ff 53 48 83 ec 10 e8 92 b9 49 00 48 8b 9d a8 02 00 00 48 8d 8d a0 02 00 00 49 89 c2 48 39 cb 74 0f <4c> 3b 63 10 74 25 48 8b 5b 08 48 39 cb 75 f1 4c 89 ff 4c 89 d6 e8 [ 682.950237] RSP: 0018:ffffc90006a679f0 EFLAGS: 00010002 [ 682.956285] RAX: 0000000000000286 RBX: ffffffffffffffff RCX: ffff88908343a370 [ 682.964538] RDX: 0000000000000001 RSI: ffffffff81690d60 RDI: 0000000000000000 [ 682.972789] RBP: ffff88908343a0d0 R08: 0000000000000000 R09: 0000000000000000 [ 682.981040] R10: 0000000000000286 R11: 3fffffffffffffff R12: ffffffff81690d60 [ 682.989282] R13: ffffffff81690a00 R14: ffff8890819807a8 R15: ffff88908343a36c [ 682.997535] FS: 00007f08c7bfa740(0000) GS:ffff88a03fd00000(0000) knlGS:0000000000000000 [ 683.006910] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 683.013557] CR2: 000000000000000f CR3: 0000001080a66003 CR4: 00000000003706e0 [ 683.021819] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 683.030075] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 683.038336] Call Trace: [ 683.041167] devm_kfree+0x33/0x50 [ 683.045004] ice_vsi_free_arrays+0x5e/0xc0 [ice] [ 683.050380] ice_vsi_rebuild+0x4c8/0x750 [ice] [ 683.055543] ice_vsi_recfg_qs+0x9a/0x110 [ice] [ 683.060697] ice_set_channels+0x14f/0x290 [ice] [ 683.065962] ethnl_set_channels+0x333/0x3f0 [ 683.070807] genl_family_rcv_msg_doit+0xea/0x150 [ 683.076152] genl_rcv_msg+0xde/0x1d0 [ 683.080289] ? channels_prepare_data+0x60/0x60 [ 683.085432] ? genl_get_cmd+0xd0/0xd0 [ 683.089667] netlink_rcv_skb+0x50/0xf0 [ 683.094006] genl_rcv+0x24/0x40 [ 683.097638] netlink_unicast+0x239/0x340 [ 683.102177] netlink_sendmsg+0x22e/0x470 [ 683.106717] sock_sendmsg+0x5e/0x60 [ 683.110756] __sys_sendto+0xee/0x150 [ 683.114894] ? handle_mm_fault+0xd0/0x2a0 [ 683.119535] ? do_user_addr_fault+0x1f3/0x690 [ 683.134173] __x64_sys_sendto+0x25/0x30 [ 683.148231] do_syscall_64+0x3b/0xc0 [ 683.161992] entry_SYSCALL_64_after_hwframe+0x44/0xae Fix this by taking into account the value that num_possible_cpus() yields in addition to vsi->alloc_txq instead of doubling the latter. Fixes: efc2214b60 ("ice: Add support for XDP") Fixes: 22bf877e52 ("ice: introduce XDP_TX fallback path") Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>		2021-11-22 08:33:54 -08:00
..
ice.h	ice: Fix VF true promiscuous mode	2021-11-03 08:15:27 -07:00
ice_adminq_cmd.h	ice: Add support to print error on PHY FW load failure	2021-10-28 11:00:20 -07:00
ice_arfs.c	ice: make use of ice_for_each_* macros	2021-10-15 07:39:03 -07:00
ice_arfs.h
ice_base.c	ice: Fix not stopping Tx queues for VFs	2021-11-03 08:16:08 -07:00
ice_base.h	ice: split ice_ring onto Tx/Rx separate structs	2021-10-15 07:39:02 -07:00
ice_common.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-10-22 11:41:16 +01:00
ice_common.h	ice: Add support for SMA control multiplexer	2021-10-14 07:37:30 -07:00
ice_controlq.c
ice_controlq.h
ice_dcb.c	ice: Add DSCP support	2021-09-28 09:42:04 -07:00
ice_dcb.h	ice: Add DSCP support	2021-09-28 09:42:04 -07:00
ice_dcb_lib.c	ice: Add infrastructure for mqprio support via ndo_setup_tc	2021-10-20 15:57:54 -07:00
ice_dcb_lib.h	ice: Add infrastructure for mqprio support via ndo_setup_tc	2021-10-20 15:57:54 -07:00
ice_dcb_nl.c	ice: Add feature bitmap, helpers and a check for DSCP	2021-09-28 09:42:04 -07:00
ice_dcb_nl.h
ice_devids.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-10-22 11:41:16 +01:00
ice_devlink.c	ice: Nuild fix.	2021-10-22 14:24:44 +01:00
ice_devlink.h	ice: Move devlink port to PF/VF struct	2021-10-07 10:41:41 -07:00
ice_eswitch.c	ice: Clear synchronized addrs when adding VFs in switchdev mode	2021-10-29 10:56:24 -07:00
ice_eswitch.h	ice: split ice_ring onto Tx/Rx separate structs	2021-10-15 07:39:02 -07:00
ice_ethtool.c	ice: Hide bus-info in ethtool for PRs in switchdev mode	2021-10-29 11:43:15 -07:00
ice_ethtool_fdir.c	ice: use devm_kcalloc() instead of devm_kzalloc()	2021-10-19 10:53:28 -07:00
ice_fdir.c	ice: Fix macro name for IPv4 fragment flag	2021-09-28 09:42:04 -07:00
ice_fdir.h	ice: Fix macro name for IPv4 fragment flag	2021-09-28 09:42:04 -07:00
ice_flex_pipe.c	ice: support for GRE in eswitch	2021-10-28 11:00:20 -07:00
ice_flex_pipe.h	ice: create advanced switch recipe	2021-10-11 08:38:27 -07:00
ice_flex_type.h	ice: support for GRE in eswitch	2021-10-28 11:00:20 -07:00
ice_flow.c
ice_flow.h
ice_fltr.c	ice: Manage act flags for switchdev offloads	2021-10-19 10:53:26 -07:00
ice_fltr.h	ice: Manage act flags for switchdev offloads	2021-10-19 10:53:26 -07:00
ice_fw_update.c
ice_fw_update.h
ice_hw_autogen.h	ice: fix software generating extra interrupts	2021-10-19 10:45:17 -07:00
ice_idc.c	ice: Correctly deal with PFs that do not support RDMA	2021-09-10 09:58:55 +01:00
ice_idc_int.h
ice_lag.c	ice: Respond to a NETDEV_UNREGISTER event for LAG	2021-10-25 13:44:37 -07:00
ice_lag.h
ice_lan_tx_rx.h	ice: switchdev slow path	2021-10-07 10:41:42 -07:00
ice_lib.c	ice: fix vsi->txq_map sizing	2021-11-22 08:33:54 -08:00
ice_lib.h	ice: Remove boolean vlan_promisc flag from function	2021-10-29 10:48:16 -07:00
ice_main.c	ice: Remove boolean vlan_promisc flag from function	2021-10-29 10:48:16 -07:00
ice_nvm.c
ice_nvm.h
ice_osdep.h
ice_protocol_type.h	ice: support for GRE in eswitch	2021-10-28 11:00:20 -07:00
ice_ptp.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-10-28 10:43:58 -07:00
ice_ptp.h	ice: split ice_ring onto Tx/Rx separate structs	2021-10-15 07:39:02 -07:00
ice_ptp_hw.c	ice: Add support for SMA control multiplexer	2021-10-14 07:37:30 -07:00
ice_ptp_hw.h	ice: Add support for SMA control multiplexer	2021-10-14 07:37:30 -07:00
ice_repr.c	ice: Add support for changing MTU on PR in switchdev mode	2021-10-28 11:00:20 -07:00
ice_repr.h	ice: rebuild switchdev when resetting all VFs	2021-10-07 10:41:42 -07:00
ice_sbq_cmd.h
ice_sched.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-10-22 11:41:16 +01:00
ice_sched.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-10-22 11:41:16 +01:00
ice_sriov.c
ice_sriov.h
ice_status.h
ice_switch.c	ice: fix error return code in ice_get_recp_frm_fw()	2021-10-28 11:00:21 -07:00
ice_switch.h	ice: low level support for tunnels	2021-10-28 11:00:20 -07:00
ice_tc_lib.c	ice: support for GRE in eswitch	2021-10-28 11:00:20 -07:00
ice_tc_lib.h	ice: VXLAN and Geneve TC support	2021-10-28 11:00:18 -07:00
ice_trace.h	ice: split ice_ring onto Tx/Rx separate structs	2021-10-15 07:39:02 -07:00
ice_txrx.c	ice: use devm_kcalloc() instead of devm_kzalloc()	2021-10-19 10:53:28 -07:00
ice_txrx.h	ice: Add infrastructure for mqprio support via ndo_setup_tc	2021-10-20 15:57:54 -07:00
ice_txrx_lib.c	ice: introduce XDP_TX fallback path	2021-10-15 07:39:03 -07:00
ice_txrx_lib.h	ice: propagate xdp_ring onto rx_ring	2021-10-15 07:39:03 -07:00
ice_type.h	ice: Add infrastructure for mqprio support via ndo_setup_tc	2021-10-20 15:57:54 -07:00
ice_virtchnl_allowlist.c
ice_virtchnl_allowlist.h
ice_virtchnl_fdir.c
ice_virtchnl_fdir.h
ice_virtchnl_pf.c	ice: Fix race conditions between virtchnl handling and VF ndo ops	2021-11-03 08:16:32 -07:00
ice_virtchnl_pf.h	ice: Fix race conditions between virtchnl handling and VF ndo ops	2021-11-03 08:16:32 -07:00
ice_xsk.c	intel: Simplify bool conversion	2021-10-29 09:42:33 -07:00
ice_xsk.h	ice: split ice_ring onto Tx/Rx separate structs	2021-10-15 07:39:02 -07:00
Makefile	ice: ndo_setup_tc implementation for PF	2021-10-11 09:03:04 -07:00