mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
![]() CRYPTO_LIB_CHACHA depends on CRYPTO for __crypto_xor, defined in crypto/algapi.c. This is a layering violation because the dependencies should only go in the other direction (crypto/ => lib/crypto/). Also the correct dependency would be CRYPTO_ALGAPI, not CRYPTO. Fix this by moving __crypto_xor into the utils module in lib/crypto/. Note that CRYPTO_LIB_CHACHA_GENERIC selected XOR_BLOCKS, which is unrelated and unnecessary. It was perhaps thought that XOR_BLOCKS was needed for __crypto_xor, but that's not the case. Signed-off-by: Eric Biggers <ebiggers@google.com> Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
||
---|---|---|
.. | ||
aes.c | ||
arc4.c | ||
blake2s-generic.c | ||
blake2s-selftest.c | ||
blake2s.c | ||
chacha.c | ||
chacha20poly1305-selftest.c | ||
chacha20poly1305.c | ||
curve25519-fiat32.c | ||
curve25519-generic.c | ||
curve25519-hacl64.c | ||
curve25519-selftest.c | ||
curve25519.c | ||
des.c | ||
Kconfig | ||
libchacha.c | ||
Makefile | ||
memneq.c | ||
poly1305-donna32.c | ||
poly1305-donna64.c | ||
poly1305.c | ||
sha1.c | ||
sha256.c | ||
utils.c |