mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
6d2555cde2
The ipmi communication is not restored after a specific version of BMC is
upgraded on our server.
The ipmi driver does not respond after printing the following log:
ipmi_ssif: Invalid response getting flags: 1c 1
I found that after entering this branch, ssif_info->ssif_state always
holds SSIF_GETTING_FLAGS and never return to IDLE.
As a result, the driver cannot be loaded, because the driver status is
checked during the unload process and must be IDLE in shutdown_ssif():
while (ssif_info->ssif_state != SSIF_IDLE)
schedule_timeout(1);
The process trigger this problem is:
1. One msg timeout and next msg start send, and call
ssif_set_need_watch().
2. ssif_set_need_watch()->watch_timeout()->start_flag_fetch() change
ssif_state to SSIF_GETTING_FLAGS.
3. In msg_done_handler() ssif_state == SSIF_GETTING_FLAGS, if an error
message is received, the second branch does not modify the ssif_state.
4. All retry action need IS_SSIF_IDLE() == True. Include retry action in
watch_timeout(), msg_done_handler(). Sending msg does not work either.
SSIF_IDLE is also checked in start_next_msg().
5. The only thing that can be triggered in the SSIF driver is
watch_timeout(), after destory_user(), this timer will stop too.
So, if enter this branch, the ssif_state will remain SSIF_GETTING_FLAGS
and can't send msg, no timer started, can't unload.
We did a comparative test before and after adding this patch, and the
result is effective.
Fixes:
|
||
|---|---|---|
| .. | ||
| bt-bmc.c | ||
| ipmb_dev_int.c | ||
| ipmi_bt_sm.c | ||
| ipmi_devintf.c | ||
| ipmi_dmi.c | ||
| ipmi_dmi.h | ||
| ipmi_ipmb.c | ||
| ipmi_kcs_sm.c | ||
| ipmi_msghandler.c | ||
| ipmi_plat_data.c | ||
| ipmi_plat_data.h | ||
| ipmi_powernv.c | ||
| ipmi_poweroff.c | ||
| ipmi_si.h | ||
| ipmi_si_hardcode.c | ||
| ipmi_si_hotmod.c | ||
| ipmi_si_intf.c | ||
| ipmi_si_mem_io.c | ||
| ipmi_si_parisc.c | ||
| ipmi_si_pci.c | ||
| ipmi_si_platform.c | ||
| ipmi_si_port_io.c | ||
| ipmi_si_sm.h | ||
| ipmi_smic_sm.c | ||
| ipmi_ssif.c | ||
| ipmi_watchdog.c | ||
| Kconfig | ||
| kcs_bmc.c | ||
| kcs_bmc.h | ||
| kcs_bmc_aspeed.c | ||
| kcs_bmc_cdev_ipmi.c | ||
| kcs_bmc_client.h | ||
| kcs_bmc_device.h | ||
| kcs_bmc_npcm7xx.c | ||
| kcs_bmc_serio.c | ||
| Makefile | ||
| ssif_bmc.c | ||