Daniel Borkmann 6bdacdb48e bpf: Fix BPF_JIT kconfig symbol dependency ... Randy reported a randconfig build error recently on i386: ld: arch/x86/net/bpf_jit_comp32.o: in function `do_jit': bpf_jit_comp32.c:(.text+0x28c9): undefined reference to `__bpf_call_base' ld: arch/x86/net/bpf_jit_comp32.o: in function `bpf_int_jit_compile': bpf_jit_comp32.c:(.text+0x3694): undefined reference to `bpf_jit_blind_constants' ld: bpf_jit_comp32.c:(.text+0x3719): undefined reference to `bpf_jit_binary_free' ld: bpf_jit_comp32.c:(.text+0x3745): undefined reference to `bpf_jit_binary_alloc' ld: bpf_jit_comp32.c:(.text+0x37d3): undefined reference to `bpf_jit_prog_release_other' [...] The cause was that b24abcff91 ("bpf, kconfig: Add consolidated menu entry for bpf with core options") moved BPF_JIT from net/Kconfig into kernel/bpf/Kconfig and previously BPF_JIT was guarded by a 'if NET'. However, there is no actual dependency on NET, it's just that menuconfig NET selects BPF. And the latter in turn causes kernel/bpf/core.o to be built which contains above symbols. Randy's randconfig didn't have NET set, and BPF wasn't either, but BPF_JIT otoh was. Detangle this by making BPF_JIT depend on BPF instead. arm64 was the only arch that pulled in its JIT in net/ via obj-$(CONFIG_NET), all others unconditionally pull this dir in via obj-y. Do the same since CONFIG_NET guard there is really useless as we compiled the JIT via obj-$(CONFIG_BPF_JIT) += bpf_jit_comp.o anyway. Fixes: b24abcff91 ("bpf, kconfig: Add consolidated menu entry for bpf with core options") Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org>		2021-05-20 23:48:37 +02:00
..
preload	bpf: Fix umd memory leak in copy_process()	2021-03-19 22:23:19 +01:00
arraymap.c	bpf: Add batched ops support for percpu array	2021-04-28 01:17:45 +02:00
bpf_inode_storage.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-03-25 15:31:22 -07:00
bpf_iter.c	bpf: Add bpf_for_each_map_elem() helper	2021-02-26 13:23:52 -08:00
bpf_local_storage.c
bpf_lru_list.c
bpf_lru_list.h
bpf_lsm.c	Networking changes for 5.13.	2021-04-29 11:57:23 -07:00
bpf_struct_ops.c	bpf: Fix fexit trampoline.	2021-03-18 00:22:51 +01:00
bpf_struct_ops_types.h
bpf_task_storage.c	bpf: Make symbol 'bpf_task_storage_busy' static	2021-03-16 12:24:20 -07:00
btf.c	bpf: Forbid trampoline attach for functions with variable arguments	2021-05-07 01:28:28 +02:00
cgroup.c
core.c	bpf: Remove unused parameter from ___bpf_prog_run	2021-04-03 01:38:52 +02:00
cpumap.c	bpf, cpumap: Bulk skb using netif_receive_skb_list	2021-04-27 17:13:49 +02:00
devmap.c	bpf, devmap: Move drop error path to devmap for XDP_REDIRECT	2021-03-18 16:38:51 +01:00
disasm.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-04-09 20:48:35 -07:00
disasm.h
dispatcher.c
hashtab.c	kernel/bpf/: Fix misspellings using codespell tool	2021-03-16 12:22:20 -07:00
helpers.c	bpf: Fix nested bpf_bprintf_prepare with more per-cpu buffers	2021-05-11 14:02:33 -07:00
inode.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-04-25 18:02:32 -07:00
Kconfig	bpf: Fix BPF_JIT kconfig symbol dependency	2021-05-20 23:48:37 +02:00
local_storage.c	bpf: Fix NULL pointer dereference in bpf_get_local_storage() helper	2021-03-25 18:31:36 -07:00
lpm_trie.c	bpf: Add support for batched ops in LPM trie maps	2021-03-25 18:51:08 -07:00
Makefile
map_in_map.c
map_in_map.h
map_iter.c
net_namespace.c
offload.c
percpu_freelist.c
percpu_freelist.h
prog_iter.c
queue_stack_maps.c
reuseport_array.c
ringbuf.c	bpf: Prevent writable memory-mapping of read-only ringbuf pages	2021-05-11 13:31:10 +02:00
stackmap.c	bpf: Refcount task stack in bpf_get_task_stack	2021-04-01 13:58:07 -07:00
syscall.c	bpf: Add kconfig knob for disabling unpriv bpf by default	2021-05-11 13:56:16 -07:00
sysfs_btf.c
task_iter.c
tnum.c
trampoline.c	bpf: Allow trampoline re-attach for tracing and lsm programs	2021-04-25 21:09:01 -07:00
verifier.c	bpf: Add deny list of btf ids check for tracing programs	2021-05-11 14:00:53 -07:00