mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
d49b48f088
gpiochip_add_data_with_key() adds the gpiochip to the gpio_devices list before of_gpiochip_add() is called, but it's only the latter which sets the ->of_xlate function pointer. gpiochip_find() can be called by someone else between these two actions, and it can find the chip and call of_gpiochip_match_node_and_xlate() which leads to the following crash due to a NULL ->of_xlate(). Unhandled prefetch abort: page domain fault (0x01b) at 0x00000000 Modules linked in: leds_gpio(+) gpio_generic(+) CPU: 0 PID: 830 Comm: insmod Not tainted 4.18.0+ #43 Hardware name: ARM-Versatile Express PC is at (null) LR is at of_gpiochip_match_node_and_xlate+0x2c/0x38 Process insmod (pid: 830, stack limit = 0x(ptrval)) (of_gpiochip_match_node_and_xlate) from (gpiochip_find+0x48/0x84) (gpiochip_find) from (of_get_named_gpiod_flags+0xa8/0x238) (of_get_named_gpiod_flags) from (gpiod_get_from_of_node+0x2c/0xc8) (gpiod_get_from_of_node) from (devm_fwnode_get_index_gpiod_from_child+0xb8/0x144) (devm_fwnode_get_index_gpiod_from_child) from (gpio_led_probe+0x208/0x3c4 [leds_gpio]) (gpio_led_probe [leds_gpio]) from (platform_drv_probe+0x48/0x9c) (platform_drv_probe) from (really_probe+0x1d0/0x3d4) (really_probe) from (driver_probe_device+0x78/0x1c0) (driver_probe_device) from (__driver_attach+0x120/0x13c) (__driver_attach) from (bus_for_each_dev+0x68/0xb4) (bus_for_each_dev) from (bus_add_driver+0x1a8/0x268) (bus_add_driver) from (driver_register+0x78/0x10c) (driver_register) from (do_one_initcall+0x54/0x1fc) (do_one_initcall) from (do_init_module+0x64/0x1f4) (do_init_module) from (load_module+0x2198/0x26ac) (load_module) from (sys_finit_module+0xe0/0x110) (sys_finit_module) from (ret_fast_syscall+0x0/0x54) One way to fix this would be to rework the hairy registration sequence in gpiochip_add_data_with_key(), but since I'd probably introduce a couple of new bugs if I attempted that, simply add a check for a non-NULL of_xlate function pointer in of_gpiochip_match_node_and_xlate(). This works since the driver looking for the gpio will simply fail to find the gpio and defer its probe and be reprobed when the driver which is registering the gpiochip has fully completed its probe. Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
||
|---|---|---|
| .. | ||
| devres.c | ||
| gpio-74x164.c | ||
| gpio-74xx-mmio.c | ||
| gpio-104-dio-48e.c | ||
| gpio-104-idi-48.c | ||
| gpio-104-idio-16.c | ||
| gpio-adnp.c | ||
| gpio-adp5520.c | ||
| gpio-adp5588.c | ||
| gpio-altera-a10sr.c | ||
| gpio-altera.c | ||
| gpio-amd8111.c | ||
| gpio-amdpt.c | ||
| gpio-arizona.c | ||
| gpio-aspeed.c | ||
| gpio-ath79.c | ||
| gpio-bcm-kona.c | ||
| gpio-bd9571mwv.c | ||
| gpio-brcmstb.c | ||
| gpio-bt8xx.c | ||
| gpio-clps711x.c | ||
| gpio-crystalcove.c | ||
| gpio-cs5535.c | ||
| gpio-da9052.c | ||
| gpio-da9055.c | ||
| gpio-davinci.c | ||
| gpio-dln2.c | ||
| gpio-dwapb.c | ||
| gpio-eic-sprd.c | ||
| gpio-em.c | ||
| gpio-ep93xx.c | ||
| gpio-exar.c | ||
| gpio-f7188x.c | ||
| gpio-ftgpio010.c | ||
| gpio-ge.c | ||
| gpio-gpio-mm.c | ||
| gpio-grgpio.c | ||
| gpio-hlwd.c | ||
| gpio-htc-egpio.c | ||
| gpio-ich.c | ||
| gpio-ingenic.c | ||
| gpio-intel-mid.c | ||
| gpio-iop.c | ||
| gpio-it87.c | ||
| gpio-janz-ttl.c | ||
| gpio-kempld.c | ||
| gpio-ks8695.c | ||
| gpio-loongson.c | ||
| gpio-loongson1.c | ||
| gpio-lp873x.c | ||
| gpio-lp3943.c | ||
| gpio-lp87565.c | ||
| gpio-lpc18xx.c | ||
| gpio-lpc32xx.c | ||
| gpio-lynxpoint.c | ||
| gpio-madera.c | ||
| gpio-max730x.c | ||
| gpio-max732x.c | ||
| gpio-max3191x.c | ||
| gpio-max7300.c | ||
| gpio-max7301.c | ||
| gpio-max77620.c | ||
| gpio-mb86s7x.c | ||
| gpio-mc9s08dz60.c | ||
| gpio-mc33880.c | ||
| gpio-menz127.c | ||
| gpio-merrifield.c | ||
| gpio-ml-ioh.c | ||
| gpio-mm-lantiq.c | ||
| gpio-mmio.c | ||
| gpio-mockup.c | ||
| gpio-mpc8xxx.c | ||
| gpio-mpc5200.c | ||
| gpio-msic.c | ||
| gpio-mt7621.c | ||
| gpio-mvebu.c | ||
| gpio-mxc.c | ||
| gpio-mxs.c | ||
| gpio-octeon.c | ||
| gpio-omap.c | ||
| gpio-palmas.c | ||
| gpio-pca953x.c | ||
| gpio-pcf857x.c | ||
| gpio-pch.c | ||
| gpio-pci-idio-16.c | ||
| gpio-pcie-idio-24.c | ||
| gpio-pisosr.c | ||
| gpio-pl061.c | ||
| gpio-pmic-eic-sprd.c | ||
| gpio-pxa.c | ||
| gpio-raspberrypi-exp.c | ||
| gpio-rc5t583.c | ||
| gpio-rcar.c | ||
| gpio-rdc321x.c | ||
| gpio-reg.c | ||
| gpio-sa1100.c | ||
| gpio-sch.c | ||
| gpio-sch311x.c | ||
| gpio-sodaville.c | ||
| gpio-spear-spics.c | ||
| gpio-sprd.c | ||
| gpio-sta2x11.c | ||
| gpio-stmpe.c | ||
| gpio-stp-xway.c | ||
| gpio-syscon.c | ||
| gpio-tb10x.c | ||
| gpio-tc3589x.c | ||
| gpio-tegra.c | ||
| gpio-tegra186.c | ||
| gpio-thunderx.c | ||
| gpio-timberdale.c | ||
| gpio-tpic2810.c | ||
| gpio-tps6586x.c | ||
| gpio-tps65086.c | ||
| gpio-tps65218.c | ||
| gpio-tps65910.c | ||
| gpio-tps65912.c | ||
| gpio-tps68470.c | ||
| gpio-ts4800.c | ||
| gpio-ts4900.c | ||
| gpio-ts5500.c | ||
| gpio-twl4030.c | ||
| gpio-twl6040.c | ||
| gpio-ucb1400.c | ||
| gpio-uniphier.c | ||
| gpio-vf610.c | ||
| gpio-viperboard.c | ||
| gpio-vr41xx.c | ||
| gpio-vx855.c | ||
| gpio-wcove.c | ||
| gpio-winbond.c | ||
| gpio-wm831x.c | ||
| gpio-wm8350.c | ||
| gpio-wm8994.c | ||
| gpio-ws16c48.c | ||
| gpio-xgene-sb.c | ||
| gpio-xgene.c | ||
| gpio-xilinx.c | ||
| gpio-xlp.c | ||
| gpio-xra1403.c | ||
| gpio-xtensa.c | ||
| gpio-zevio.c | ||
| gpio-zx.c | ||
| gpio-zynq.c | ||
| gpiolib-acpi.c | ||
| gpiolib-devprop.c | ||
| gpiolib-legacy.c | ||
| gpiolib-of.c | ||
| gpiolib-sysfs.c | ||
| gpiolib.c | ||
| gpiolib.h | ||
| Kconfig | ||
| Makefile | ||