linux/tools/perf
Ravi Bangoria 6740a4e70e perf report: Fix -F for branch & mem modes
perf report fails to add valid additional fields with -F when
used with branch or mem modes. Fix it.

Before patch:

  $ perf record -b
  $ perf report -b -F +srcline_from --stdio
  Error:
  Invalid --fields key: `srcline_from'

After patch:

  $ perf report -b -F +srcline_from --stdio
  # Samples: 8K of event 'cycles'
  # Event count (approx.): 8784
  ...

Committer notes:

There was an inversion: when looking at branch stack dimensions (keys)
it was checking if the sort mode was 'mem', not 'branch'.

Fixes: aa6b3c9923 ("perf report: Make -F more strict like -s")
Reported-by: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Reviewed-by: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Tested-by: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lore.kernel.org/lkml/20210304062958.85465-1-ravi.bangoria@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2021-03-06 16:54:32 -03:00
..
arch perf tests x86: Move insn.h include to make sure it finds stddef.h 2021-03-06 16:54:32 -03:00
bench perf bench numa: Fix the condition checks for max number of NUMA nodes 2021-03-06 16:54:25 -03:00
Documentation perf tools: Fix documentation of verbose options 2021-03-06 16:54:26 -03:00
examples/bpf perf bpf examples: Fix bpf.h header include directive in 5sec.c example 2021-01-15 16:31:46 -03:00
include/bpf
jvmti
pmu-events perf vendor events arm64: Add JSON metrics for imx8mp DDR Perf 2021-02-18 10:09:23 -03:00
python
scripts
tests perf test: Fix sample-parsing failure on non-x86 platforms 2021-03-06 16:54:31 -03:00
trace
ui perf annotate: Do not jump after 'k' is pressed 2021-02-17 15:25:18 -03:00
util perf report: Fix -F for branch & mem modes 2021-03-06 16:54:32 -03:00
.gitignore
Build perf daemon: Add daemon command 2021-02-09 15:42:57 -03:00
builtin-annotate.c
builtin-bench.c
builtin-buildid-cache.c perf buildid-cache: Add --debuginfod option to specify a server to fetch debug files 2020-12-28 12:20:39 -03:00
builtin-buildid-list.c perf buildid-list: Add support for mmap2's buildid events 2020-12-28 12:23:09 -03:00
builtin-c2c.c perf c2c: Support data block and addr block 2021-02-08 16:25:00 -03:00
builtin-config.c
builtin-daemon.c perf daemon: Fix compile error with Asan 2021-03-06 16:54:31 -03:00
builtin-data.c
builtin-diff.c perf diff: Don't crash on freeing errno-session on the error path 2021-03-06 16:54:25 -03:00
builtin-evlist.c
builtin-ftrace.c
builtin-help.c
builtin-inject.c perf inject jit: Add namespaces support 2021-02-03 13:10:44 -03:00
builtin-kallsyms.c
builtin-kmem.c
builtin-kvm.c
builtin-list.c
builtin-lock.c
builtin-mem.c perf tools: Support data block and addr block 2021-02-08 16:25:00 -03:00
builtin-probe.c
builtin-record.c perf auxtrace: Automatically group aux-output events 2021-02-18 16:11:19 -03:00
builtin-report.c
builtin-sched.c
builtin-script.c perf script: Add branch types for VM-Entry and VM-Exit 2021-02-18 16:12:51 -03:00
builtin-stat.c perf stat: Support L2 Topdown events 2021-02-08 16:25:00 -03:00
builtin-timechart.c
builtin-top.c
builtin-trace.c
builtin-version.c
builtin.h perf daemon: Add daemon command 2021-02-09 15:42:57 -03:00
check-headers.sh
command-list.txt perf daemon: Add daemon command 2021-02-09 15:42:57 -03:00
CREDITS
design.txt
Makefile
Makefile.config perf build: Support build BPF skeletons with perf 2021-01-15 15:49:07 -03:00
Makefile.perf perf build: Fix ccache usage in $(CC) when generating arch errno table 2021-03-06 16:54:26 -03:00
MANIFEST
perf-archive.sh perf archive: Fix filtering of empty build-ids 2021-03-06 16:54:31 -03:00
perf-completion.sh
perf-read-vdso.c
perf-sys.h
perf-with-kcore.sh
perf.c perf daemon: Add daemon command 2021-02-09 15:42:57 -03:00
perf.h