mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-04 08:17:46 +00:00

All file_operations should get a .llseek operation so we can make nonseekable_open the default for future file operations without a .llseek pointer. The three cases that we can automatically detect are no_llseek, seq_lseek and default_llseek. For cases where we can we can automatically prove that the file offset is always ignored, we use noop_llseek, which maintains the current behavior of not returning an error from a seek. New drivers should normally not use noop_llseek but instead use no_llseek and call nonseekable_open at open time. Existing drivers can be converted to do the same when the maintainer knows for certain that no user code relies on calling seek on the device file. The generated code is often incorrectly indented and right now contains comments that clarify for each added line why a specific variant was chosen. In the version that gets submitted upstream, the comments will be gone and I will manually fix the indentation, because there does not seem to be a way to do that using coccinelle. Some amount of new code is currently sitting in linux-next that should get the same modifications, which I will do at the end of the merge window. Many thanks to Julia Lawall for helping me learn to write a semantic patch that does all this. ===== begin semantic patch ===== // This adds an llseek= method to all file operations, // as a preparation for making no_llseek the default. // // The rules are // - use no_llseek explicitly if we do nonseekable_open // - use seq_lseek for sequential files // - use default_llseek if we know we access f_pos // - use noop_llseek if we know we don't access f_pos, // but we still want to allow users to call lseek // @ open1 exists @ identifier nested_open; @@ nested_open(...) { <+... nonseekable_open(...) ...+> } @ open exists@ identifier open_f; identifier i, f; identifier open1.nested_open; @@ int open_f(struct inode *i, struct file *f) { <+... ( nonseekable_open(...) | nested_open(...) ) ...+> } @ read disable optional_qualifier exists @ identifier read_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; expression E; identifier func; @@ ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off) { <+... ( *off = E | *off += E | func(..., off, ...) | E = *off ) ...+> } @ read_no_fpos disable optional_qualifier exists @ identifier read_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; @@ ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off) { ... when != off } @ write @ identifier write_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; expression E; identifier func; @@ ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off) { <+... ( *off = E | *off += E | func(..., off, ...) | E = *off ) ...+> } @ write_no_fpos @ identifier write_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; @@ ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off) { ... when != off } @ fops0 @ identifier fops; @@ struct file_operations fops = { ... }; @ has_llseek depends on fops0 @ identifier fops0.fops; identifier llseek_f; @@ struct file_operations fops = { ... .llseek = llseek_f, ... }; @ has_read depends on fops0 @ identifier fops0.fops; identifier read_f; @@ struct file_operations fops = { ... .read = read_f, ... }; @ has_write depends on fops0 @ identifier fops0.fops; identifier write_f; @@ struct file_operations fops = { ... .write = write_f, ... }; @ has_open depends on fops0 @ identifier fops0.fops; identifier open_f; @@ struct file_operations fops = { ... .open = open_f, ... }; // use no_llseek if we call nonseekable_open //////////////////////////////////////////// @ nonseekable1 depends on !has_llseek && has_open @ identifier fops0.fops; identifier nso ~= "nonseekable_open"; @@ struct file_operations fops = { ... .open = nso, ... +.llseek = no_llseek, /* nonseekable */ }; @ nonseekable2 depends on !has_llseek @ identifier fops0.fops; identifier open.open_f; @@ struct file_operations fops = { ... .open = open_f, ... +.llseek = no_llseek, /* open uses nonseekable */ }; // use seq_lseek for sequential files ///////////////////////////////////// @ seq depends on !has_llseek @ identifier fops0.fops; identifier sr ~= "seq_read"; @@ struct file_operations fops = { ... .read = sr, ... +.llseek = seq_lseek, /* we have seq_read */ }; // use default_llseek if there is a readdir /////////////////////////////////////////// @ fops1 depends on !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier readdir_e; @@ // any other fop is used that changes pos struct file_operations fops = { ... .readdir = readdir_e, ... +.llseek = default_llseek, /* readdir is present */ }; // use default_llseek if at least one of read/write touches f_pos ///////////////////////////////////////////////////////////////// @ fops2 depends on !fops1 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier read.read_f; @@ // read fops use offset struct file_operations fops = { ... .read = read_f, ... +.llseek = default_llseek, /* read accesses f_pos */ }; @ fops3 depends on !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier write.write_f; @@ // write fops use offset struct file_operations fops = { ... .write = write_f, ... + .llseek = default_llseek, /* write accesses f_pos */ }; // Use noop_llseek if neither read nor write accesses f_pos /////////////////////////////////////////////////////////// @ fops4 depends on !fops1 && !fops2 && !fops3 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier read_no_fpos.read_f; identifier write_no_fpos.write_f; @@ // write fops use offset struct file_operations fops = { ... .write = write_f, .read = read_f, ... +.llseek = noop_llseek, /* read and write both use no f_pos */ }; @ depends on has_write && !has_read && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier write_no_fpos.write_f; @@ struct file_operations fops = { ... .write = write_f, ... +.llseek = noop_llseek, /* write uses no f_pos */ }; @ depends on has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier read_no_fpos.read_f; @@ struct file_operations fops = { ... .read = read_f, ... +.llseek = noop_llseek, /* read uses no f_pos */ }; @ depends on !has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; @@ struct file_operations fops = { ... +.llseek = noop_llseek, /* no read or write fn */ }; ===== End semantic patch ===== Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Julia Lawall <julia@diku.dk> Cc: Christoph Hellwig <hch@infradead.org>
265 lines
6.4 KiB
C
265 lines
6.4 KiB
C
/*
|
|
* drivers/usb/core/file.c
|
|
*
|
|
* (C) Copyright Linus Torvalds 1999
|
|
* (C) Copyright Johannes Erdfelt 1999-2001
|
|
* (C) Copyright Andreas Gal 1999
|
|
* (C) Copyright Gregory P. Smith 1999
|
|
* (C) Copyright Deti Fliegl 1999 (new USB architecture)
|
|
* (C) Copyright Randy Dunlap 2000
|
|
* (C) Copyright David Brownell 2000-2001 (kernel hotplug, usb_device_id,
|
|
more docs, etc)
|
|
* (C) Copyright Yggdrasil Computing, Inc. 2000
|
|
* (usb_device_id matching changes by Adam J. Richter)
|
|
* (C) Copyright Greg Kroah-Hartman 2002-2003
|
|
*
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/rwsem.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/smp_lock.h>
|
|
#include <linux/usb.h>
|
|
|
|
#include "usb.h"
|
|
|
|
#define MAX_USB_MINORS 256
|
|
static const struct file_operations *usb_minors[MAX_USB_MINORS];
|
|
static DECLARE_RWSEM(minor_rwsem);
|
|
|
|
static int usb_open(struct inode * inode, struct file * file)
|
|
{
|
|
int minor = iminor(inode);
|
|
const struct file_operations *c;
|
|
int err = -ENODEV;
|
|
const struct file_operations *old_fops, *new_fops = NULL;
|
|
|
|
down_read(&minor_rwsem);
|
|
c = usb_minors[minor];
|
|
|
|
if (!c || !(new_fops = fops_get(c)))
|
|
goto done;
|
|
|
|
old_fops = file->f_op;
|
|
file->f_op = new_fops;
|
|
/* Curiouser and curiouser... NULL ->open() as "no device" ? */
|
|
if (file->f_op->open)
|
|
err = file->f_op->open(inode,file);
|
|
if (err) {
|
|
fops_put(file->f_op);
|
|
file->f_op = fops_get(old_fops);
|
|
}
|
|
fops_put(old_fops);
|
|
done:
|
|
up_read(&minor_rwsem);
|
|
return err;
|
|
}
|
|
|
|
static const struct file_operations usb_fops = {
|
|
.owner = THIS_MODULE,
|
|
.open = usb_open,
|
|
.llseek = noop_llseek,
|
|
};
|
|
|
|
static struct usb_class {
|
|
struct kref kref;
|
|
struct class *class;
|
|
} *usb_class;
|
|
|
|
static char *usb_devnode(struct device *dev, mode_t *mode)
|
|
{
|
|
struct usb_class_driver *drv;
|
|
|
|
drv = dev_get_drvdata(dev);
|
|
if (!drv || !drv->devnode)
|
|
return NULL;
|
|
return drv->devnode(dev, mode);
|
|
}
|
|
|
|
static int init_usb_class(void)
|
|
{
|
|
int result = 0;
|
|
|
|
if (usb_class != NULL) {
|
|
kref_get(&usb_class->kref);
|
|
goto exit;
|
|
}
|
|
|
|
usb_class = kmalloc(sizeof(*usb_class), GFP_KERNEL);
|
|
if (!usb_class) {
|
|
result = -ENOMEM;
|
|
goto exit;
|
|
}
|
|
|
|
kref_init(&usb_class->kref);
|
|
usb_class->class = class_create(THIS_MODULE, "usb");
|
|
if (IS_ERR(usb_class->class)) {
|
|
result = IS_ERR(usb_class->class);
|
|
printk(KERN_ERR "class_create failed for usb devices\n");
|
|
kfree(usb_class);
|
|
usb_class = NULL;
|
|
goto exit;
|
|
}
|
|
usb_class->class->devnode = usb_devnode;
|
|
|
|
exit:
|
|
return result;
|
|
}
|
|
|
|
static void release_usb_class(struct kref *kref)
|
|
{
|
|
/* Ok, we cheat as we know we only have one usb_class */
|
|
class_destroy(usb_class->class);
|
|
kfree(usb_class);
|
|
usb_class = NULL;
|
|
}
|
|
|
|
static void destroy_usb_class(void)
|
|
{
|
|
if (usb_class)
|
|
kref_put(&usb_class->kref, release_usb_class);
|
|
}
|
|
|
|
int usb_major_init(void)
|
|
{
|
|
int error;
|
|
|
|
error = register_chrdev(USB_MAJOR, "usb", &usb_fops);
|
|
if (error)
|
|
printk(KERN_ERR "Unable to get major %d for usb devices\n",
|
|
USB_MAJOR);
|
|
|
|
return error;
|
|
}
|
|
|
|
void usb_major_cleanup(void)
|
|
{
|
|
unregister_chrdev(USB_MAJOR, "usb");
|
|
}
|
|
|
|
/**
|
|
* usb_register_dev - register a USB device, and ask for a minor number
|
|
* @intf: pointer to the usb_interface that is being registered
|
|
* @class_driver: pointer to the usb_class_driver for this device
|
|
*
|
|
* This should be called by all USB drivers that use the USB major number.
|
|
* If CONFIG_USB_DYNAMIC_MINORS is enabled, the minor number will be
|
|
* dynamically allocated out of the list of available ones. If it is not
|
|
* enabled, the minor number will be based on the next available free minor,
|
|
* starting at the class_driver->minor_base.
|
|
*
|
|
* This function also creates a usb class device in the sysfs tree.
|
|
*
|
|
* usb_deregister_dev() must be called when the driver is done with
|
|
* the minor numbers given out by this function.
|
|
*
|
|
* Returns -EINVAL if something bad happens with trying to register a
|
|
* device, and 0 on success.
|
|
*/
|
|
int usb_register_dev(struct usb_interface *intf,
|
|
struct usb_class_driver *class_driver)
|
|
{
|
|
int retval = -EINVAL;
|
|
int minor_base = class_driver->minor_base;
|
|
int minor = 0;
|
|
char name[20];
|
|
char *temp;
|
|
|
|
#ifdef CONFIG_USB_DYNAMIC_MINORS
|
|
/*
|
|
* We don't care what the device tries to start at, we want to start
|
|
* at zero to pack the devices into the smallest available space with
|
|
* no holes in the minor range.
|
|
*/
|
|
minor_base = 0;
|
|
#endif
|
|
intf->minor = -1;
|
|
|
|
dbg ("looking for a minor, starting at %d", minor_base);
|
|
|
|
if (class_driver->fops == NULL)
|
|
goto exit;
|
|
|
|
down_write(&minor_rwsem);
|
|
for (minor = minor_base; minor < MAX_USB_MINORS; ++minor) {
|
|
if (usb_minors[minor])
|
|
continue;
|
|
|
|
usb_minors[minor] = class_driver->fops;
|
|
|
|
retval = 0;
|
|
break;
|
|
}
|
|
up_write(&minor_rwsem);
|
|
|
|
if (retval)
|
|
goto exit;
|
|
|
|
retval = init_usb_class();
|
|
if (retval)
|
|
goto exit;
|
|
|
|
intf->minor = minor;
|
|
|
|
/* create a usb class device for this usb interface */
|
|
snprintf(name, sizeof(name), class_driver->name, minor - minor_base);
|
|
temp = strrchr(name, '/');
|
|
if (temp && (temp[1] != '\0'))
|
|
++temp;
|
|
else
|
|
temp = name;
|
|
intf->usb_dev = device_create(usb_class->class, &intf->dev,
|
|
MKDEV(USB_MAJOR, minor), class_driver,
|
|
"%s", temp);
|
|
if (IS_ERR(intf->usb_dev)) {
|
|
down_write(&minor_rwsem);
|
|
usb_minors[intf->minor] = NULL;
|
|
up_write(&minor_rwsem);
|
|
retval = PTR_ERR(intf->usb_dev);
|
|
}
|
|
exit:
|
|
return retval;
|
|
}
|
|
EXPORT_SYMBOL_GPL(usb_register_dev);
|
|
|
|
/**
|
|
* usb_deregister_dev - deregister a USB device's dynamic minor.
|
|
* @intf: pointer to the usb_interface that is being deregistered
|
|
* @class_driver: pointer to the usb_class_driver for this device
|
|
*
|
|
* Used in conjunction with usb_register_dev(). This function is called
|
|
* when the USB driver is finished with the minor numbers gotten from a
|
|
* call to usb_register_dev() (usually when the device is disconnected
|
|
* from the system.)
|
|
*
|
|
* This function also removes the usb class device from the sysfs tree.
|
|
*
|
|
* This should be called by all drivers that use the USB major number.
|
|
*/
|
|
void usb_deregister_dev(struct usb_interface *intf,
|
|
struct usb_class_driver *class_driver)
|
|
{
|
|
int minor_base = class_driver->minor_base;
|
|
char name[20];
|
|
|
|
#ifdef CONFIG_USB_DYNAMIC_MINORS
|
|
minor_base = 0;
|
|
#endif
|
|
|
|
if (intf->minor == -1)
|
|
return;
|
|
|
|
dbg ("removing %d minor", intf->minor);
|
|
|
|
down_write(&minor_rwsem);
|
|
usb_minors[intf->minor] = NULL;
|
|
up_write(&minor_rwsem);
|
|
|
|
snprintf(name, sizeof(name), class_driver->name, intf->minor - minor_base);
|
|
device_destroy(usb_class->class, MKDEV(USB_MAJOR, intf->minor));
|
|
intf->usb_dev = NULL;
|
|
intf->minor = -1;
|
|
destroy_usb_class();
|
|
}
|
|
EXPORT_SYMBOL_GPL(usb_deregister_dev);
|